Velopack allows uninstall while the viewer is running & viewer crashes (obviously)

[canny]

• Log in on a Velopack viewer.

• Go to Windows "Add / Remove Programs"

• Uninstall the Velopack viewer.

Observed Behaviour

• You are able to uninstall the viewer while logged in on it

• The viewer instantly crashes

• Any settings changed that session are lost

Expected Behaviour

• You should not be allowed to uninstall the viewer while it is running

• Velopack should check if another application with the same window class is running

https://secondlife.canny.io/admin/feedback/bug-reports/p/velopack-allows-uninstall-while-the-viewer-is-running-viewer-crashes-obviously

---

Test plan:

• Install velopack based viewers in 2 folders A and B using --installto
• Log into the viewer in folder A
• Log into the viewer in folder B
• Uninstall the viewer (via Apps > Installed apps and also right-clicking the app in the start menu). (I think this will uninstall the viewer that was last installed, folder B)
• Verify viewer B is immediately closed, and uninstalled.
• Verify viewer A continues running.

[canny]

This issue has been linked to a Canny post: Velopack allows uninstall while the viewer is running & viewer crashes (obviously) 🎉

[jellyfish-linden]

Somebody on the FS dev team suggested this has to do with checking the window class during uninstall. Might want to also check the install process too.

[akleshchev]

Somebody on the FS dev team suggested this has to do with checking the window class during uninstall. Might want to also check the install process too.

FS are talking about NSIS tracking 'window class'. Velopack doesn't seem to do that natively, potentially we can use BeforeUninstall hook.