fix: windows abs path support (#3720)

* fix: windows abs path support

* Update util/local_path.go

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

* test: add unit tests for repositoryUrl.js getRepositoryUrlType and isLocalRepositoryPath

Co-authored-by: fiftin <914224+fiftin@users.noreply.github.com>
Agent-Logs-Url: https://github.com/semaphoreui/semaphore/sessions/bbce1987-8c41-40ba-bd52-87b87cce5d48

* fix(repo): validate windows path

---------

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com>
Co-authored-by: fiftin <914224+fiftin@users.noreply.github.com>

Author: 3 people

db/Repository.go

@@ -66,6 +66,10 @@ func (r Repository) GetFullPath(templateID int) string {
 func (r Repository) GetGitURL(secure bool) string {
 	url := r.GitURL
 
+	if r.GetType() == RepositoryLocal {
+		return util.NormalizeLocalFilesystemPath(url)
+	}
+
 	if secure {
 		return url
 	}
@@ -105,6 +109,10 @@ func (r Repository) GetType() RepositoryType {
 		return RepositoryLocal
 	}
 
+	if util.IsWindowsLocalRepositoryPath(r.GitURL) {
+		return RepositoryLocal
+	}
+
 	re := regexp.MustCompile(`^(\w+)://`)
 	m := re.FindStringSubmatch(r.GitURL)
 	if m == nil {

db/Repository_test.go

@@ -17,6 +17,13 @@ func TestRepository_GetSchema(t *testing.T) {
 	assert.Equal(t, RepositoryHTTP, schema)
 }
 
+func TestRepository_GetType_WindowsLocalPath(t *testing.T) {
+	assert.Equal(t, RepositoryLocal, Repository{GitURL: `D:\repo`}.GetType())
+	assert.Equal(t, RepositoryLocal, Repository{GitURL: `D:/repo`}.GetType())
+	assert.Equal(t, RepositoryLocal, Repository{GitURL: `D:`}.GetType())
+	assert.Equal(t, RepositoryLocal, Repository{GitURL: `\\server\share`}.GetType())
+}
+
 func TestRepository_ClearCache(t *testing.T) {
 	util.Config = &util.ConfigType{
 		TmpPath: path.Join(os.TempDir(), util.RandString(rand.Intn(10-4)+4)),

services/tasks/LocalJob.go

@@ -819,8 +819,9 @@ func (t *LocalJob) prepareRun(installingArgs db_lib.LocalAppInstallingArgs) erro
 	}
 
 	if t.Repository.GetType() == db.RepositoryLocal {
-		if _, err := os.Stat(t.Repository.GitURL); err != nil {
-			t.Log("Failed in finding static repository at " + t.Repository.GitURL + ": " + err.Error())
+		localPath := t.Repository.GetGitURL(true)
+		if _, err := os.Stat(localPath); err != nil {
+			t.Log("Failed in finding static repository at " + localPath + ": " + err.Error())
 			return err
 		}
 	} else {
@@ -879,8 +880,9 @@ func (t *LocalJob) prepareRunTerraform(tfApp *db_lib.TerraformApp, installingArg
 	}
 
 	if t.Repository.GetType() == db.RepositoryLocal {
-		if _, err := os.Stat(t.Repository.GitURL); err != nil {
-			t.Log("Failed in finding static repository at " + t.Repository.GitURL + ": " + err.Error())
+		localPath := t.Repository.GetGitURL(true)
+		if _, err := os.Stat(localPath); err != nil {
+			t.Log("Failed in finding static repository at " + localPath + ": " + err.Error())
 			return err
 		}
 	} else {

util/local_path.go

@@ -0,0 +1,57 @@
+package util
+
+import (
+	"path/filepath"
+	"runtime"
+	"strings"
+)
+
+// NormalizeLocalFilesystemPath converts paths that Git Bash / MSYS often produce
+// into a form native Windows APIs accept. Other paths are returned unchanged.
+func NormalizeLocalFilesystemPath(p string) string {
+	if runtime.GOOS != "windows" {
+		return p
+	}
+	// "/D:/path" -> "D:/path", "/d:\path" -> "d:\path" (strip leading "/")
+	if len(p) >= 3 && p[0] == '/' && isDriveLetter(p[1]) && p[2] == ':' {
+		return p[1:]
+	}
+	// "/d/path" (MSYS) -> "D:\path"
+	if len(p) >= 3 && p[0] == '/' && isDriveLetter(p[1]) && p[2] == '/' {
+		rest := p[3:]
+		drive := strings.ToUpper(string(p[1]))
+		if rest == "" {
+			return drive + ":\\"
+		}
+		return drive + ":" + string(filepath.Separator) + filepath.FromSlash(rest)
+	}
+	return p
+}
+
+func isDriveLetter(c byte) bool {
+	return (c >= 'A' && c <= 'Z') || (c >= 'a' && c <= 'z')
+}
+
+// IsWindowsLocalRepositoryPath reports whether p is a Windows drive-letter or UNC
+// path used as a local (non-Git) repository URL.
+func IsWindowsLocalRepositoryPath(p string) bool {
+	if len(p) < 2 {
+		return false
+	}
+	if p[0] == '\\' && p[1] == '\\' {
+		return len(p) > 2
+	}
+	if !isDriveLetter(p[0]) || p[1] != ':' {
+		return false
+	}
+	if len(p) == 2 {
+		return true
+	}
+	if p[2] != '\\' && p[2] != '/' {
+		return false
+	}
+	if len(p) > 3 && p[2] == '/' && p[3] == '/' {
+		return false
+	}
+	return true
+}

util/local_path_test.go

@@ -0,0 +1,55 @@
+package util
+
+import (
+	"path/filepath"
+	"runtime"
+	"testing"
+)
+
+func TestIsWindowsLocalRepositoryPath(t *testing.T) {
+	tests := []struct {
+		path string
+		want bool
+	}{
+		{`D:\repo`, true},
+		{`D:/repo`, true},
+		{`D:`, true},
+		{`D:repo`, false},
+		{`a://example/repo.git`, false},
+		{`c:\`, true},
+		{`\\server\share`, true},
+		{`\\`, false},
+		{``, false},
+		{`/usr/src`, false},
+		{`https://x`, false},
+	}
+	for _, tt := range tests {
+		if got := IsWindowsLocalRepositoryPath(tt.path); got != tt.want {
+			t.Errorf("IsWindowsLocalRepositoryPath(%q) = %v, want %v", tt.path, got, tt.want)
+		}
+	}
+}
+
+func TestNormalizeLocalFilesystemPath(t *testing.T) {
+	if runtime.GOOS == "windows" {
+		t.Run("leading_slash_before_drive", func(t *testing.T) {
+			got := NormalizeLocalFilesystemPath("/D:/ps-demo-script")
+			want := "D:/ps-demo-script"
+			if got != want {
+				t.Fatalf("got %q want %q", got, want)
+			}
+		})
+		t.Run("msys_drive_path", func(t *testing.T) {
+			got := NormalizeLocalFilesystemPath("/d/ps-demo-script/extra")
+			want := "D:" + string(filepath.Separator) + filepath.FromSlash("ps-demo-script/extra")
+			if got != want {
+				t.Fatalf("got %q want %q", got, want)
+			}
+		})
+	} else {
+		p := "/D:/ps-demo-script"
+		if got := NormalizeLocalFilesystemPath(p); got != p {
+			t.Fatalf("non-Windows should leave path unchanged: got %q", got)
+		}
+	}
+}