Fix workflow bugs, stale docs, and dead code from KMP migration

- Fix run_gradle.yml ref variable (github.event.inputs.ref → inputs.ref)
- Fix pr.yml docs detection logic (mkdocs.yml/main.py were unreachable)
- Remove undefined inputs.ref from pr.yml/master.yml callers
- Fix firstOrNull in faker-provider-conventions (first makes ?: throw dead)
- Fix kotest-bom copy-paste in bom comment
- Update CLAUDE.md: Java 8→11, Kotlin 1.9→2.x, stale src paths
- Remove duplicate configureondemand, unused Android properties
- Remove dead nexus-publish plugin and gradle-plugin-bcv library from catalog
- Delete dead utils/Ci.kt
- Remove commented-out code in cli-bot/build.gradle.kts

Author: serpro69

.github/workflows/master.yml

@@ -22,7 +22,7 @@ jobs:
     secrets: inherit
     with:
       runs-on: ubuntu-latest
-      ref: ${{ inputs.ref }}
+      ref: master
       task: apiCheck
 
   build-primary:
@@ -39,7 +39,7 @@ jobs:
     uses: ./.github/workflows/run_gradle.yml
     secrets: inherit
     with:
-      ref: ${{ inputs.ref }}
+      ref: master
       task: >
         -P"kotlinFaker_enableKotlinJs=true"
         -P"kotlinFaker_enableKotlinNative=true"

.github/workflows/pr.yml

@@ -6,7 +6,7 @@ on:
   merge_group:
 
 env:
-  GRAALCE_JDK_VERSION: '17.0.9'
+  GRAALCE_JDK_VERSION: "17.0.9"
   # concatenation of env variables isn't currently supported
   # so need to specify version explicitly
   GRAALVM_HOME: /opt/hostedtoolcache/Java_graalce_jdk/17.0.9/x64
@@ -42,12 +42,12 @@ jobs:
           while IFS= read -r file
           do
             echo $file
-            if [[ $file != docs/* ]]; then
-              echo "This modified file is not under the 'docs' folder. Will run tests."
-              echo "run_tests=true" >> $GITHUB_OUTPUT
-            elif [[ $file = docs/* ]] || [[ $file = mkdocs.yml ]] || [[ $file = main.py ]]; then
-              echo "This modified file is under the 'docs' folder. Will run docs workflow."
+            if [[ $file = docs/* ]] || [[ $file = mkdocs.yml ]] || [[ $file = main.py ]]; then
+              echo "This modified file is docs-related. Will run docs workflow."
               echo "run_docs=true" >> $GITHUB_OUTPUT
+            else
+              echo "This modified file is not docs-related. Will run tests."
+              echo "run_tests=true" >> $GITHUB_OUTPUT
             fi
           done < files.txt
 
@@ -59,7 +59,6 @@ jobs:
     secrets: inherit
     with:
       runs-on: ubuntu-latest
-      ref: ${{ inputs.ref }}
       task: apiCheck --continue
 
   gradle-check:
@@ -77,7 +76,6 @@ jobs:
     secrets: inherit
     with:
       runs-on: ${{ matrix.os }}
-      ref: ${{ inputs.ref }}
       task: >
         -P"kotlinFaker_enableKotlinJs=true"
         -P"kotlinFaker_enableKotlinNative=true"
@@ -105,7 +103,7 @@ jobs:
       - name: Set up GraalCE JDK
         uses: actions/setup-java@v4
         with:
-          distribution: 'jdkfile'
+          distribution: "jdkfile"
           jdkFile: ${{ runner.temp }}/java_package.tar.gz
           java-version: ${{ steps.fetch_latest_jdk.outputs.java_version }}
           architecture: x64
@@ -150,8 +148,6 @@ jobs:
     runs-on: ubuntu-latest
     steps:
       - uses: actions/checkout@v4
-        with:
-          ref: ${{ inputs.ref }}
       - uses: actions/setup-python@v5
         with:
           python-version: 3.x
@@ -170,7 +166,7 @@ jobs:
   finalize:
     # see https://github.qkg1.topmunity/t/status-check-for-a-matrix-jobs/127354/7
     name: Final PR results
-    needs: [validate-api, gradle-check, docs-check]
+    needs: [validate-api, gradle-check, docs-check, cli-check]
     if: ${{ always() }}
     runs-on: ubuntu-latest
     steps:

.github/workflows/run_gradle.yml

@@ -44,7 +44,7 @@ jobs:
       - name: Checkout the repo
         uses: actions/checkout@v4
         with:
-          ref: ${{ github.event.inputs.ref }}
+          ref: ${{ inputs.ref }}
 
       - name: Setup JDK
         uses: actions/setup-java@v4

CLAUDE.md

@@ -80,21 +80,20 @@ The project follows a multi-module Gradle build:
 
 When adding a new provider to `core` or creating a new faker module:
 
-1. Add YAML dictionary file to `core/src/main/resources/locales/en/{category}.yml` (or to appropriate faker module)
-2. Create provider class extending `YamlFakeDataProvider` in `core/src/main/kotlin/io/github/serpro69/kfaker/provider/` (or faker module's provider package)
+1. Add YAML dictionary file to `core/src/jvmMain/resources/locales/en/{category}.yml` (or to appropriate faker module)
+2. Create provider class extending `YamlFakeDataProvider` in `core/src/jvmMain/kotlin/io/github/serpro69/kfaker/provider/` (or faker module's provider package)
 3. Add property to `Faker` class (or appropriate faker class) that instantiates the provider
 4. Update `cli-bot/src/main/kotlin/io/github/serpro69/kfaker/app/Constants.kt` for CLI support
 5. Update native-image `reflect-config.json` in `cli-bot/src/main/resources/META-INF/native-image/`
-6. Update test constants in `core/src/test/kotlin/io/github/serpro69/kfaker/TestConstants.kt`
+6. Update test constants in `core/src/jvmTest/kotlin/io/github/serpro69/kfaker/TestConstants.kt`
 7. Update `cli-bot/src/test/kotlin/io/github/serpro69/kfaker/app/cli/IntrospectorTest.kt`
 
 See CONTRIBUTING.md for detailed step-by-step instructions and examples.
 
 ## Java Version Requirements
 
-- **Runtime**: Java 8 + Kotlin 1.9.x
-- **Build**: Requires JDK 11 or higher (due to GraalVM buildtools plugin in cli-bot)
-- **Toolchains**: Core libs use Gradle toolchains to compile with Java 8 compatibility
+- **Runtime**: Java 11 + Kotlin 2.x
+- **Build**: Requires JDK 21 (configured via Gradle toolchains)
 - **Native Image**: Requires GraalVM CE JDK 17 for building cli-bot native image
 
 The project uses Gradle toolchains to automatically provision correct JDK versions.

bom/build.gradle.kts

@@ -29,7 +29,7 @@ fun projectsFilter(candidateProject: Project) =
 rootProject.subprojects.filter(::projectsFilter).forEach { bom.evaluationDependsOn(it.path) }
 
 configurations.api.configure {
-    // lazily add the coords from all subprojects to the kotest-bom
+    // lazily add the coords from all subprojects to the faker-bom
     dependencyConstraints.addAllLater(
         fakerBomService.coordinates.map { coords ->
             logger.lifecycle("[$path] adding ${coords.size} coords to faker-bom: $coords")

buildSrc/src/main/kotlin/faker-provider-conventions.gradle.kts

@@ -2,7 +2,7 @@
 plugins { id("faker-lib-conventions") }
 
 val core =
-    rootProject.subprojects.first { it.path == ":kotlin-faker" }
+    rootProject.subprojects.firstOrNull { it.path == ":kotlin-faker" }
         ?: throw GradleException(":kotlin-faker project not found")
 
 kotlin {

buildSrc/src/main/kotlin/utils/Ci.kt

@@ -52,7 +52,6 @@ tasks.withType<Test> {
 }
 
 application {
-    //    mainClassName = mainFunction
     mainClass.set(mainFunction)
 }
 
@@ -113,16 +112,6 @@ graalvmNative {
     }
 }
 
-// graalvmNative {
-//    graalVersion("21.2.0")
-//    javaVersion("8")
-//    mainClass(mainFunction)
-//    outputName("faker-bot_${project.version}")
-//    option("--no-fallback")
-//    option("--no-server")
-//    option("--report-unsupported-elements-at-runtime")
-// }
-
 tasks {
     all {
         onlyIf("enable cli") {

cli-bot/build.gradle.kts

@@ -1,7 +1,6 @@
 version=0.0.0
 kotlin.code.style=official
 org.gradle.jvmargs=-Xmx8g -XX:+HeapDumpOnOutOfMemoryError -Dfile.encoding=UTF-8
-org.gradle.configureondemand=true
 systemProp.org.gradle.jvmargs=-Xmx4g -XX:+HeapDumpOnOutOfMemoryError -Dfile.encoding=UTF-8
 
 org.gradle.caching=true
@@ -20,9 +19,6 @@ kotlin.mpp.stability.nowarn=true
 kotlin.incremental=true
 kotlin.incremental.js=true
 
-android.useAndroidX=true
-android.enableJetifier=true
-
 # KotlinFaker build settings
 # enabled/disable Kotlin targets, for improving local dev & CI/CD performance
 kotlinFaker_enableKotlinJs=true

gradle.properties

@@ -14,7 +14,6 @@ plugin-dokka = "2.0.0"
 plugin-semantic-versioning = "0.13.0"
 plugin-devpublish = "0.4.1"
 plugin-nmcp = "1.0.2"
-plugin-nexus-publish = "2.0.0"
 plugin-benmanes-versions = "0.51.0"
 plugin-spotless = "7.2.1"
 # test
@@ -49,8 +48,6 @@ rgxgen = { module = "com.github.curious-odd-man:rgxgen", version.ref = "rgxgen"
 # Plugins and dependencies for use in buildSrc/build.gradle.kts
 # Plugins are the *Maven coodinates* of Gradle plugins.
 gradle-plugin-kotlin = { module = "org.jetbrains.kotlin:kotlin-gradle-plugin", version.ref = "kotlin" }
-#gradle-plugin-ktLint = { module = "org.jlleitschuh.gradle:ktlint-gradle", version.ref = "ktlint" }
-gradle-plugin-bcv = { module = "org.jetbrains.kotlinx.binary-compatibility-validator:org.jetbrains.kotlinx.binary-compatibility-validator.gradle.plugin", version.ref = "plugin-bcv" }
 gradle-plugin-dokka = { module = "org.jetbrains.dokka:dokka-gradle-plugin", version.ref = "plugin-dokka" }
 gradle-plugin-semantic-versioning = { module = "io.github.serpro69:semantic-versioning", version.ref = "plugin-semantic-versioning" }
 gradle-plugin-spotless = { module = "com.diffplug.spotless:spotless-plugin-gradle", version.ref = "plugin-spotless" }
@@ -84,7 +81,6 @@ test-kotest = [
 [plugins]
 # these are for root build.gradle.kts
 # most plugins are imported using Maven coordinates (see above), not the Gradle plugin ID
-nexus-publish = { id = "io.github.gradle-nexus.publish-plugin", version.ref = "plugin-nexus-publish" }
 benmanes-versions = { id = "com.github.ben-manes.versions", version.ref = "plugin-benmanes-versions" }
 dokka = { id = "org.jetbrains.dokka" }
 bcv = { id = "org.jetbrains.kotlinx.binary-compatibility-validator", version.ref = "plugin-bcv" }