mozjs-sys: Build from source if the jitspew feature is enabled#728
Merged
jdm merged 2 commits intoservo:mainfrom Apr 8, 2026
Merged
mozjs-sys: Build from source if the jitspew feature is enabled#728jdm merged 2 commits intoservo:mainfrom
jdm merged 2 commits intoservo:mainfrom
Conversation
Signed-off-by: Simon Wülker <simon.wuelker@arcor.de>
Signed-off-by: Simon Wülker <simon.wuelker@arcor.de>
jdm
approved these changes
Apr 8, 2026
Member
Author
|
Now I need a maintainer with the necessary permissions to merge & publish this |
Member
Hm, given that you are in maintainers team you should be able to land this yourself: |
Member
Author
I can't publish the crate to sync servo though. I'm used to html5ever, the merge queue there is so fast that its easier if you only merge the change if someone is ready to publish right after, otherwise its easy to run into issues when multiple PRs want to get released. |
Member
|
Publish is automatic on merge here. |
github-merge-queue bot
pushed a commit
to servo/servo
that referenced
this pull request
Apr 8, 2026
The `IONFLAGS` environment variable configure logging for the JIT, but it must be enabled in spidermonkey at compile time. The prebuilt mozjs binaries don't enable it, so we must build from source. Companion PR for servo/mozjs#728 Testing: We don't have tests for the build process --------- Signed-off-by: Simon Wülker <simon.wuelker@arcor.de>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Otherwise the
IONFLAGSenvironment variable does nothing.Testing: We don't have tests for the build process
Servo companion PR: servo/servo#44010