Fix a variety of warnings throughout the code (#359)

Signed-off-by: Martin Robinson <mrobinson@igalia.com>

Author: mrobinson

examples/offscreen.rs

@@ -8,7 +8,7 @@ use crate::common::{ck, Buffer, FilesystemResourceLoader, Program, Shader, Shade
 use clap::{App, Arg};
 use euclid::default::Size2D;
 use gl;
-use gl::types::{GLchar, GLenum, GLint, GLuint, GLvoid};
+use gl::types::{GLenum, GLint, GLuint, GLvoid};
 use png::{BitDepth, ColorType, Encoder};
 use std::fs::File;
 use std::mem;

examples/threads.rs

@@ -7,7 +7,7 @@
 use self::common::{ck, Buffer, Program, ResourceLoader, Shader, ShaderKind};
 
 use euclid::default::{Point2D, Rect, Size2D, Vector2D};
-use gl::types::{GLchar, GLenum, GLint, GLuint, GLvoid};
+use gl::types::{GLenum, GLint, GLuint};
 use std::sync::mpsc::{self, Receiver, Sender};
 use std::thread;
 use surfman::{declare_surfman, SurfaceAccess, SurfaceTexture, SurfaceType};
@@ -122,7 +122,6 @@ fn main() {
     };
 
     let event_loop = EventLoop::new().expect("couldn't create eventloop");
-    let window_size = Size2D::new(WINDOW_WIDTH, WINDOW_HEIGHT);
     let physical_size = PhysicalSize::new(WINDOW_WIDTH, WINDOW_HEIGHT);
 
     let window = WindowBuilder::new()

src/platform/macos/system/surface.rs

@@ -28,7 +28,7 @@ use objc2_io_surface::{
     kIOSurfaceBytesPerElement, kIOSurfaceBytesPerRow, kIOSurfaceCacheMode, kIOSurfaceHeight,
     kIOSurfacePixelFormat, kIOSurfaceWidth, IOSurfaceLockOptions, IOSurfaceRef,
 };
-use objc2_quartz_core::{kCAGravityTopLeft, CALayer, CATransaction, CATransform3D};
+use objc2_quartz_core::{CALayer, CATransaction, CATransform3D};
 use std::fmt::{self, Debug, Formatter};
 use std::mem;
 use std::os::raw::c_void;

src/platform/windows/wgl/context.rs

@@ -663,10 +663,10 @@ fn extension_loader_thread() -> WGLExtensionFunctions {
         // a pointer to a null-terminated c string, or an `ATOM` / `u16` encoded
         // in the lower bytes of the pointer type. We do the latter by forcing an
         // `as` cast of the ATOM to the pointer type `LPCSTR`.
-        let lpClassName = window_class_atom as LPCSTR;
+        let lp_class_name = window_class_atom as LPCSTR;
         let window = winuser::CreateWindowExA(
             0,
-            lpClassName,
+            lp_class_name,
             window_class_name,
             WS_OVERLAPPEDWINDOW | WS_VISIBLE,
             0,

src/platform/windows/wgl/device.rs

@@ -299,7 +299,7 @@ impl HiddenWindow {
     }
 
     #[inline]
-    pub(crate) fn get_dc(&self) -> DCGuard {
+    pub(crate) fn get_dc(&self) -> DCGuard<'_> {
         unsafe { DCGuard::new(winuser::GetDC(self.window), Some(self.window)) }
     }