Fix resource leaks, save/copy path bugs, and tooltip/i18n gaps across simulators

Code fixes (with Crystallography/Crystallography.Controls submodule updates):
- Diffraction/Image simulators: consolidate the hand-rolled HDC->Metafile
  save/copy scaffolding into ClipboardMetafileHelper.SaveOrCopyDrawingAsEnhMetafile,
  dispose bitmaps/dialogs/streams, use persistent clipboard copies,
  case-insensitive extension handling, and hoist loop-invariant path
  computations in individual-save loops
- FormDiffractionSimulatorGeometry: centralize PseudoBitmap replacement
  (dispose + OverlappedImage invalidation) in SetPseudoBitmap; read IPA
  metadata via a single ImageIO.ReadImage pass; fail instead of reusing
  stale images on unreadable/real-space files; use pixSizeY in the
  detector pixel-size average; null-safe disposal in Designer Dispose
- FormDiffractionSimulatorCBED: remove a double Math.Acos on a value that
  is already an angle (AngleResolution)
- Version/ProgramUpdates: culture-invariant version parsing
- release.yml: refuse to publish when an orphan tag points at a different
  commit than the build

UI/i18n:
- Show dropdown menu-item tooltips (ShowItemToolTips) in FormMain,
  FormDiffractionSimulator, FormImageSimulator, FormStructureViewer
- FormTrajectory: add poleFigureControl tooltip in all 11 languages
- FormStructureViewer: move the save-image ToolTipText to the actual
  submenu item (saveImageToolStripMenuItem1) in all languages
- FormSpotIDV2: drop "(experimental)" from Global fit / Donut button
  labels (kept in tooltips); keep action buttons on one row
- FormDiffractionSimulatorCBED: expand the CBED abbreviation in the
  Simulate button tooltip (EN/JA)
- FormEBSD: English label for the PCHIP developer button
- FormPolycrystallineDiffractionSimulator: widen the Appearance group for
  long localized labels

Docs:
- CODE_SIGNING.md / THIRD-PARTY-NOTICES.md: describe the active signing
  scope (x64 MSI + x64 portable exe; Arm64 unsigned) as implemented

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>

Author: seto77

.github/workflows/release.yml

@@ -1,4 +1,4 @@
-# 260405Cl Version.cs の History 先頭行が変わったら自動でインストーラをビルド・リリースする
+# 260405Cl Version.cs の History 先頭行が変わったら自動でインストーラをビルド・リリースする
 # 260602Cl portable ZIP も同じリリースに添付。MSI を主配布のまま (管理 PC 向けの代替として self-contained ZIP を追加)
 # 260623Cl Phase 3 (ARM64化方針 §6 = 完全 inline 統合): 単一 job を 5 job (prepare/build-x64/build-arm64/smoke-arm64/release)
 #   に再編し、arm64 (ZIP+MSI) を同一 run でビルド・実機 smoke して x64 と一緒に 1 回の gh release create で原子的に公開する。
@@ -93,6 +93,25 @@ jobs:
             "needed=false" >> $env:GITHUB_OUTPUT
             return
           }
+
+          # 260715Ch: release が無いのに同名 tag だけ残っている場合、gh release create の --target は
+          #   既存 tag には効かない。別 commit の孤立 tag を黙って再利用すると、公開バイナリと source tag が
+          #   不一致になるため、先に tag の commit を検査する。同じ GITHUB_SHA なら安全な復旧として許可する。
+          if (-not $releaseExists) {
+            $checkRef = "refs/release-check/${tag}"
+            git fetch origin "refs/tags/${tag}:${checkRef}" --depth=1 2>$null
+            $tagExists = ($LASTEXITCODE -eq 0)
+            $global:LASTEXITCODE = 0
+            if ($tagExists) {
+              $tagSha = (git rev-parse "${checkRef}^{commit}").Trim()
+              if ($tagSha -ne $env:GITHUB_SHA) {
+                $message = "Tag $tag already exists at $tagSha, but this build is $($env:GITHUB_SHA). Refusing to publish mismatched artifacts."
+                if ($dryRun) { Write-Warning $message } else { throw $message }
+              } else {
+                Write-Host "Tag $tag already exists at this build commit; it is safe to create the missing release."
+              }
+            }
+          }
           # 旧 force 処理 (260530Cl 廃止):
           #   if ($releaseExists) {
           #     if ("(inputs.force)" -eq "true") {   # 260530Cl 旧コードでは inputs.force を式参照していた

CODE_SIGNING.md

@@ -1,10 +1,10 @@
-# Code signing policy
+# Code signing policy
 
 This document describes the code-signing policy for ReciPro release artifacts.
 
 ## Current status
 
-ReciPro has been accepted into the **SignPath Foundation** free code-signing program for open-source projects, and a production signing certificate was issued to the ReciPro SignPath organization on 2026-06-29. Since **v.4.942** (released 2026-07-01), release artifacts are signed as part of the automated release pipeline.
+ReciPro has been accepted into the **SignPath Foundation** free code-signing program for open-source projects, and a production signing certificate was issued to the ReciPro SignPath organization on 2026-06-29. Since **v.4.942** (released 2026-07-01), the x64 installer and the x64 portable executable are signed as part of the automated release pipeline. The experimental Arm64 assets remain unsigned. <!-- 260715Ch: match the active release.yml signing scope -->
 
 Releases up to v.4.941 predate code signing: unless a GitHub Release explicitly states that `ReciPro-setup.msi` (named `ReciProSetup.msi` up to v.4.939) is digitally signed, users should not assume that the installer is signed.
 
@@ -16,19 +16,20 @@ Official release artifacts are published only from the ReciPro GitHub Releases p
 
 Users should avoid downloading ReciPro installers from unofficial mirrors or third-party redistribution sites.
 
-## Intended signing model
+## Active signing model
 
 Free code signing on Windows provided by [SignPath.io](https://about.signpath.io), certificate by [SignPath Foundation](https://signpath.org).
 
-Once enabled for a given release, release artifacts are signed using Windows Authenticode signing before being published to GitHub Releases. For SignPath Foundation signing, the signer shown by Windows may be `SignPath Foundation` rather than the personal name of the ReciPro maintainer. Because SignPath Foundation signing requires a maintainer to manually approve each signing request, there may be a delay between a new version being pushed and the corresponding GitHub Release appearing, while the signing request awaits approval.
+The x64 installer package and the x64 portable `ReciPro.exe` are signed using Windows Authenticode before they are published to GitHub Releases. For SignPath Foundation signing, the signer shown by Windows may be `SignPath Foundation` rather than the personal name of the ReciPro maintainer. Because SignPath Foundation signing requires a maintainer to manually approve each signing request, there may be a delay between a new version being pushed and the corresponding GitHub Release appearing, while the signing request awaits approval. <!-- 260715Ch -->
 
 ## Scope of signing
 
-The intended signing scope is:
+The current signing scope is: <!-- 260715Ch: verified against release.yml and the v.4.943 artifacts -->
 
-- `ReciPro-setup.msi` and `ReciPro-setup_arm64.msi` (including the legacy-named copy `ReciProSetup.msi`, which is the identical x64 installer kept for auto-update compatibility with older versions)
-- ReciPro executable files built from this repository, including the single-file `ReciPro.exe` inside the portable ZIP packages (win-x64; the experimental win-arm64 package may remain unsigned until it graduates from experimental status)
-- ReciPro libraries built from this repository
+- `ReciPro-setup.msi` and its identical legacy-named copy `ReciProSetup.msi` (x64)
+- the single-file `ReciPro.exe` inside the x64 portable ZIP
+
+The framework-dependent `ReciPro.exe` and DLLs stored inside the signed MSI are not individually Authenticode-signed; their integrity is covered by the signed MSI container. The loose `Crystallography.Native*.dll` files in the x64 portable ZIP are also not individually signed. The experimental Arm64 MSI, portable executable, and native DLLs remain unsigned until Arm64 graduates into the production signing scope.
 
 Third-party binaries should not be re-signed as if they were maintained by ReciPro unless their provenance and redistribution terms explicitly permit that use. See `THIRD-PARTY-NOTICES.md` for bundled or referenced third-party components and data.
 

Crystallography

@@ -2859,65 +2859,57 @@ public void SaveOrCopy(bool save, bool isImage, bool drawOverlappedImage, string
     {
         if (isImage)
         {
-            var bmp = new Bitmap(graphicsBox.ClientSize.Width, graphicsBox.ClientSize.Height);
+            //var bmp = new Bitmap(graphicsBox.ClientSize.Width, graphicsBox.ClientSize.Height); // 旧: 保存・永続コピー後も Bitmap が未解放
+            using var bmp = new Bitmap(graphicsBox.ClientSize.Width, graphicsBox.ClientSize.Height); // (260715Ch)
             //var g = Graphics.FromImage(bmp); // (260611Ch) 旧: Graphics が未解放
             using (var g = Graphics.FromImage(bmp)) // (260611Ch) Bitmap は Clipboard に渡す場合があるため Graphics だけ先に解放
                 Draw(g, true, drawOverlappedImage);
-            if (bmp != null)
+            if (save)
             {
-                if (save)
+                if (filename == "")
                 {
-                    if (filename == "")
-                    {
-                        SaveFileDialog dlg = new() { Filter = "*.png|*.png" };
-                        if (dlg.ShowDialog() == DialogResult.OK)
-                            filename = dlg.FileName;
-                    }
+                    //SaveFileDialog dlg = new() { Filter = "*.png|*.png" }; // 旧: ダイアログが未解放
+                    using SaveFileDialog dlg = new() { Filter = "*.png|*.png" }; // (260715Ch)
+                    if (dlg.ShowDialog() != DialogResult.OK)
+                        return; // (260715Ch) キャンセル後に空ファイル名を処理しない
+                    filename = dlg.FileName;
+                }
 
-                    if (!filename.EndsWith(".png"))
-                        filename += ".png";
+                //if (!filename.EndsWith(".png")) // 旧: 大文字拡張子を重複付加
+                if (!filename.EndsWith(".png", StringComparison.OrdinalIgnoreCase)) // (260715Ch)
+                    filename += ".png";
 
-                    if (Path.Exists(Path.GetDirectoryName(filename)))
-                        bmp.Save(filename, ImageFormat.Png);
-                }
-                else
-                {
-                    Clipboard.SetDataObject(bmp);
-                }
+                //if (Path.Exists(Path.GetDirectoryName(filename))) // 旧: 相対ファイル名は DirectoryName が空になり保存されない
+                if (Directory.Exists(Path.GetDirectoryName(Path.GetFullPath(filename)))) // (260715Ch)
+                    bmp.Save(filename, ImageFormat.Png);
+            }
+            else
+            {
+                //Clipboard.SetDataObject(bmp); // 旧: Bitmap の寿命を Clipboard 任せにして未解放
+                Clipboard.SetDataObject(bmp, true); // (260715Ch) 永続コピー完了後に using で安全に解放
             }
         }
         else
         {
-            using Graphics grfx = CreateGraphics();
-            IntPtr ipHdc = grfx.GetHdc();
-            MemoryStream ms = new();
-            Metafile mf = new(ms, ipHdc, EmfType.EmfPlusDual);
-            grfx.ReleaseHdc(ipHdc);
-            grfx.Dispose();
-            //var g = Graphics.FromImage(mf); Draw(g, true, drawOverlappedImage); g.Dispose(); // (260611Ch) 旧: 手動 Dispose
-            using (var g = Graphics.FromImage(mf)) // (260611Ch)
-            {
-                Draw(g, true, drawOverlappedImage);
-            }
-
+            // 260716Cl 旧: using Graphics grfx = CreateGraphics(); using MemoryStream ms = new(); ipHdc = grfx.GetHdc();
+            //   try { mf = new Metafile(ms, ipHdc, EmfType.EmfPlusDual); } finally { grfx.ReleaseHdc(ipHdc); } using (mf) { Draw → 保存 or PutEnhMetafileOnClipboard }
+            //   と HDC→Metafile 定型を自前実装していた (260715Ch)。同型が 3 箇所に複製されていたため
+            //   ClipboardMetafileHelper.SaveOrCopyDrawingAsEnhMetafile へ集約し、ファイル名確定 (ダイアログ) を録画より先に行う (キャンセル時に無駄な録画をしない)。
             if (save)
             {
                 if (filename == "")
                 {
-                    SaveFileDialog dlg = new() { Filter = "*.emf|*.emf" };
-                    if (dlg.ShowDialog() == DialogResult.OK)
-                        filename = dlg.FileName;
+                    //SaveFileDialog dlg = new() { Filter = "*.emf|*.emf" }; // 旧: ダイアログが未解放、キャンセル後も空名で続行
+                    using SaveFileDialog dlg = new() { Filter = "*.emf|*.emf" }; // (260715Ch)
+                    if (dlg.ShowDialog() != DialogResult.OK)
+                        return; // (260715Ch)
+                    filename = dlg.FileName;
                 }
-                if (filename.EndsWith(".emf"))
+                //if (filename.EndsWith(".emf")) filename += ".emf"; // 旧: 正しい拡張子に .emf を重複付加
+                if (!filename.EndsWith(".emf", StringComparison.OrdinalIgnoreCase)) // (260715Ch)
                     filename += ".emf";
-
-                FileStream fsm = new(filename, FileMode.Create, FileAccess.Write);
-                fsm.Write(ms.GetBuffer(), 0, (int)ms.Length);
-                fsm.Close();
-
             }
-            else
-                ClipboardMetafileHelper.PutEnhMetafileOnClipboard(this.Handle, mf);
+            ClipboardMetafileHelper.SaveOrCopyDrawingAsEnhMetafile(this.Handle, g => Draw(g, true, drawOverlappedImage), save ? filename : ""); // 260716Cl
         }
     }
 

Crystallography.Controls

@@ -2870,8 +2870,9 @@ farther from the Ewald sphere more transparent.</value>
     <value>33</value>
   </data>
   <data name="numericBoxReciprocalThreshold.ToolTip" xml:space="preserve">
-    <value>逆格子点を表示する相対強度のしきい値(%)を設定し
-ます。これより弱いスポットは非表示になります。</value>
+    <value>Set the relative-intensity threshold (%) for displaying
+reciprocal-lattice points. Spots below this threshold
+are hidden.</value>
   </data>
   <data name="&gt;&gt;tableLayoutPanel1.Name" xml:space="preserve">
     <value>tableLayoutPanel1</value>
@@ -8602,4 +8603,4 @@ structure factor) used to draw Kikuchi lines.</value>
   <data name="sizeControl1.ToolTip" xml:space="preserve">
     <value>Set pixel sizes of the simulated pattern</value>
   </data>
-</root>
+</root>

ReciPro/DiffractionSimulator/FormDiffractionSimulator.Designer.cs

@@ -295,7 +295,8 @@ private void Bethe_CbedCompleted(object sender, RunWorkerCompletedEventArgs e)
     private void setImagePixelSize()
     {
         //以下の二つのパラメータはγ値の調整のところで使う。（あまり意味のないパラメータなので、廃止したい）
-        AngleResolution = Math.Acos(Vector3DBase.AngleBetVectors(Directions[Directions.Length / 2], Directions[Directions.Length / 2 + 1]) / 2);
+        //AngleResolution = Math.Acos(Vector3DBase.AngleBetVectors(Directions[Directions.Length / 2], Directions[Directions.Length / 2 + 1]) / 2);// (260715Ch) 旧: 既に radian の角度へ回転行列 trace 用 acos を二重適用していた
+        AngleResolution = Vector3DBase.AngleBetVectors(Directions[Directions.Length / 2], Directions[Directions.Length / 2 + 1]);// (260715Ch)
         ImagePixelSize = FormDiffractionSimulator.CameraLength2 * Math.Tan(AngleResolution);
     }
 

ReciPro/DiffractionSimulator/FormDiffractionSimulator.cs

@@ -112,7 +112,8 @@
     <value>開始</value>
   </data>
   <data name="buttonSimulate.ToolTip" xml:space="preserve">
-    <value>CBEDシミュレーションを実行</value>
+    <value>現在の設定で収束電子回折 (CBED) パターンを
+シミュレートします。</value>
   </data>
   <assembly alias="System.Drawing" name="System.Drawing, Version=4.0.0.0, Culture=neutral, PublicKeyToken=b03f5f7f11d50a3a" />
   <assembly alias="System.Windows.Forms" name="System.Windows.Forms, Version=4.0.0.0, Culture=neutral, PublicKeyToken=b77a5c561934e089" />

ReciPro/DiffractionSimulator/FormDiffractionSimulator.resx

@@ -149,7 +149,8 @@
     <value>272, 17</value>
   </metadata>
   <data name="buttonSimulate.ToolTip" xml:space="preserve">
-    <value>Execute a CBED simulation</value>
+    <value>Simulate a convergent-beam electron diffraction
+(CBED) pattern for the current settings.</value>
   </data>
   <data name="&gt;&gt;buttonSimulate.Name" xml:space="preserve">
     <value>buttonSimulate</value>
@@ -2062,4 +2063,4 @@ disk pattern currently displayed.</value>
   <data name="&gt;&gt;$this.Type" xml:space="preserve">
     <value>Crystallography.Controls.FormBase, Crystallography.Controls, Culture=neutral, PublicKeyToken=null</value>
   </data>
-</root>
+</root>