try using playwright from vitest

Author: severo

.github/workflows/ci.yml

@@ -27,12 +27,12 @@ jobs:
       - run: npm i
       - run: npm run typecheck
 
-  test-node:
-    runs-on: ubuntu-latest
-    steps:
-      - uses: actions/checkout@v4
-      - run: npm i
-      - run: npm run test:node
+  # test-node:
+  #   runs-on: ubuntu-latest
+  #   steps:
+  #     - uses: actions/checkout@v4
+  #     - run: npm i
+  #     - run: npm run test
 
   test-browsers:
     timeout-minutes: 60
@@ -46,11 +46,5 @@ jobs:
         run: npm ci
       - name: Install Playwright Browsers
         run: npx playwright install --with-deps
-      - name: Run Playwright tests
-        run: npx playwright test
-      - uses: actions/upload-artifact@v4
-        if: ${{ !cancelled() }}
-        with:
-          name: playwright-report
-          path: playwright-report/
-          retention-days: 30
+      - name: Run tests
+        run: npm test

package-lock.json

@@ -27,23 +27,21 @@
     "build": "tsdown",
     "dev": "tsdown --watch",
     "lint": "eslint .",
-    "test:node": "vitest run ./tests/node",
-    "test:browser": "playwright test",
-    "test": "npm run test:node && npm run test:browser",
+    "test": "vitest",
     "typecheck": "tsc --noEmit"
   },
   "devDependencies": {
     "@eslint/compat": "^1.4.0",
     "@eslint/js": "^9.38.0",
-    "@playwright/test": "^1.56.1",
     "@stylistic/eslint-plugin": "^5.5.0",
     "@types/node": "^24.9.1",
+    "@vitest/browser-playwright": "^4.0.7",
     "bumpp": "^10.3.1",
     "eslint": "^9.38.0",
     "globals": "^16.4.0",
     "tsdown": "^0.15.9",
     "typescript": "^5.9.3",
     "typescript-eslint": "^8.46.2",
-    "vitest": "^4.0.1"
+    "vitest": "^4.0.7"
   }
 }

package.json

@@ -1,66 +1,92 @@
 const defaultChunkSize = 1024 * 1024 // 1MB
 
+export function toUrl(text: string): {
+  url: string
+  fileSize: number
+  revoke: () => void
+} {
+  // add an extra space to fix https://github.com/nodejs/node/issues/60382
+  const blob = new Blob([text + ' '])
+  const url = URL.createObjectURL(blob)
+  return {
+    url,
+    fileSize: blob.size - 1, // subtract the extra space
+    revoke: () => {
+      URL.revokeObjectURL(url)
+    },
+  }
+}
+
 export async function* parse(
   url: string,
   options: {
     chunkSize?: number
-    isUrl?: boolean
+    fileSize?: number
   },
-) {
+): AsyncGenerator<string> {
   const chunkSize = options.chunkSize ?? defaultChunkSize
-  const isUrl = options.isUrl ?? true
-  // See https://github.com/nodejs/node/issues/60382
-  let objectURLWorkaround = false
-  if (!isUrl) {
-    // transform to a URL object
-    // See https://github.com/nodejs/node/issues/60382
-    objectURLWorkaround = true
-    url = URL.createObjectURL(new Blob([url + ' '], { type: 'text/plain' }))
-  }
-
+  let fileSize = options.fileSize
   const decoder = new TextDecoder('utf-8')
+
   let rangeStart = 0
-  let fileSize = Infinity
-  while (rangeStart < fileSize) {
-    const rangeEnd = rangeStart + chunkSize - 1 + (objectURLWorkaround ? 1 : 0)
-    const response = await fetch(url, {
-      headers: {
-        Range: `bytes=${rangeStart}-${rangeEnd}`,
-      },
-    })
-    if (response.status === 416) {
-      // Requested Range Not Satisfiable
-      throw new Error(
-        `Requested range not satisfiable: ${rangeStart}-${rangeEnd}`,
-      )
-    }
-    if (response.status === 200) {
-      // Server ignored Range header
-      throw new Error(`Server did not support range requests.`)
-    }
-    if (response.status !== 206) {
-      throw new Error(
-        `Failed to fetch chunk: ${response.status} ${response.statusText}`,
-      )
-    }
-    // Check the content-range header
-    const contentRange = response.headers.get('content-range')
-    const contentLength = response.headers.get('content-length')
-    if (!contentRange || !contentLength) {
-      throw new Error(`Missing content-range or content-length header.`)
-    }
-    const last = contentRange.split('/')[1]
-    if (last === undefined) {
-      throw new Error(`Invalid content-range header: ${contentRange}`)
-    }
-    fileSize = parseInt(last)
+  while (rangeStart < (fileSize ?? Number.POSITIVE_INFINITY)) {
+    // Always request one extra byte, due to https://github.com/nodejs/node/issues/60382
+    const extraByte = 1
+    const rangeEnd = rangeStart + chunkSize - 1 + extraByte
+
+    const result = await fetchChunk({ url, rangeStart, rangeEnd })
 
-    // Decode exactly chunkSize bytes or less if it's the last chunk
-    const bytes = await response.bytes()
+    fileSize ??= result.fileSize
     const bytesToDecode = Math.min(chunkSize, fileSize - rangeStart)
-    const chunk = decoder.decode(bytes.subarray(0, bytesToDecode))
+    const chunk = decoder.decode(result.bytes.subarray(0, bytesToDecode))
+
     yield chunk
 
     rangeStart += chunkSize
   }
 }
+
+async function fetchChunk({ url, rangeStart, rangeEnd }: { url: string, rangeStart: number, rangeEnd: number }): Promise<{
+  bytes: Uint8Array
+  fileSize: number
+}> {
+  const response = await fetch(url, {
+    headers: {
+      Range: `bytes=${rangeStart}-${rangeEnd}`,
+    },
+  })
+  if (response.status === 416) {
+    // Requested Range Not Satisfiable
+    throw new Error(
+      `Requested range not satisfiable: ${rangeStart}-${rangeEnd}`,
+    )
+  }
+  if (response.status === 200) {
+    // Server ignored Range header
+    throw new Error(`Server did not support range requests.`)
+  }
+  if (response.status !== 206) {
+    throw new Error(
+      `Failed to fetch chunk: ${response.status} ${response.statusText}`,
+    )
+  }
+  // Check the content-range header
+  const contentRange = response.headers.get('content-range')
+  const contentLength = response.headers.get('content-length')
+  if (!contentRange || !contentLength) {
+    throw new Error(`Missing content-range or content-length header.`)
+  }
+  const last = contentRange.split('/')[1]
+  if (last === undefined) {
+    throw new Error(`Invalid content-range header: ${contentRange}`)
+  }
+  const fileSize = parseInt(last)
+  if (isNaN(fileSize)) {
+    throw new Error(`Invalid file size in content-range header: ${last}`)
+  }
+
+  // Decode exactly chunkSize bytes or less if it's the last chunk
+  const bytes = await response.bytes()
+
+  return { bytes, fileSize }
+}

playwright.config.js

@@ -1,16 +1,15 @@
-import { parse } from '../../src'
+import { parse, toUrl } from '../../src'
+import { describe, expect, test } from 'vitest'
 
-export const tests = [
-  {
-    name: 'parse',
-    prepare: async () => {
-      const text = 'hello, csvremote!!!'
-      let result = ''
-      for await (const chunk of parse(text, { chunkSize: 5, isUrl: false })) {
-        result += chunk
-      }
-      return result
-    },
-    expected: 'hello, csvremote!!!',
-  },
-]
+describe('parse', () => {
+  test.each([1, 5, 10, 20])('parses text in chunks of size %d', async (chunkSize) => {
+    const text = 'hello, csvremote!!!'
+    const { url, fileSize, revoke } = toUrl(text)
+    let result = ''
+    for await (const chunk of parse(url, { chunkSize, fileSize })) {
+      result += chunk
+    }
+    revoke()
+    expect(result).toBe(text)
+  })
+})

src/index.ts

@@ -0,0 +1,19 @@
+import { defineConfig } from 'vitest/config'
+import { playwright } from '@vitest/browser-playwright'
+
+export default defineConfig({
+  test: {
+    browser: {
+      enabled: true,
+      provider: playwright(),
+      headless: true,
+      // https://vitest.dev/guide/browser/playwright
+      instances: [
+        { browser: 'chromium' },
+        { browser: 'firefox' },
+        // webkit is not working on my machine
+        // { browser: 'webkit' },
+      ],
+    },
+  },
+})