Commit 6945bd0
committed
Address CodeRabbit feedback on #2081
- Rename SolvePnPMethod.IPPE_SQUARE to IppeSquare: once an acronym is
glued to another word to form a compound member name, this repo's
enum-naming convention PascalCases the whole compound rather than
leaving part of it in caps (see .github/copilot-instructions.md).
- Use a positive-Z tvec in the new synthetic poses so the projected
points sit in front of the camera instead of behind it.
- Strengthen SolvePnPTestByArrayMethods/IppeSquare to reproject with
the recovered pose and assert it matches the input points, instead
of only asserting the call doesn't throw. Confirmed this actually
matters: with the old AP3P/IPPE values, SolvePnP silently dispatches
to a different native solver that still completes without throwing,
so a throws-only assertion doesn't catch it - the reprojection check
does.1 parent e44ae11 commit 6945bd0
2 files changed
Lines changed: 21 additions & 4 deletions
File tree
- src/OpenCvSharp/Modules/geometry/Enum
- test/OpenCvSharp.Tests/calib3d
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
50 | 50 | | |
51 | 51 | | |
52 | 52 | | |
53 | | - | |
| 53 | + | |
54 | 54 | | |
55 | 55 | | |
56 | 56 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
489 | 489 | | |
490 | 490 | | |
491 | 491 | | |
492 | | - | |
| 492 | + | |
493 | 493 | | |
494 | 494 | | |
495 | 495 | | |
| |||
509 | 509 | | |
510 | 510 | | |
511 | 511 | | |
| 512 | + | |
| 513 | + | |
| 514 | + | |
| 515 | + | |
| 516 | + | |
| 517 | + | |
| 518 | + | |
| 519 | + | |
| 520 | + | |
| 521 | + | |
512 | 522 | | |
513 | 523 | | |
514 | 524 | | |
515 | 525 | | |
516 | 526 | | |
517 | 527 | | |
518 | | - | |
| 528 | + | |
519 | 529 | | |
520 | 530 | | |
521 | 531 | | |
| |||
534 | 544 | | |
535 | 545 | | |
536 | 546 | | |
537 | | - | |
| 547 | + | |
| 548 | + | |
| 549 | + | |
| 550 | + | |
| 551 | + | |
| 552 | + | |
| 553 | + | |
| 554 | + | |
538 | 555 | | |
539 | 556 | | |
540 | 557 | | |
| |||
0 commit comments