fix(backup): add backup volume validator

ref: longhorn/longhorn 11154

Signed-off-by: James Lu <james.lu@suse.com>

Author: mantissahz

webhook/resources/backupvolume/validator.go

@@ -1,12 +1,17 @@
 package backupvolume
 
 import (
+	"fmt"
+
+	"k8s.io/apimachinery/pkg/runtime"
+
 	admissionregv1 "k8s.io/api/admissionregistration/v1"
 
 	"github.com/longhorn/longhorn-manager/datastore"
 	"github.com/longhorn/longhorn-manager/webhook/admission"
 
 	longhorn "github.com/longhorn/longhorn-manager/k8s/pkg/apis/longhorn/v1beta2"
+	werror "github.com/longhorn/longhorn-manager/webhook/error"
 )
 
 type backupVolumeValidator struct {
@@ -18,13 +23,48 @@ func NewValidator(ds *datastore.DataStore) admission.Validator {
 	return &backupVolumeValidator{ds: ds}
 }
 
-func (b *backupVolumeValidator) Resource() admission.Resource {
+func (bv *backupVolumeValidator) Resource() admission.Resource {
 	return admission.Resource{
-		Name:           "backupvolumes",
-		Scope:          admissionregv1.NamespacedScope,
-		APIGroup:       longhorn.SchemeGroupVersion.Group,
-		APIVersion:     longhorn.SchemeGroupVersion.Version,
-		ObjectType:     &longhorn.BackupVolume{},
-		OperationTypes: []admissionregv1.OperationType{},
+		Name:       "backupvolumes",
+		Scope:      admissionregv1.NamespacedScope,
+		APIGroup:   longhorn.SchemeGroupVersion.Group,
+		APIVersion: longhorn.SchemeGroupVersion.Version,
+		ObjectType: &longhorn.BackupVolume{},
+		OperationTypes: []admissionregv1.OperationType{
+			admissionregv1.Create,
+			admissionregv1.Update,
+		},
+	}
+}
+
+func (bv *backupVolumeValidator) Create(request *admission.Request, obj runtime.Object) error {
+	backupVolume := obj.(*longhorn.BackupVolume)
+
+	if err := validateRequiredFields(backupVolume); err != nil {
+		return werror.NewInvalidError(err.Error(), "")
+	}
+
+	return nil
+}
+
+func validateRequiredFields(backupVolume *longhorn.BackupVolume) error {
+	if backupVolume.Spec.BackupTargetName == "" {
+		return fmt.Errorf("backup target name cannot be empty")
+	}
+
+	if backupVolume.Spec.VolumeName == "" {
+		return fmt.Errorf("volume name cannot be empty")
 	}
+
+	return nil
+}
+
+func (bv *backupVolumeValidator) Update(request *admission.Request, oldObj runtime.Object, newObj runtime.Object) error {
+	newBackupVolume := newObj.(*longhorn.BackupVolume)
+
+	if err := validateRequiredFields(newBackupVolume); err != nil {
+		return werror.NewInvalidError(err.Error(), "")
+	}
+
+	return nil
 }

webhook/server/validation.go

@@ -13,6 +13,7 @@ import (
 	"github.com/longhorn/longhorn-manager/webhook/resources/backup"
 	"github.com/longhorn/longhorn-manager/webhook/resources/backupbackingimage"
 	"github.com/longhorn/longhorn-manager/webhook/resources/backuptarget"
+	"github.com/longhorn/longhorn-manager/webhook/resources/backupvolume"
 	"github.com/longhorn/longhorn-manager/webhook/resources/engine"
 	"github.com/longhorn/longhorn-manager/webhook/resources/engineimage"
 	"github.com/longhorn/longhorn-manager/webhook/resources/instancemanager"
@@ -44,6 +45,7 @@ func Validation(ds *datastore.DataStore) (http.Handler, []admission.Resource, er
 		backingimage.NewValidator(ds),
 		backupbackingimage.NewValidator(ds),
 		backup.NewValidator(ds),
+		backupvolume.NewValidator(ds),
 		backuptarget.NewValidator(ds),
 		volume.NewValidator(ds, currentNodeID),
 		orphan.NewValidator(ds),