fix: avoid cleaning up instance manager info before deleting engine

shuo-wu · shuo-wu · commit 47be8c3f84e5 · 2025-08-18T12:38:18.000-07:00
Signed-off-by: Shuo Wu &lt;shuo.wu@suse.com&gt;
diff --git a/controller/instance_handler.go b/controller/instance_handler.go
@@ -51,7 +51,7 @@ func NewInstanceHandler(ds *datastore.DataStore, instanceManagerHandler Instance
 
 func (h *InstanceHandler) syncStatusWithInstanceManager(log *logrus.Entry, im *longhorn.InstanceManager, instanceName string, spec *longhorn.InstanceSpec, status *longhorn.InstanceStatus, instances map[string]longhorn.InstanceProcess) {
 	defer func() {
-		if status.CurrentState == longhorn.InstanceStateStopped {
+		if status.CurrentState == longhorn.InstanceStateStopped && !status.Starting {
 			status.InstanceManagerName = ""
 		}
 	}()

Original file line number	Diff line number	Diff line change
`@@ -51,7 +51,7 @@ func NewInstanceHandler(ds *datastore.DataStore, instanceManagerHandler Instance`
`51`	`51`
`52`	`52`	`func (h InstanceHandler) syncStatusWithInstanceManager(log logrus.Entry, im longhorn.InstanceManager, instanceName string, spec longhorn.InstanceSpec, status *longhorn.InstanceStatus, instances map[string]longhorn.InstanceProcess) {`
`53`	`53`	`defer func() {`
`54`		`- if status.CurrentState == longhorn.InstanceStateStopped {`
	`54`	`+ if status.CurrentState == longhorn.InstanceStateStopped && !status.Starting {`
`55`	`55`	`status.InstanceManagerName = ""`
`56`	`56`	`}`
`57`	`57`	`}()`