Skip to content

Commit fbf303f

Browse files
mjerrisclaude
andcommitted
fix(hygiene): drop machine-path literals from the srcRelStem doc comment
ROOT-HYGIENE flagged the doc comment added in e58689b: it illustrated the checkout-location bug with a literal CI runner path, and the gate rejects an absolute machine path anywhere in a tracked file. [machine-path] scripts/enumerate-signatures.ts: absolute machine path at line 868 Rewrites the two worked examples as `<workspace>/…` and `<home>/src/…` placeholders. The contrast the comment is making — a parent directory named `src` capturing before the repo's own `src/` — is exactly as clear without naming a real machine, and ROOT-HYGIENE is clean rather than allowlisted. Comment-only: the enumerator's output is byte-identical (sha256 e28eadf6…), so port_signatures.json is untouched and SIGNATURES-FRESH stays green. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01TSHZoWoxoPVK6FuNaNKWFh
1 parent e58689b commit fbf303f

1 file changed

Lines changed: 9 additions & 5 deletions

File tree

scripts/enumerate-signatures.ts

Lines changed: 9 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -865,13 +865,17 @@ function camelToSnake(name: string): string {
865865
* ``class:signalwire.<modPath>.<Name>`` leaf built from it) then depended on
866866
* WHERE THE REPO HAPPENS TO BE CHECKED OUT:
867867
*
868-
* /home/runner/work/…/signalwire-typescript/src/rest/namespaces/x.types.generated.ts
869-
* → 'rest.namespaces.x.types.generated' (correct)
870-
* /Users/<dev>/src/signalwire-typescript/src/rest/namespaces/x.types.generated.ts
871-
* → 'signalwire-typescript.src.rest.namespaces.x.types.generated' (WRONG)
868+
* Checked out under a parent with NO ``src`` segment, the capture is the intended
869+
* repo-relative one:
870+
* <workspace>/signalwire-typescript/src/rest/namespaces/x.types.generated.ts
871+
* → 'rest.namespaces.x.types.generated' (correct)
872+
* Checked out under a parent directory that IS named ``src``, the earlier segment
873+
* wins and the repo directory leaks into the module path:
874+
* <home>/src/signalwire-typescript/src/rest/namespaces/x.types.generated.ts
875+
* → 'signalwire-typescript.src.rest.namespaces.x.types.generated' (WRONG)
872876
*
873877
* A developer whose workspace dir is literally named ``src`` (the documented
874-
* adjacency layout in porting-sdk/CLAUDE.md §7 is exactly ``~/src/``) produced a
878+
* adjacency layout in porting-sdk/CLAUDE.md §7 is exactly that) produced a
875879
* DIFFERENT port_signatures.json from CI on the very same commit — 602 differing
876880
* leaves, all of them this spurious ``<repo-dir>.src.`` prefix. The artifact is
877881
* DRIFT's input, so a location-dependent enumerator makes the whole parity claim

0 commit comments

Comments
 (0)