Add configurable exclusion of attestation files from model signatures#590
Open
ralphbean wants to merge 1 commit intosigstore:mainfrom
Open
Add configurable exclusion of attestation files from model signatures#590ralphbean wants to merge 1 commit intosigstore:mainfrom
ralphbean wants to merge 1 commit intosigstore:mainfrom
Conversation
ralphbean
force-pushed
the
exclude-attestations-from-signatures
branch
3 times, most recently
from
7da5c0a to
d7962a8
Compare
Attestation files (*.sig, *.sigstore.json, claims.jsonl) are now excluded from model signatures by default to allow attestations to accumulate throughout a model's lifecycle without invalidating the original signature. This behavior can be controlled via the new --ignore-att-paths CLI flag or the ignore_att_paths parameter in the hashing API, similar to how git-related files are handled with --ignore-git-paths. Fixes sigstore#586 Assisted-by: Claude Sonnet 4.5 <noreply@anthropic.com> Signed-off-by: Ralph Bean <rbean@redhat.com>
ralphbean
force-pushed
the
exclude-attestations-from-signatures
branch
from
d7962a8 to
05e04cc
Compare
Member
|
Can you fix the failing tests please? |
Member
mihaimaruseac
added
the
discusion pending
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds support for excluding attestation files (signature and attestation bundle files) from model signatures by default, addressing #586.
Changes
*.sig,*.sigstore.json,claims.jsonl) are now excluded from model signatures by default--ignore-att-paths/--no-ignore-att-pathsCLI flag to control this behaviorignore_att_pathsparameter in the hashing APIRationale
Per #586, attestation files should be signed independently to allow attestations to accumulate throughout a model's lifecycle without invalidating the original signature. This is especially important when using the
claims.jsonlpattern where attestations are appended over time.The exclusion is enabled by default but can be disabled for edge cases where users need different behavior.
Related: ossf/model-signing-spec#4