add throughput reporting, warmup, stats, and CSV export to exp_hash#626
Open
alekseevpavel04 wants to merge 1 commit intosigstore:mainfrom
Open
Conversation
Member
|
You need to do the DCO for the commit. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The hash benchmark only reported min time per run, making it hard to compare algorithms by actual throughput or spot variance across runs. Added throughput (MB/s) to the default output, a --stats flag for mean/stdev columns, a --warmup arg to discard cold-cache runs before timing, and --output to dump a CSV for further analysis.
All timing logic is now in _run_benchmark(), which also fixes a shadowing bug where the inner closure was named
hash, overriding the builtin. A _print_summary() table at the end shows peak throughput per algorithm across all sizes, which is the number most people actually care about.Run with --stats --output results.csv to get the full picture. Default behavior (just min time + throughput column) is backward compatible.
Checklist