The X-Forwarded-Protocol header is a very old non-standard header name. The modern equivalent is X-Forwarded-Proto.
We should find all references to the outdated header and at the very least update them to the modern equivalent.
This outdated header is at the very least referenced in HTTPCacheControlMiddleware as a default header to include in the Vary header.
Note that https://docs.silverstripe.org/en/6/developer_guides/performance/http_cache_headers/#vary details a way to change the Vary header which doesn't relate to the HTTPCacheControlMiddleware.defaultVary configuration, so this documentation should be reviewed as well.
Acceptance criteria
PRs
The
X-Forwarded-Protocolheader is a very old non-standard header name. The modern equivalent isX-Forwarded-Proto.We should find all references to the outdated header and at the very least update them to the modern equivalent.
This outdated header is at the very least referenced in
HTTPCacheControlMiddlewareas a default header to include in theVaryheader.Note that https://docs.silverstripe.org/en/6/developer_guides/performance/http_cache_headers/#vary details a way to change the
Varyheader which doesn't relate to theHTTPCacheControlMiddleware.defaultVaryconfiguration, so this documentation should be reviewed as well.Acceptance criteria
X-Forwarded-ProtocoltoX-Forwarded-Protoe.g. If it should not be in the
Varyheader by default, remove it from theHTTPCacheControlMiddleware.defaultVaryconfigurationX-Forwarded-Protocoland update it as appropriateVaryheader and update it as appropriatePRs