Deprecate Director::is_cli()?

[maxime-rainville]

Module version(s) affected

6.x-dev

Description

Minorish thing, but I just noticed that Director::is_cli() is basically just an alias for Environment::isCli(). I'm thinking it probably makes sense to deprecate Director::is_cli() and remove it in the next major release.

silverstripe-framework/src/Control/Director.php

Lines 1034 to 1042 in 9c59c42

	/**
	* Returns true if this script is being run from the command line rather than the web server.
	*
	* @return bool
	*/
	public static function is_cli()
	{
	return Environment::isCli();
	}

silverstripe-framework/src/Core/Environment.php

Lines 254 to 265 in 9c59c42

	/**
	* Returns true if this script is being run from the command line rather than the web server
	*
	* @return bool
	*/
	public static function isCli()
	{
	if (Environment::$isCliOverride !== null) {
	return Environment::$isCliOverride;
	}
	return in_array(strtolower(php_sapi_name() ?? ''), ['cli', 'phpdbg']);
	}

How to reproduce

Look at the code with your eyes.

Possible Solution

No response

Additional Context

No response

Validations

• Check that there isn't already an issue that reports the same bug
• Double check that your reproduction steps work in a fresh installation of silverstripe/installer (with any code examples you've provided)

Kitchen sink CI (green - all PRs below used in run of recipe-kitchen-sink)

• https://github.com/creative-commoners/recipe-kitchen-sink/actions/runs/31653536718

PRs

• ENH Use Environment::isCli() instead of Director::is_cli() #12005
• DOC Deprecate Director:is_cli() developer-docs#898
• ENH Use Environment::isCli() instead of Director::is_cli() silverstripe-environmentcheck#134
• ENH Use Environment::isCli() instead of Director::is_cli() silverstripe-frameworktest#269
• ENH Use Environment::isCli() instead of Director::is_cli() silverstripe-graphql#648
• ENH Use Environment::isCli() instead of Director::is_cli() silverstripe-linkfield#452
• ENH Use Environment::isCli() instead of Director::is_cli() silverstripe-realme#213
• ENH Use Environment::isCli() instead of Director::is_cli() silverstripe-testsession#103
• ENH Use Environment::isCli() instead of Director::is_cli() silverstripe-userforms#1449
• ENH Use Environment::isCli() instead of Director::is_cli() silverstripe-versioned#545
• ENH Use Environment::isCli() instead of Director::is_cli() silverstripe-queuedjobs#497