You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
All TinyMCE related code (JavaScript, PHP, YAML, localisations etc) from all supported modules is moved into a single new repository
Most (maybe all) localisations are not in transifex, though there may be some that are for plugins that need to be migrated, including in transifex itself - these must be copied not moved so as not to break CMS 5)
The default "cms" editor config is provided in the new module
TinyMCE plugins that rely on a specific module (e.g. "link to a page") are only applied if the corresponding module is installed
There is configuration to disable the "cms" editor config from being set (e.g. if someone has two editor modules installed, they can pick which one controls the "cms" editor config with a simple YML config variable)
When this module is installed, the behaviour is identical to the CMS 5 behaviour
This module is installed as part of silverstripe/installer by default for CMS 6 (not recipe-cms)
This module is not a dependency of any of our modules
If no WYSIWYG module is installed, DBHTMLText will auto-scaffold an HTMLEditorField rendered as a textarea tag
The changelog makes it very clear that this (or an alternative if it exists) must be included as a dependency by projects when upgrading from CMS 5 to CMS 6.
Note: Upon reviewing the behat tests in elemental, it's clear they are explicitly for testing WYSIWYG functionality within elemental blocks and cannot be moved elsewhere.
TinyMCE 7 changed its license to GPLv2+, which isn't compatible with our licenses, so we need to swap to a new editor.
Regardless of whether a new editor is available in CMS 6.0.0 or in a future minor release, we want to:
Notes
Acceptance Criteria
The below all apply for CMS 6 only
silverstripe/installerby default for CMS 6 (not recipe-cms)PRs
CMS 5
CMS 6
Important
Merge the above first and then reassign to Guy - the dist bundle in the tinymce module won't be buildable by CI until that's done
kitchen sink CI run with TinyMCE (The TinyMCE unit tests are in g2) Note this doesn't include fixes from silverstripe/.github#376. Compare with https://github.com/silverstripe/recipe-kitchen-sink/actions/runs/13821934870
kitchen sink CI run with all PRs except TinyMCE (subsites and elemental behat should both fail, as they have explicit tests that can only be satisfied by tinymce right now) I won't be updating this - it's just for an indication that these changes broadly don't cause problems when tinymce is omitted
Note: Upon reviewing the behat tests in elemental, it's clear they are explicitly for testing WYSIWYG functionality within elemental blocks and cannot be moved elsewhere.
silverstripe/htmleditor-tinymcedocumentation-lint#19