ENH Hide PHP font icons from screen readers

Author: ChloeSartorelli

code/Form/GridFieldAddClassesButton.php

@@ -188,7 +188,7 @@ public function getHTMLFragments($grid)
             $this->getAction(),
             array()
         );
-        $addAction->addExtraClass('font-icon-plus btn');
+        $addAction->addExtraClass('btn')->setIcon('plus');
 
         if ($this->getButtonClass()) {
             $addAction->addExtraClass($this->getButtonClass());

code/Model/Submission/SubmittedFileField.php

@@ -50,7 +50,7 @@ public function getFormattedValue(): ?DBField
                     $default = 'You don\'t have the right permissions to download this file';
                     $message = _t(__CLASS__ . '.INSUFFICIENTRIGHTS', $default);
                     return DBField::create_field('HTMLText', sprintf(
-                        '<i class="icon font-icon-lock"></i> %s - <em>%s</em>',
+                        '<span class="icon font-icon-lock" aria-hidden="true"></span> %s - <em>%s</em>',
                         htmlspecialchars($name, ENT_QUOTES),
                         htmlspecialchars($message, ENT_QUOTES)
                     ));

tests/php/Model/SubmittedFileFieldTest.php

@@ -97,7 +97,7 @@ public function testGetFormattedValue()
         $this->logInWithPermission('CMS_ACCESS_CMSMain');
         $this->assertEquals(
             sprintf(
-                '<i class="icon font-icon-lock"></i> %s - <em>%s</em>',
+                '<span class="icon font-icon-lock" aria-hidden="true"></span> %s - <em>%s</em>',
                 $fileName,
                 'You don&#039;t have the right permissions to download this file'
             ),