fix(plugins): repair test failures from widget migrations

Two independent regressions surfaced by the e2e suite:

**theme_editor: 31 tests failing to bundle.**
After commit 4f74b97 added `import { hintBar, parseHintString,
WidgetPanel } from "./lib/index.ts"` to theme_editor.ts, every
test that does `copy_plugin(&plugins_dir, "theme_editor")` without
also copying the lib subdir tries to bundle a plugin whose import
can't resolve, panicking with:
  Cannot resolve import './lib/index.ts' from .../config/plugins

git_log tests escape this because they go through
`setup_git_log_plugin()` which calls `copy_plugin_lib` first; pkg
tests don't import the plugin (no entry in tests/e2e/plugins/).
theme_editor's test file already imports `copy_plugin_lib` and
uses it in one place (line 2721) but the other 37 sites just call
`copy_plugin` directly.

Add `copy_plugin_lib(&plugins_dir);` immediately before each
`copy_plugin(&plugins_dir, "theme_editor");`.

**git_log: jk navigation broken on detail pane.**
After commit ffb413c migrated the log pane to a List widget, the
mode bindings rebound j/k from `move_down`/`move_up` (a generic
buffer-cursor action that worked uniformly on whichever panel had
focus) to `git_log_select_down`/`git_log_select_up`, which always
dispatched to the log List's command channel. This broke the
detail pane: pressing j there moved the LIST's selection, not
the detail buffer's cursor — so users couldn't scroll the diff
to find a `+` line and Enter on it to open the file view. The
test `test_git_log_file_view_jk_navigation` walks j down the
detail pane until a diff line opens; after the migration it
walked nowhere and timed out.

Guard the widget dispatch on whether the focused buffer is the
log buffer; fall back to `editor.executeAction("move_up" |
"move_down" | "page_up" | "page_down")` otherwise. Same for
PageUp/PageDown. New helper `isLogPanelActive()` checks
`editor.getActiveBufferId() === state.logBufferId`.

Verification:
- `cargo test -p fresh-editor --test e2e_tests theme_editor::`:
  34 passed, 0 failed, 6 ignored.
- `cargo test -p fresh-editor --test e2e_tests git::`:
  37 passed, 0 failed.
- `cargo test -p fresh-editor --lib widgets`: 136 passed.
- `tsc -p crates/fresh-editor/plugins/tsconfig.json`: clean.

The two test-failure roots had different shapes: theme_editor
was a *bundling* failure (the plugin file became unloadable in
test contexts that don't ship lib), git_log was a *behavioural*
regression (j/k stopped doing what users expected on the detail
pane). Both shipped in this branch; both fixed here.

https://claude.ai/code/session_014H6iXqpzBQXVCrfiS65512

Author: claude

crates/fresh-editor/plugins/git_log.ts

@@ -123,16 +123,45 @@ editor.defineMode(
 );
 
 function git_log_select_up(): void {
-  state.logPanel?.command(key("Up"));
+  if (isLogPanelActive()) {
+    state.logPanel?.command(key("Up"));
+  } else {
+    editor.executeAction("move_up");
+  }
 }
 function git_log_select_down(): void {
-  state.logPanel?.command(key("Down"));
+  if (isLogPanelActive()) {
+    state.logPanel?.command(key("Down"));
+  } else {
+    editor.executeAction("move_down");
+  }
 }
 function git_log_select_page_up(): void {
-  state.logPanel?.command(key("PageUp"));
+  if (isLogPanelActive()) {
+    state.logPanel?.command(key("PageUp"));
+  } else {
+    editor.executeAction("page_up");
+  }
 }
 function git_log_select_page_down(): void {
-  state.logPanel?.command(key("PageDown"));
+  if (isLogPanelActive()) {
+    state.logPanel?.command(key("PageDown"));
+  } else {
+    editor.executeAction("page_down");
+  }
+}
+
+/** True iff the log panel is the focused buffer in the group. The
+ * group's bindings (j/k/Up/Down/PageUp/PageDown) apply to all panels
+ * uniformly; we only want navigation to drive the List widget when
+ * the user is *on* the log panel. From the detail panel, the same
+ * keys must move the buffer cursor (so users can scroll the diff
+ * before pressing Enter on a diff line to open the file view). */
+function isLogPanelActive(): boolean {
+  return (
+    state.logBufferId !== null &&
+    editor.getActiveBufferId() === state.logBufferId
+  );
 }
 registerHandler("git_log_select_up", git_log_select_up);
 registerHandler("git_log_select_down", git_log_select_down);

crates/fresh-editor/tests/e2e/plugins/theme_editor.rs

@@ -84,6 +84,7 @@ fn test_theme_editor_command_registered() {
     let plugins_dir = project_root.join("plugins");
     fs::create_dir(&plugins_dir).unwrap();
 
+        copy_plugin_lib(&plugins_dir);
     copy_plugin(&plugins_dir, "theme_editor");
 
     // Create themes directory with a test theme
@@ -137,6 +138,7 @@ fn test_theme_editor_tab_bar_persists() {
     let plugins_dir = project_root.join("plugins");
     fs::create_dir(&plugins_dir).unwrap();
 
+        copy_plugin_lib(&plugins_dir);
     copy_plugin(&plugins_dir, "theme_editor");
 
     let mut harness =
@@ -216,6 +218,7 @@ fn test_close_buffer_while_in_group_closes_whole_group() {
 
     let plugins_dir = project_root.join("plugins");
     fs::create_dir(&plugins_dir).unwrap();
+        copy_plugin_lib(&plugins_dir);
     copy_plugin(&plugins_dir, "theme_editor");
 
     let mut harness =
@@ -292,6 +295,7 @@ fn test_next_buffer_cycles_across_groups_and_buffers() {
 
     let plugins_dir = project_root.join("plugins");
     fs::create_dir(&plugins_dir).unwrap();
+        copy_plugin_lib(&plugins_dir);
     copy_plugin(&plugins_dir, "theme_editor");
 
     let test_file = project_root.join("cycle_test.txt");
@@ -409,6 +413,7 @@ fn test_theme_editor_opens_without_error() {
     let plugins_dir = project_root.join("plugins");
     fs::create_dir(&plugins_dir).unwrap();
 
+        copy_plugin_lib(&plugins_dir);
     copy_plugin(&plugins_dir, "theme_editor");
 
     // Create themes directory with a test theme
@@ -490,6 +495,7 @@ fn test_theme_editor_open_close_reopen() {
     let plugins_dir = project_root.join("plugins");
     fs::create_dir(&plugins_dir).unwrap();
 
+        copy_plugin_lib(&plugins_dir);
     copy_plugin(&plugins_dir, "theme_editor");
 
     let mut harness =
@@ -559,6 +565,7 @@ fn test_theme_editor_reopen_after_close_buffer() {
     let plugins_dir = project_root.join("plugins");
     fs::create_dir(&plugins_dir).unwrap();
 
+        copy_plugin_lib(&plugins_dir);
     copy_plugin(&plugins_dir, "theme_editor");
 
     let mut harness =
@@ -623,6 +630,7 @@ fn test_theme_editor_shows_color_sections() {
     fs::create_dir(&plugins_dir).unwrap();
 
     // Copy the theme_editor.ts plugin
+        copy_plugin_lib(&plugins_dir);
     copy_plugin(&plugins_dir, "theme_editor");
 
     // Create themes directory with test themes
@@ -692,6 +700,7 @@ fn test_theme_editor_open_builtin() {
 
     let plugins_dir = project_root.join("plugins");
     fs::create_dir(&plugins_dir).unwrap();
+        copy_plugin_lib(&plugins_dir);
     copy_plugin(&plugins_dir, "theme_editor");
 
     // Create harness with isolated directory context
@@ -762,6 +771,7 @@ fn test_theme_editor_displays_correct_colors() {
     fs::create_dir(&plugins_dir).unwrap();
 
     // Copy the theme_editor.ts plugin
+        copy_plugin_lib(&plugins_dir);
     copy_plugin(&plugins_dir, "theme_editor");
 
     // Create themes directory
@@ -909,6 +919,7 @@ fn test_cursor_position_preserved_after_section_toggle() {
     let plugins_dir = project_root.join("plugins");
     fs::create_dir(&plugins_dir).unwrap();
 
+        copy_plugin_lib(&plugins_dir);
     copy_plugin(&plugins_dir, "theme_editor");
 
     let themes_dir = project_root.join("themes");
@@ -977,6 +988,7 @@ fn test_color_prompt_shows_suggestions() {
     let plugins_dir = project_root.join("plugins");
     fs::create_dir(&plugins_dir).unwrap();
 
+        copy_plugin_lib(&plugins_dir);
     copy_plugin(&plugins_dir, "theme_editor");
 
     let themes_dir = project_root.join("themes");
@@ -1082,6 +1094,7 @@ fn test_colors_displayed_in_hex_format() {
     let plugins_dir = project_root.join("plugins");
     fs::create_dir(&plugins_dir).unwrap();
 
+        copy_plugin_lib(&plugins_dir);
     copy_plugin(&plugins_dir, "theme_editor");
 
     let themes_dir = project_root.join("themes");
@@ -1145,6 +1158,7 @@ fn test_comments_appear_before_fields() {
     let plugins_dir = project_root.join("plugins");
     fs::create_dir(&plugins_dir).unwrap();
 
+        copy_plugin_lib(&plugins_dir);
     copy_plugin(&plugins_dir, "theme_editor");
 
     let themes_dir = project_root.join("themes");
@@ -1226,6 +1240,7 @@ fn test_theme_applied_immediately_after_save() {
 
     let plugins_dir = project_root.join("plugins");
     fs::create_dir(&plugins_dir).unwrap();
+        copy_plugin_lib(&plugins_dir);
     copy_plugin(&plugins_dir, "theme_editor");
 
     // Create a test file to see theme changes
@@ -1398,6 +1413,7 @@ fn test_cursor_x_position_preserved_after_section_toggle() {
     let plugins_dir = project_root.join("plugins");
     fs::create_dir(&plugins_dir).unwrap();
 
+        copy_plugin_lib(&plugins_dir);
     copy_plugin(&plugins_dir, "theme_editor");
 
     let themes_dir = project_root.join("themes");
@@ -1534,6 +1550,7 @@ fn test_color_suggestions_show_hex_format() {
     let plugins_dir = project_root.join("plugins");
     fs::create_dir(&plugins_dir).unwrap();
 
+        copy_plugin_lib(&plugins_dir);
     copy_plugin(&plugins_dir, "theme_editor");
 
     let themes_dir = project_root.join("themes");
@@ -1665,6 +1682,7 @@ fn test_color_prompt_prefilled_with_current_value() {
     let plugins_dir = project_root.join("plugins");
     fs::create_dir(&plugins_dir).unwrap();
 
+        copy_plugin_lib(&plugins_dir);
     copy_plugin(&plugins_dir, "theme_editor");
 
     let themes_dir = project_root.join("themes");
@@ -1744,6 +1762,7 @@ fn test_theme_editor_color_values_no_internal_spaces() {
     let plugins_dir = project_root.join("plugins");
     fs::create_dir(&plugins_dir).unwrap();
 
+        copy_plugin_lib(&plugins_dir);
     copy_plugin(&plugins_dir, "theme_editor");
 
     let themes_dir = project_root.join("themes");
@@ -1832,6 +1851,7 @@ fn test_theme_editor_navigation_skips_non_selectable_lines() {
     let plugins_dir = project_root.join("plugins");
     fs::create_dir(&plugins_dir).unwrap();
 
+        copy_plugin_lib(&plugins_dir);
     copy_plugin(&plugins_dir, "theme_editor");
 
     let themes_dir = project_root.join("themes");
@@ -1986,6 +2006,7 @@ fn test_cursor_position_preserved_after_color_edit() {
     let plugins_dir = project_root.join("plugins");
     fs::create_dir(&plugins_dir).unwrap();
 
+        copy_plugin_lib(&plugins_dir);
     copy_plugin(&plugins_dir, "theme_editor");
 
     let themes_dir = project_root.join("themes");
@@ -2116,6 +2137,7 @@ fn test_cursor_on_value_field_when_navigating() {
     let plugins_dir = project_root.join("plugins");
     fs::create_dir(&plugins_dir).unwrap();
 
+        copy_plugin_lib(&plugins_dir);
     copy_plugin(&plugins_dir, "theme_editor");
 
     let themes_dir = project_root.join("themes");
@@ -2182,6 +2204,7 @@ fn test_builtin_theme_requires_save_as() {
     let plugins_dir = project_root.join("plugins");
     fs::create_dir(&plugins_dir).unwrap();
 
+        copy_plugin_lib(&plugins_dir);
     copy_plugin(&plugins_dir, "theme_editor");
 
     // Create a DirectoryContext so we know where config_dir/themes is
@@ -2303,6 +2326,7 @@ fn test_color_swatches_displayed() {
     let plugins_dir = project_root.join("plugins");
     fs::create_dir(&plugins_dir).unwrap();
 
+        copy_plugin_lib(&plugins_dir);
     copy_plugin(&plugins_dir, "theme_editor");
 
     let themes_dir = project_root.join("themes");
@@ -2360,6 +2384,7 @@ fn test_theme_editor_nostalgia_builtin_shows_correct_colors() {
     let plugins_dir = project_root.join("plugins");
     fs::create_dir(&plugins_dir).unwrap();
 
+        copy_plugin_lib(&plugins_dir);
     copy_plugin(&plugins_dir, "theme_editor");
 
     // Don't create a themes directory - we want to use the built-in themes only
@@ -2445,6 +2470,7 @@ fn test_theme_editor_nostalgia_builtin_via_arrow_selection() {
     let plugins_dir = project_root.join("plugins");
     fs::create_dir(&plugins_dir).unwrap();
 
+        copy_plugin_lib(&plugins_dir);
     copy_plugin(&plugins_dir, "theme_editor");
 
     // Don't create a themes directory - we want to use the built-in themes only
@@ -2540,6 +2566,7 @@ fn test_theme_editor_select_nostalgia_from_dropdown() {
     let plugins_dir = project_root.join("plugins");
     fs::create_dir(&plugins_dir).unwrap();
 
+        copy_plugin_lib(&plugins_dir);
     copy_plugin(&plugins_dir, "theme_editor");
 
     let mut harness =
@@ -2782,6 +2809,7 @@ fn test_inspect_theme_at_cursor_opens_theme_editor() {
 
     let plugins_dir = project_root.join("plugins");
     fs::create_dir(&plugins_dir).unwrap();
+        copy_plugin_lib(&plugins_dir);
     copy_plugin(&plugins_dir, "theme_editor");
 
     // Create a test file so the cursor is on editor content
@@ -2847,6 +2875,7 @@ fn test_inspect_theme_at_cursor_multiple_rounds() {
 
     let plugins_dir = project_root.join("plugins");
     fs::create_dir(&plugins_dir).unwrap();
+        copy_plugin_lib(&plugins_dir);
     copy_plugin(&plugins_dir, "theme_editor");
 
     let test_file = project_root.join("test.txt");
@@ -2976,6 +3005,7 @@ fn test_save_builtin_theme_produces_valid_file() {
 
     let plugins_dir = project_root.join("plugins");
     fs::create_dir(&plugins_dir).unwrap();
+        copy_plugin_lib(&plugins_dir);
     copy_plugin(&plugins_dir, "theme_editor");
 
     let test_file = project_root.join("test.txt");
@@ -3166,6 +3196,7 @@ fn test_issue_1180_save_theme_creates_themes_directory() {
 
     let plugins_dir = project_root.join("plugins");
     fs::create_dir(&plugins_dir).unwrap();
+        copy_plugin_lib(&plugins_dir);
     copy_plugin(&plugins_dir, "theme_editor");
 
     let test_file = project_root.join("test.txt");
@@ -3332,6 +3363,7 @@ fn test_inspect_after_saving_custom_theme() {
 
     let plugins_dir = project_root.join("plugins");
     fs::create_dir(&plugins_dir).unwrap();
+        copy_plugin_lib(&plugins_dir);
     copy_plugin(&plugins_dir, "theme_editor");
 
     let test_file = project_root.join("test.txt");
@@ -3512,6 +3544,7 @@ fn test_palette_swatch_click_targets_correct_column() {
     let plugins_dir = project_root.join("plugins");
     fs::create_dir(&plugins_dir).unwrap();
 
+        copy_plugin_lib(&plugins_dir);
     copy_plugin(&plugins_dir, "theme_editor");
 
     let themes_dir = project_root.join("themes");
@@ -3697,6 +3730,7 @@ fn test_theme_editor_page_up_page_down() {
     let plugins_dir = project_root.join("plugins");
     fs::create_dir(&plugins_dir).unwrap();
 
+        copy_plugin_lib(&plugins_dir);
     copy_plugin(&plugins_dir, "theme_editor");
 
     let themes_dir = project_root.join("themes");
@@ -3836,6 +3870,7 @@ fn test_named_color_swatch_uses_native_ansi_color() {
 
     let plugins_dir = project_root.join("plugins");
     fs::create_dir(&plugins_dir).unwrap();
+        copy_plugin_lib(&plugins_dir);
     copy_plugin(&plugins_dir, "theme_editor");
 
     // Create a theme with a named color "Yellow" for tab_active_fg.
@@ -4007,6 +4042,7 @@ fn test_theme_editor_colors_update_on_theme_change() {
 
     let plugins_dir = project_root.join("plugins");
     fs::create_dir(&plugins_dir).unwrap();
+        copy_plugin_lib(&plugins_dir);
     copy_plugin(&plugins_dir, "theme_editor");
 
     let mut config = fresh::config::Config::default();
@@ -4155,6 +4191,7 @@ fn test_paste_in_theme_editor_does_not_panic() {
 
     let plugins_dir = project_root.join("plugins");
     fs::create_dir(&plugins_dir).unwrap();
+        copy_plugin_lib(&plugins_dir);
     copy_plugin(&plugins_dir, "theme_editor");
 
     let mut harness =
@@ -4207,6 +4244,7 @@ fn test_theme_editor_terminal_builtin_renders_field_rows() {
 
     let plugins_dir = project_root.join("plugins");
     fs::create_dir(&plugins_dir).unwrap();
+        copy_plugin_lib(&plugins_dir);
     copy_plugin(&plugins_dir, "theme_editor");
 
     let mut harness =