fix: streamline testing commands and improve code readability

Author: sirkirby

Makefile

@@ -66,15 +66,15 @@ fix: lint-fix format
 
 # Testing
 test:
-	$(PYTEST)
+	$(PYTEST) tests/
 
 test-cov:
-	$(PYTEST) --cov=custom_components/unifi_network_rules --cov-report=term-missing --cov-report=html
+	$(PYTEST) tests/ --cov=custom_components/unifi_network_rules --cov-report=term-missing --cov-report=html
 	@echo ""
 	@echo "Coverage report generated: htmlcov/index.html"
 
 test-watch:
-	$(PYTEST) --watch
+	$(PYTEST) tests/ --watch
 
 # Combined checks (mirrors CI)
 check: lint test

custom_components/unifi_network_rules/coordination/auth_manager.py

@@ -45,8 +45,11 @@ def __init__(self, hass: HomeAssistant, api: UDMAPI) -> None:
         self._ha_initiated_operations: dict[str, float] = {}
 
     def register_ha_initiated_operation(
-        self, rule_id: str, entity_id: str, change_type: str = "modified",
-        timeout: int = HA_INITIATED_OPERATION_TIMEOUT_SECONDS
+        self,
+        rule_id: str,
+        entity_id: str,
+        change_type: str = "modified",
+        timeout: int = HA_INITIATED_OPERATION_TIMEOUT_SECONDS,
     ) -> None:
         """Register that a rule change was initiated from HA.
 

custom_components/unifi_network_rules/coordination/coordinator.py

@@ -137,8 +137,11 @@ def __init__(
 
     # Backward compatibility methods - delegate to auth manager
     def register_ha_initiated_operation(
-        self, rule_id: str, entity_id: str, change_type: str = "modified",
-        timeout: int = HA_INITIATED_OPERATION_TIMEOUT_SECONDS
+        self,
+        rule_id: str,
+        entity_id: str,
+        change_type: str = "modified",
+        timeout: int = HA_INITIATED_OPERATION_TIMEOUT_SECONDS,
     ) -> None:
         """Register that a rule change was initiated from HA."""
         self.auth_manager.register_ha_initiated_operation(rule_id, entity_id, change_type, timeout)

custom_components/unifi_network_rules/manifest.json

@@ -15,5 +15,5 @@
         "aiounifi>=87.0.0",
         "orjson>=3.8.0"
     ],
-    "version": "4.3.0"
+    "version": "4.4.0"
 }

custom_components/unifi_network_rules/switches/base.py

@@ -17,7 +17,6 @@
 
 from ..const import DOMAIN, MANUFACTURER, SWITCH_DELAYED_VERIFICATION_SLEEP_SECONDS
 from ..coordinator import UnifiRuleUpdateCoordinator
-
 from ..helpers.rule import (
     get_object_id,
     get_rule_enabled,
@@ -547,9 +546,7 @@ async def handle_operation_complete(future):
                     # if the change was confirmed by the trigger system (which consumes the
                     # HA-initiated operation flag). If not, it forces a refresh.
                     async def delayed_verification():
-                        await asyncio.sleep(
-                            SWITCH_DELAYED_VERIFICATION_SLEEP_SECONDS
-                        )  # Wait for smart polling update
+                        await asyncio.sleep(SWITCH_DELAYED_VERIFICATION_SLEEP_SECONDS)  # Wait for smart polling update
                         if self.coordinator.check_and_consume_ha_initiated_operation(self._rule_id):
                             # If the flag was still present, it means the trigger system
                             # did NOT get a change event. We must refresh.
@@ -655,7 +652,9 @@ async def led_toggle_wrapper(device, state):
             # Add the completion callback
             future.add_done_callback(lambda f: self.hass.async_create_task(handle_operation_complete(f)))
 
-            LOGGER.debug("Successfully queued toggle operation for rule %s with target state: %s", self._rule_id, enable)
+            LOGGER.debug(
+                "Successfully queued toggle operation for rule %s with target state: %s", self._rule_id, enable
+            )
         except Exception as err:
             LOGGER.error("Failed to queue toggle operation for rule %s: %s", self._rule_id, err)
             # Remove from pending operations if queueing failed

tests/test_api.py

@@ -11,9 +11,7 @@
 @pytest.fixture
 def api() -> UDMAPI:
     """Return a UDMAPI instance with mocked controller and queue."""
-    with patch(
-        "custom_components.unifi_network_rules.udm.api.ApiOperationQueue"
-    ) as mock_queue_class:
+    with patch("custom_components.unifi_network_rules.udm.api.ApiOperationQueue") as mock_queue_class:
         # Create a mock queue that doesn't start background tasks
         mock_queue = AsyncMock()
         mock_queue.stop = AsyncMock()