Skip to content

Commit 81fc73f

Browse files
committed
Add PRD for comprehensive NAT rules support in UniFi Network integration
1 parent 34eaa2c commit 81fc73f

3 files changed

Lines changed: 540 additions & 56 deletions

File tree

.github/prompts/general.prompt.md

Lines changed: 5 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -2,13 +2,14 @@
22

33
- Always keep the code DRY for testability and separation of concerns
44
- Prefer modern idiomatic Python 3.13 and open source conventions, Leverage type hints, use CONST over hard coded strings
5-
- Prioritize native Home Assistant libraries, like aiounifi, and other core capabilities to respect available resources and to avoid building duplicate fuctionality. Leverage the latest Home Assistant documentation.
5+
- Prioritize native Home Assistant libraries, like aiounifi, and other core capabilities to respect available resources and to avoid building duplicate functionality. Leverage the latest Home Assistant documentation.
66
- Diagnostics enabled for observability and debugging should be targeted, respecting the resources of the system
7-
- All data retrived and stored from the API should be typed, if not supplied by aiounifi, then a custom type should be created
7+
- All data retrieved and stored from the API should be typed, if not supplied by aiounifi, then a custom type should be created
88
- When designing a new feature, prefer elegant solutions using established best practices and patterns.
9-
- When fixing a problem or bug, avoid treating the symptop, look for the root cause.
10-
- Details matter, ensure to always preserve existing functionlity unless otherwise instructed.
9+
- When fixing a problem or bug, avoid treating the symptom, look for the root cause.
10+
- Details matter, ensure to always preserve existing functionality unless otherwise instructed.
1111
- KISS
12+
- Maintain consistent code hygiene by addressing code and markdown linting errors and warnings.
1213

1314
## Notes
1415

cspell.json

Lines changed: 53 additions & 52 deletions
Original file line numberDiff line numberDiff line change
@@ -1,58 +1,59 @@
11
{
2-
"version": "0.2",
2+
"version": "0.2",
33
"language": "en",
44
"ignorePaths": [
5-
"**/translations/*.json"
5+
"**/translations/*.json"
66
],
77
"words": [
8-
"homeassistant",
9-
"hass",
10-
"UDMAPI",
11-
"unifi",
12-
"aiounifi",
13-
"clientsession",
14-
"wlans",
15-
"Wlans",
16-
"WLAN",
17-
"wlan",
18-
"Wlan",
19-
"Ubiquiti",
20-
"unsub",
21-
"trafficroutes",
22-
"trafficrules",
23-
"firewallrule",
24-
"wlanconf",
25-
"portforward",
26-
"networkconf",
27-
"portconf",
28-
"wlanrate",
29-
"radiusprofile",
30-
"wansla",
31-
"firewallgroup",
32-
"networkconfs",
33-
"mgmt",
34-
"keepalive",
35-
"retryable",
36-
"cooldown",
37-
"Cooldown",
38-
"gmtime",
39-
"traefik",
40-
"networkgroup",
41-
"Aiounifi",
42-
"automations",
43-
"hacs",
44-
"HACS",
45-
"Mjolnir",
46-
"asyncio",
47-
"codeowners",
48-
"sirkirby",
49-
"aiohttp",
50-
"orjson",
51-
"aabbccddeeff",
52-
"elif",
53-
"chrisiphone",
54-
"venv",
55-
"pytest",
56-
"toggleable"
8+
"aabbccddeeff",
9+
"aiohttp",
10+
"aiounifi",
11+
"Aiounifi",
12+
"asyncio",
13+
"automations",
14+
"chrisiphone",
15+
"clientsession",
16+
"codeowners",
17+
"cooldown",
18+
"Cooldown",
19+
"elif",
20+
"firewallgroup",
21+
"firewallrule",
22+
"gmtime",
23+
"hacs",
24+
"HACS",
25+
"hass",
26+
"homeassistant",
27+
"homelab",
28+
"keepalive",
29+
"mgmt",
30+
"Mjolnir",
31+
"networkconf",
32+
"networkconfs",
33+
"networkgroup",
34+
"orjson",
35+
"portconf",
36+
"portforward",
37+
"pytest",
38+
"radiusprofile",
39+
"retryable",
40+
"sirkirby",
41+
"toggleable",
42+
"traefik",
43+
"trafficroutes",
44+
"trafficrules",
45+
"Ubiquiti",
46+
"UDMAPI",
47+
"unifi",
48+
"unsub",
49+
"venv",
50+
"wansla",
51+
"wlan",
52+
"Wlan",
53+
"WLAN",
54+
"wlanconf",
55+
"wlanrate",
56+
"wlans",
57+
"Wlans"
5758
]
58-
}
59+
}

0 commit comments

Comments
 (0)