Add mock for testing

Author: sirn-se

src/Message/OpcodeRegistry.php

@@ -19,7 +19,7 @@
 class OpcodeRegistry
 {
     /** @var array<int<1, 15>, class-string> $map */
-    private array $map = [
+    protected array $map = [
         1 => Text::class,
         2 => Binary::class,
         8 => Close::class,
@@ -65,7 +65,15 @@ public function createMessage(int $opcode): Message
                 $opcode
             ));
         }
-        return new $classname();
+        $class = new $classname();
+        if (!$class instanceof Message) {
+            throw new BadOpcodeException(sprintf(
+                'Implementation class %s must extend %s',
+                $class::class,
+                Message::class,
+            ));
+        }
+        return $class;
     }
 
     /**

tests/mock/MockOpcodeRegistry.php

@@ -0,0 +1,22 @@
+<?php
+
+/**
+ * Copyright (C) 2014-2026 Textalk and contributors.
+ * This file is part of Websocket PHP and is free software under the ISC License.
+ */
+
+namespace WebSocket\Test;
+
+use WebSocket\Message\OpcodeRegistry;
+
+/**
+ * This class adds invalid opcode/class mappings for testing
+ */
+class MockOpcodeRegistry extends OpcodeRegistry
+{
+    public function mockBind(int $opcode, string $classname): void
+    {
+        // @phpstan-ignore assign.propertyType
+        $this->map[$opcode] = $classname;
+    }
+}

tests/suites/message/OpcodeRegistryTest.php

@@ -10,20 +10,9 @@
 namespace WebSocket\Test\Message;
 
 use DomainException;
-use InvalidArgumentException;
 use PHPUnit\Framework\TestCase;
-use Phrity\Net\Mock\SocketStream;
-use Phrity\Net\Mock\Stack\{
-    ExpectContextTrait,
-    ExpectSocketStreamTrait,
-};
 use RangeException;
-use Stringable;
 use WebSocket\Exception\BadOpcodeException;
-use WebSocket\Frame\{
-    Frame,
-    FrameHandler
-};
 use WebSocket\Message\{
     Message,
     Binary,
@@ -32,8 +21,8 @@
     Ping,
     Pong,
     Text,
-    MessageHandler
 };
+use WebSocket\Test\MockOpcodeRegistry;
 
 /**
  * Test case for WebSocket\Message\OpcodeRegistry.
@@ -105,4 +94,24 @@ public function testCreateMessageInvalidOpcode(): void
         // @phpstan-ignore argument.type
         $opcodeRegistry->createMessage(16);
     }
+
+    public function testCreateMessageUnexistingClass(): void
+    {
+        $opcodeRegistry = new MockOpcodeRegistry();
+        $opcodeRegistry->mockBind(1, 'UnexistingClass');
+        $this->expectException(BadOpcodeException::class);
+        $this->expectExceptionMessage('Implementation class "UnexistingClass" for opcode 1 not found');
+        $opcodeRegistry->createMessage(1);
+    }
+
+    public function testCreateMessageInvalidClass(): void
+    {
+        $opcodeRegistry = new MockOpcodeRegistry();
+        $opcodeRegistry->mockBind(2, $opcodeRegistry::class);
+        $this->expectException(BadOpcodeException::class);
+        $this->expectExceptionMessage(
+            'Implementation class WebSocket\Test\MockOpcodeRegistry must extend WebSocket\Message\Message'
+        );
+        $opcodeRegistry->createMessage(2);
+    }
 }