Reproduction base for vaadin/flow-components PR vaadin#9612

Author: sissbruecker

.claude/commands/pr-review.md

@@ -30,7 +30,6 @@ node_modules
 !/package.json
 !/package-lock.json
 pnpm*
-!**/pnpm-workspace.yaml
 .npmrc
 .pnpmfile.cjs
 error-screenshots

.gitignore

@@ -9,7 +9,7 @@ annotations, implements the mixin interfaces it needs, and delegates state to
 
 ```java
 @Tag("vaadin-example")
-@NpmPackage(value = "@vaadin/example", version = "25.3.0-alpha1")
+@NpmPackage(value = "@vaadin/example", version = "25.2.0-alpha7")
 @JsModule("@vaadin/example/src/vaadin-example.js")
 public class Example extends Component
         implements HasEnabled, HasSize, HasStyle, HasThemeVariant<ExampleVariant> {

guidelines/03-component-structure.md

@@ -86,8 +86,8 @@
         <maven.surefire.plugin.version>3.5.6</maven.surefire.plugin.version>
         <maven.failsafe.plugin.version>3.5.6</maven.failsafe.plugin.version>
         <maven.resources.plugin.version>3.5.0</maven.resources.plugin.version>
-        <spotless.plugin.version>3.8.0</spotless.plugin.version>
-        <checkstyle.version>13.7.0</checkstyle.version>
+        <spotless.plugin.version>3.7.0</spotless.plugin.version>
+        <checkstyle.version>13.6.0</checkstyle.version>
         <maven.checkstyle.plugin.version>3.6.0</maven.checkstyle.plugin.version>
         <spotless.licence-header>${maven.multiModuleProjectDirectory}/scripts/templates/apache2-license-header.txt</spotless.licence-header>
         <spotless.npmExecutable/>
@@ -104,10 +104,10 @@
         <jakarta.web.api.version>11.0.0</jakarta.web.api.version>
         <spring-data-commons.version>4.1.0</spring-data-commons.version>
         <reactor-core.version>3.8.6</reactor-core.version>
-        <langchain4j.version>1.17.1</langchain4j.version>
+        <langchain4j.version>1.16.3</langchain4j.version>
         <spring-ai.version>2.0.0</spring-ai.version>
         <junit.version>4.13.2</junit.version>
-        <junit.jupiter.version>6.1.1</junit.jupiter.version>
+        <junit.jupiter.version>6.1.0</junit.jupiter.version>
 
         <!-- spreadsheet -->
         <poi.version>5.5.1</poi.version>

pom.xml

@@ -223,9 +223,6 @@ async function copySources() {
     copyFolderRecursiveSync(`${parent}/${id}-integration-tests/frontend`, `${itFolder}`);
     // copy java sources
     copyFolderRecursiveSync(`${parent}/${id}-integration-tests/src`, `${itFolder}`);
-    // copy pnpm-workspace.yaml so @vaadin/* web component bumps bypass the
-    // frontend package age check (all modules ship an identical copy)
-    copyFileSync(`${parent}/${id}-integration-tests/pnpm-workspace.yaml`, `${itFolder}`);
   });
 
   // Always copy LumoAppShell, so that merged ITs run with Lumo theme applied. Some ITs do not work property with

scripts/mergeITs.js

@@ -79,6 +79,14 @@ async function runTests() {
         fs.writeFileSync(packageJson, '{}');
       }
 
+      // Build the frontend with pnpm and let @vaadin/* web component bumps
+      // bypass the frontend package age check. Avoids failures when running
+      // checks for just-released @vaadin packages.
+      fs.writeFileSync(
+        `${itFolder}/pnpm-workspace.yaml`,
+        "minimumReleaseAgeExclude:\n  - '@vaadin/*'\n"
+      );
+
       // Install the IT module dependencies
       execSync(`mvn flow:prepare-frontend flow:build-frontend`, {
         cwd: itFolder,
@@ -95,7 +103,7 @@ async function runTests() {
       console.log(`Running tests in ${itFolder}`);
       try {
         const watchFlag = options.watch ? ' --watch' : '';
-        execSync(`npx web-test-runner --playwright ${wtrTestsFolderName}/**/*.test.ts${watchFlag}`, {
+        execSync(`npx web-test-runner --playwright ${wtrTestsFolderName}/**/*.test.ts --node-resolve${watchFlag}`, {
           cwd: itFolder,
           stdio: 'inherit'
         });

scripts/wtr.js

@@ -1,59 +1,10 @@
-import fs from 'node:fs';
-import path from 'node:path';
 import { esbuildPlugin } from '@web/dev-server-esbuild';
 import { defaultReporter, summaryReporter } from '@web/test-runner';
 import { junitReporter } from '@web/test-runner-junit-reporter';
 
-/**
- * A plugin that serves frontend files imported from `frontend/generated/jar-resources`
- * from their original source in a component module's `META-INF/frontend` when it exists,
- * instead of the stale build-time copy. The request URL stays in the flat `jar-resources`
- * namespace, so cross-module sibling imports (e.g. `./contextMenuConnector.js`) continue
- * to resolve the same way Flow's flattening makes them.
- *
- * @param {string[]} sourceDirs Absolute paths to `META-INF/frontend` directories to look up
- * sources in, checked in order. Falls back to the build-time copy when no source matches.
- */
-export function frontendSourcePlugin(sourceDirs) {
-  function resolveSourcePath(requestPath) {
-    const match = requestPath.match(/\/frontend\/generated\/jar-resources\/(.+)$/);
-    if (!match) {
-      return;
-    }
-    for (const dir of sourceDirs) {
-      const sourcePath = path.join(dir, match[1]);
-      if (fs.existsSync(sourcePath)) {
-        return sourcePath;
-      }
-    }
-  }
-
-  return {
-    name: 'frontend-source',
-    serverStart({ fileWatcher }) {
-      sourceDirs.forEach((dir) => fileWatcher.add(dir));
-    },
-    serve(context) {
-      const sourcePath = resolveSourcePath(context.path);
-      if (sourcePath) {
-        return { body: fs.readFileSync(sourcePath, 'utf8') };
-      }
-    },
-    transform(context) {
-      const sourcePath = resolveSourcePath(context.path);
-      if (sourcePath) {
-        // Don't cache frontend sources, so a rerun picks up the latest source
-        // instead of a transform cached from a previous run.
-        return { transformCache: false };
-      }
-    }
-  };
-}
-
 /** @type {import('@web/test-runner').TestRunnerConfig} */
 export const sharedConfig = {
   plugins: [esbuildPlugin({ ts: true })],
-  nodeResolve: true,
   testFramework: {
     config: {
       ui: 'bdd',
@@ -65,33 +16,9 @@ export const sharedConfig = {
     <html>
       <body>
         <script type="module">
-          import { use, Assertion } from 'chai';
+          import { use } from 'chai';
           import sinonChai from 'sinon-chai';
           use(sinonChai);
-
-          // When a test fails, web-test-runner ships the error from the browser
-          // to the Node reporter, serializing it with structuredClone. sinon-chai
-          // sets the assertion error's \`actual\` to the spy function itself, and
-          // structuredClone throws on functions. That rejection kills the
-          // session-finished message, so the run reports a 120s "did not finish"
-          // timeout instead of the actual assertion failure. Drop any
-          // actual/expected that can't be cloned so the failure reports cleanly.
-          const assert = Assertion.prototype.assert;
-          Assertion.prototype.assert = function (...args) {
-            try {
-              return assert.apply(this, args);
-            } catch (error) {
-              for (const key of ['actual', 'expected']) {
-                try {
-                  structuredClone(error[key]);
-                } catch {
-                  delete error[key];
-                  error.showDiff = false;
-                }
-              }
-              throw error;
-            }
-          };
         </script>
         <script type="module" src="${testFramework}"></script>
       </body>

shared/shared-web-test-runner-config.mjs

@@ -49,7 +49,7 @@
  * @author Vaadin Ltd
  */
 @Tag("vaadin-accordion")
-@NpmPackage(value = "@vaadin/accordion", version = "25.3.0-alpha1")
+@NpmPackage(value = "@vaadin/accordion", version = "25.2.0")
 @JsModule("@vaadin/accordion/src/vaadin-accordion.js")
 public class Accordion extends Component implements HasSize, HasStyle {
 

vaadin-accordion-flow-parent/vaadin-accordion-flow-integration-tests/pnpm-workspace.yaml

@@ -25,7 +25,7 @@
  * An accordion panel which could be opened or closed.
  */
 @Tag("vaadin-accordion-panel")
-@NpmPackage(value = "@vaadin/accordion", version = "25.3.0-alpha1")
+@NpmPackage(value = "@vaadin/accordion", version = "25.2.0")
 @JsModule("@vaadin/accordion/src/vaadin-accordion-panel.js")
 public class AccordionPanel extends Details {