Promote the p28 soroban host from next-only to current

Bumping CURRENT_LEDGER_PROTOCOL_VERSION to 28 is not enough on its own:
p28 was wired throughout as a next-only host, so a plain build had no p28
host at all and aborted in check_sensible_soroban_config_for_protocol
with max_host_module_proto (27) < core_max_proto (28).

Ungates the p28 module itself, the soroban_curr alias, its HOST_MODULES
entry, the two v1-unsupported stub macros it relies on, and its
SorobanModuleCache field and dispatch arms.

Clears WIP_SOROBAN_PROTOCOL, since p28 is no longer work-in-progress.
That also means --features=next now reaches p28 (it is applied only to
SOROBAN_MAX_PROTOCOL), so under a vnext build the same submodule reports
protocol 29 and matches core's max of 29. The dispatch test is re-gated
accordingly: 28 without the feature, 29 with it.

Author: sisuresh

src/Makefile.am

@@ -225,7 +225,7 @@ ALL_SOROBAN_PROTOCOLS=p27 p28
 else
 ALL_SOROBAN_PROTOCOLS=p21 p22 p23 p24 p25 p26 p27 p28
 endif
-WIP_SOROBAN_PROTOCOL=p28
+WIP_SOROBAN_PROTOCOL=
 
 CARGO_XDR_FEATURE_FLAGS =
 

src/rust/src/soroban_module_cache.rs

@@ -22,7 +22,6 @@ use crate::{
 #[cfg(not(feature = "fastdev"))]
 use crate::soroban_proto_all::{p23, p24, p25, p26};
 
-#[cfg(feature = "next")]
 use crate::soroban_proto_all::p28;
 
 pub(crate) struct SorobanModuleCache {
@@ -35,7 +34,6 @@ pub(crate) struct SorobanModuleCache {
     #[cfg(not(feature = "fastdev"))]
     pub(crate) p26_cache: p26::soroban_proto_any::ProtocolSpecificModuleCache,
     pub(crate) p27_cache: p27::soroban_proto_any::ProtocolSpecificModuleCache,
-    #[cfg(feature = "next")]
     pub(crate) p28_cache: p28::soroban_proto_any::ProtocolSpecificModuleCache,
 }
 
@@ -51,7 +49,6 @@ impl SorobanModuleCache {
             #[cfg(not(feature = "fastdev"))]
             p26_cache: p26::soroban_proto_any::ProtocolSpecificModuleCache::new()?,
             p27_cache: p27::soroban_proto_any::ProtocolSpecificModuleCache::new()?,
-            #[cfg(feature = "next")]
             p28_cache: p28::soroban_proto_any::ProtocolSpecificModuleCache::new()?,
         })
     }
@@ -71,7 +68,6 @@ impl SorobanModuleCache {
             #[cfg(not(feature = "fastdev"))]
             26 => self.p26_cache.compile(_wasm),
             27 => self.p27_cache.compile(_wasm),
-            #[cfg(feature = "next")]
             28 => self.p28_cache.compile(_wasm),
             // Add other protocols here as needed.
             _ => Err(protocol_agnostic::make_error("unsupported protocol")),
@@ -88,7 +84,6 @@ impl SorobanModuleCache {
             #[cfg(not(feature = "fastdev"))]
             p26_cache: self.p26_cache.shallow_clone()?,
             p27_cache: self.p27_cache.shallow_clone()?,
-            #[cfg(feature = "next")]
             p28_cache: self.p28_cache.shallow_clone()?,
         }))
     }
@@ -107,7 +102,6 @@ impl SorobanModuleCache {
         #[cfg(not(feature = "fastdev"))]
         self.p26_cache.evict(&_hash)?;
         self.p27_cache.evict(&_hash)?;
-        #[cfg(feature = "next")]
         self.p28_cache.evict(&_hash)?;
         Ok(())
     }
@@ -121,7 +115,6 @@ impl SorobanModuleCache {
         #[cfg(not(feature = "fastdev"))]
         self.p26_cache.clear()?;
         self.p27_cache.clear()?;
-        #[cfg(feature = "next")]
         self.p28_cache.clear()?;
         Ok(())
     }
@@ -146,7 +139,6 @@ impl SorobanModuleCache {
             #[cfg(not(feature = "fastdev"))]
             26 => self.p26_cache.contains_module(&_hash),
             27 => self.p27_cache.contains_module(&_hash),
-            #[cfg(feature = "next")]
             28 => self.p28_cache.contains_module(&_hash),
             _ => Err(protocol_agnostic::make_error("unsupported protocol")),
         }
@@ -167,7 +159,6 @@ impl SorobanModuleCache {
             #[cfg(not(feature = "fastdev"))]
             26 => bytes = bytes.max(self.p26_cache.get_wasm_bytes_input()?),
             27 => bytes = bytes.max(self.p27_cache.get_wasm_bytes_input()?),
-            #[cfg(feature = "next")]
             28 => bytes = bytes.max(self.p28_cache.get_wasm_bytes_input()?),
             _ => return Err(protocol_agnostic::make_error("unsupported protocol")),
         }

src/rust/src/soroban_proto_all.rs

@@ -32,9 +32,6 @@ use crate::RustBuf;
 // We also alias the latest soroban as soroban_curr to help reduce churn in code
 // that's just "always supposed to use the latest".
 
-#[cfg(not(feature = "next"))]
-pub(crate) use p27 as soroban_curr;
-#[cfg(feature = "next")]
 pub(crate) use p28 as soroban_curr;
 
 // We also pin some protocol _agnostic_ definitions that are technically
@@ -64,7 +61,6 @@ pub(crate) mod protocol_agnostic {
 // Each protocol module supports exactly one of them and has another one defined
 // as a never-called invoke_v1/2_unsupported stub.
 
-#[cfg(feature = "next")]
 macro_rules! invoke_v1_unsupported_stub {
     () => {
         #[allow(unused_variables)]
@@ -134,7 +130,6 @@ macro_rules! invoke_v2_unsupported_stub {
 // Similar to the invoke stubs, we have two versions of the
 // wasm_module_memory_cost with different interfaces: pre-p28, and p28+.
 
-#[cfg(feature = "next")]
 macro_rules! wasm_module_memory_cost_v1_unsupported_stub {
     () => {
         #[allow(unused_variables)]
@@ -181,7 +176,6 @@ macro_rules! ttl_ledger_entry_meta_stub {
     };
 }
 
-#[cfg(feature = "next")]
 #[path = "."]
 pub(crate) mod p28 {
     pub(crate) extern crate soroban_env_host_p28;
@@ -1868,7 +1862,6 @@ const HOST_MODULES: &'static [HostModule] = &[
     #[cfg(not(feature = "fastdev"))]
     proto_versioned_functions_for_module!(p26),
     proto_versioned_functions_for_module!(p27),
-    #[cfg(feature = "next")]
     proto_versioned_functions_for_module!(p28),
 ];
 
@@ -1913,11 +1906,18 @@ fn protocol_dispatches_as_expected() {
         assert_eq!(get_host_module_for_protocol(27, 27).unwrap().max_proto, 27);
     }
 
-    #[cfg(all(feature = "fastdev", feature = "next"))]
+    // p28 is now built unconditionally. Without the "next" feature it reports
+    // protocol 28; with it, the same submodule reports 29.
+    #[cfg(not(feature = "next"))]
     {
         assert_eq!(get_host_module_for_protocol(28, 28).unwrap().max_proto, 28);
     }
 
+    #[cfg(feature = "next")]
+    {
+        assert_eq!(get_host_module_for_protocol(29, 29).unwrap().max_proto, 29);
+    }
+
     // No protocols past the max known.
     let last_proto = HOST_MODULES.last().unwrap().max_proto;
     assert!(get_host_module_for_protocol(last_proto + 1, last_proto + 1).is_err());