Skip to content

馃悰 BUG: packet loss calculation misses some loss#1255

Description

@brianbraunstein

What version of nebula are you using? (nebula -version)

master

What operating system are you using?

not relevant

Describe the Bug

nebula/bits.go

Lines 66 to 68 in 3f6a7cb

for n := b.current + 1; n < i; n++ {
b.bits[n%b.length] = false
}

In this if statement, the b.bits entries that are being set to false should first be checked to see if any are already false, and if so the lostCounter should be incremented for each.

This means any case where you lose more than 1 packet, you risk not counting older packet loss that it skips over.

Logs from affected hosts

not relevant

Config files from affected hosts

not relevant

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions