|
1 | 1 | =============================================================== |
| 2 | +Tag name: ctsm5.4.042 |
| 3 | +Originator(s): slevis (Samuel Levis,UCAR/TSS,303-665-1310) |
| 4 | +Date: Fri May 22 04:07:30 PM MDT 2026 |
| 5 | +One-line Summary: Get hillslope_fsat_equals_zero .true. for use_hillslope |
| 6 | + |
| 7 | +Purpose and description of changes |
| 8 | +---------------------------------- |
| 9 | + |
| 10 | + hillslope_fsat_equals_zero was intended to be .true. for use_hillslope = .true. but was coming back false: |
| 11 | + - First because of the lack of this line in CLMBuildNamelist.pm: |
| 12 | + $nl_flags->{'use_hillslope'} = $nl->get_value('use_hillslope'); |
| 13 | + - And since ctsm5.4.040 due to the placement of said line in sub setup_logic_params_file, which is called after sub setup_logic_hillslope |
| 14 | + |
| 15 | + Here I'm moving that line into sub setup_logic_hillslope, which fixes the problem without breaking anything else. |
| 16 | + |
| 17 | +Significant changes to scientifically-supported configurations |
| 18 | +-------------------------------------------------------------- |
| 19 | + |
| 20 | +Does this tag change answers significantly for any of the following physics configurations? |
| 21 | +(Details of any changes will be given in the "Answer changes" section below.) |
| 22 | + |
| 23 | + [Put an [X] in the box for any configuration with significant answer changes.] |
| 24 | + |
| 25 | +[x] clm6_0 hillslope hydrology |
| 26 | + |
| 27 | +[ ] clm5_0 |
| 28 | + |
| 29 | +[ ] ctsm5_0-nwp |
| 30 | + |
| 31 | +[ ] clm4_5 |
| 32 | + |
| 33 | + |
| 34 | +Bugs fixed |
| 35 | +---------- |
| 36 | +List of CTSM issues fixed (include CTSM Issue # and description) [one per line]: |
| 37 | + Resolves #4030 Bug: hillslope_fsat_equals_zero is .false. when use_hillslope = .true. |
| 38 | + |
| 39 | +Notes of particular relevance for users |
| 40 | +--------------------------------------- |
| 41 | +Changes made to namelist defaults (e.g., changed parameter values): |
| 42 | + Now get the correct hillslope_fsat_equals_zero for use_hillslope = .true.. |
| 43 | + |
| 44 | +Testing summary: |
| 45 | +---------------- |
| 46 | + |
| 47 | + [PASS means all tests PASS; OK means tests PASS other than expected fails.] |
| 48 | + |
| 49 | + build-namelist tests (if CLMBuildNamelist.pm has changed): |
| 50 | + |
| 51 | + derecho - OK (2 expected failures) |
| 52 | + |
| 53 | + regular tests (aux_clm: https://github.com/ESCOMP/CTSM/wiki/System-Testing-Guide#pre-merge-system-testing): |
| 54 | + |
| 55 | + derecho ----- OK |
| 56 | + izumi ------- OK |
| 57 | + |
| 58 | +Answer changes |
| 59 | +-------------- |
| 60 | +Changes answers relative to baseline: Yes |
| 61 | + |
| 62 | + Summarize any changes to answers, i.e., |
| 63 | + - what code configurations: use_hillslope = .true. |
| 64 | + - what platforms/compilers: all |
| 65 | + - nature of change: larger than roundoff |
| 66 | + |
| 67 | + No simulations have been run with the bug-fix, yet. |
| 68 | + |
| 69 | +Other details |
| 70 | +------------- |
| 71 | +Pull Requests that document the changes (include PR ids): |
| 72 | + https://github.com/ESCOMP/ctsm/pull/4046 |
| 73 | + |
| 74 | +=============================================================== |
| 75 | +=============================================================== |
2 | 76 | Tag name: ctsm5.4.041 |
3 | 77 | Originator(s): samrabin (Sam Rabin, UCAR/TSS) |
4 | 78 | Date: Thu May 21 14:33:36 MDT 2026 |
|
0 commit comments