Skip to content

Commit 7b02262

Browse files
committed
feat: add CLIENT_SECRET to authentication properties for Azure and OneLake connections
1 parent eb02519 commit 7b02262

2 files changed

Lines changed: 2 additions & 2 deletions

File tree

core/dbio/database/database_fabric.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -98,7 +98,7 @@ func (conn *MsFabricConn) makeABFSClient() (fs filesys.FileSysClient, err error)
9898
}
9999

100100
// Authentication properties - pass through from connection
101-
for _, key := range []string{"ACCOUNT_KEY", "SAS_SVC_URL", "CLIENT_ID", "TENANT_ID", "CLIENT_SECRET"} {
101+
for _, key := range []string{"ACCOUNT_KEY", "SAS_SVC_URL", "CLIENT_ID", "TENANT_ID", "CLIENT_SECRET", "CLIENT_CERTIFICATE_PATH", "CLIENT_CERTIFICATE_PASSWORD"} {
102102
if val := conn.GetProp(key); val != "" {
103103
abfsProps = append(abfsProps, key+"="+val)
104104
}

core/dbio/filesys/fs_azure.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -39,7 +39,7 @@ func (fs *AzureFileSysClient) Init(ctx context.Context) (err error) {
3939
}
4040

4141
// service principal keys that need to be set in env var
42-
for _, key := range g.ArrStr("CLIENT_ID", "TENANT_ID", "CLIENT_CERTIFICATE_PATH", "CLIENT_CERTIFICATE_PASSWORD") {
42+
for _, key := range g.ArrStr("CLIENT_ID", "TENANT_ID", "CLIENT_SECRET", "CLIENT_CERTIFICATE_PATH", "CLIENT_CERTIFICATE_PASSWORD") {
4343
if val := fs.GetProp(key); val != "" {
4444
os.Setenv("AZURE_"+key, val)
4545
}

0 commit comments

Comments
 (0)