fix(oracle): prevent SID option from conflicting with service_name in connection string

Author: flarco

core/dbio/database/database_oracle.go

@@ -128,7 +128,17 @@ func (conn *OracleConn) ConnString() string {
 	// infinite timeout by default
 	options := map[string]string{"TIMEOUT": "0"}
 
+	// When service_name is explicitly provided, do not forward `sid` as an
+	// option — go-ora's ConnectionConfig prefers SID over ServiceName when
+	// both are set, which causes ORA-12505 against PDBs/services like
+	// FREEPDB1. The `sid` prop is often auto-populated from the URL path
+	// (see connection.setURL), so dropping it here is the safe choice when
+	// the caller asked for service-name semantics.
+	serviceName := conn.GetProp("service_name")
 	for key, new_key := range propMapping {
+		if key == "sid" && serviceName != "" {
+			continue
+		}
 		if val := conn.GetProp(key); val != "" {
 			options[new_key] = val
 		}

go.mod

@@ -164,6 +164,7 @@ require (
 	github.com/clipperhouse/uax29/v2 v2.3.0 // indirect
 	github.com/cncf/xds/go v0.0.0-20251022180443-0feb69152e9f // indirect
 	github.com/cockroachdb/apd/v3 v3.2.1 // indirect
+	github.com/coder/websocket v1.8.14 // indirect
 	github.com/containerd/console v1.0.5 // indirect
 	github.com/coreos/go-oidc/v3 v3.5.0 // indirect
 	github.com/creack/pty v1.1.18 // indirect

go.sum

@@ -236,6 +236,8 @@ github.com/cncf/xds/go v0.0.0-20251022180443-0feb69152e9f h1:Y8xYupdHxryycyPlc9Y
 github.com/cncf/xds/go v0.0.0-20251022180443-0feb69152e9f/go.mod h1:HlzOvOjVBOfTGSRXRyY0OiCS/3J1akRGQQpRO/7zyF4=
 github.com/cockroachdb/apd/v3 v3.2.1 h1:U+8j7t0axsIgvQUqthuNm82HIrYXodOV2iWLWtEaIwg=
 github.com/cockroachdb/apd/v3 v3.2.1/go.mod h1:klXJcjp+FffLTHlhIG69tezTDvdP065naDsHzKhYSqc=
+github.com/coder/websocket v1.8.14 h1:9L0p0iKiNOibykf283eHkKUHHrpG7f65OE3BhhO7v9g=
+github.com/coder/websocket v1.8.14/go.mod h1:NX3SzP+inril6yawo5CQXx8+fk145lPDC6pumgx0mVg=
 github.com/compose-spec/compose-go/v2 v2.6.0 h1:/+oBD2ixSENOeN/TlJqWZmUak0xM8A7J08w/z661Wd4=
 github.com/compose-spec/compose-go/v2 v2.6.0/go.mod h1:vPlkN0i+0LjLf9rv52lodNMUTJF5YHVfHVGLLIP67NA=
 github.com/containerd/console v1.0.3/go.mod h1:7LqA/THxQ86k76b8c/EMSiaJ3h1eZkMkXar0TQ1gf3U=