Refactor Album and Artist classes to remove unnecessary nesting and improve readability

Remove Anchor class and related records as part of the refactoring process

Update BloodSugarReading and BloodSugarStatus classes to use UTC for date handling and improve property access

Modify PlayerStatus class to simplify structure and improve clarity

Change Records class to sealed for better encapsulation

Update DeviceStateResponse and TemperatureStatus classes to use UTC for date handling

Enhance project files to allow warnings in Release builds for CI/CD

Implement SignalR support for anchor notifications with AnchorHub and AnchorNotificationService

Create AnchorSyncService to manage real-time updates for anchor definitions and user assignments

Update appsettings for production and Tailscale environments to include AnchorsApiAddress

Refactor BrowserAudioService and LocalQueueService for improved logging and consistency

Enhance PlaybackModeService to streamline playback mode handling and logging

Author: snow-jallen

HomeSpeaker.Server2/HomeSpeaker.Server2.csproj

@@ -7,6 +7,14 @@
     <DockerDefaultTargetOS>Linux</DockerDefaultTargetOS>
     <DockerComposeProjectPath>..\docker-compose.dcproj</DockerComposeProjectPath>
   </PropertyGroup>
+  
+  <!-- Allow warnings in Release builds for CI/CD -->
+  <PropertyGroup Condition="'$(Configuration)' == 'Release'">
+    <TreatWarningsAsErrors>false</TreatWarningsAsErrors>
+    <WarningsAsErrors />
+    <WarningsNotAsErrors />
+    <NoWarn>$(NoWarn);CS0169;CS0414;CS8618;CS8604;CS8600;CS8602;CS8603;CS4014;CS1998;SYSLIB0051;IDE0009;IDE0044;IDE0005;IDE0161;IDE0130;IDE1006;IDE2001;IDE2000;IDE0055;IDE0040;IDE2003;IDE0007;IDE0011;IDE0004;IDE2002;IDE0059;SA1649;CA1003;CA1063;CA1065;CA1725;CA1727;CA1805;CA1816;CA1823;CA1826;CA1835;CA1836;CA1849;CA1852;CA1854;CA1861;CA1869;CA2012;CA2016;CA2052;CA2254;MA0134;RS0030</NoWarn>
+  </PropertyGroup>
   <ItemGroup>
     <Protobuf Include="Protos\greet.proto" GrpcServices="Server" />
   </ItemGroup>

HomeSpeaker.Server2/Hubs/AnchorHub.cs

@@ -0,0 +1,16 @@
+using Microsoft.AspNetCore.SignalR;
+
+namespace HomeSpeaker.Server2.Hubs;
+
+public class AnchorHub : Hub
+{
+    public async Task JoinAnchorGroup()
+    {
+        await Groups.AddToGroupAsync(Context.ConnectionId, "AnchorUpdates");
+    }
+
+    public async Task LeaveAnchorGroup()
+    {
+        await Groups.RemoveFromGroupAsync(Context.ConnectionId, "AnchorUpdates");
+    }
+}

HomeSpeaker.Server2/Program.cs

@@ -34,6 +34,8 @@
 builder.Services.AddHostedService<AirPlayReceiverService>();
 builder.Services.AddScoped<PlaylistService>();
 builder.Services.AddScoped<AnchorService>();
+builder.Services.AddScoped<IAnchorNotificationService, AnchorNotificationService>();
+builder.Services.AddSignalR();
 builder.Services.AddDbContext<MusicContext>(options => options.UseSqlite(builder.Configuration["SqliteConnectionString"]));
 builder.Services.AddSingleton<IDataStore, OnDiskDataStore>();
 builder.Services.AddSingleton<IFileSource>(_ => new DefaultFileSource(builder.Configuration[ConfigKeys.MediaFolder] ?? throw new MissingConfigException(ConfigKeys.MediaFolder)));
@@ -91,6 +93,7 @@
 app.UseRouting();
 app.UseCors(LocalCorsPolicy);
 app.MapRazorPages();
+app.MapHub<HomeSpeaker.Server2.Hubs.AnchorHub>("/anchorHub");
 
 // Configure the HTTP request pipeline.
 app.MapGrpcService<GreeterService>();

HomeSpeaker.Server2/Services/AnchorNotificationService.cs

@@ -0,0 +1,53 @@
+using HomeSpeaker.Server2.Hubs;
+using HomeSpeaker.Shared;
+using Microsoft.AspNetCore.SignalR;
+
+namespace HomeSpeaker.Server2.Services;
+
+public class AnchorNotificationService : IAnchorNotificationService
+{
+    private readonly IHubContext<AnchorHub> _hubContext;
+    private readonly ILogger<AnchorNotificationService> _logger;
+
+    public AnchorNotificationService(IHubContext<AnchorHub> hubContext, ILogger<AnchorNotificationService> logger)
+    {
+        _hubContext = hubContext;
+        _logger = logger;
+    }
+
+    public async Task NotifyAnchorDefinitionCreated(AnchorDefinition anchorDefinition)
+    {
+        _logger.LogInformation("Broadcasting anchor definition created: {name}", anchorDefinition.Name);
+        await _hubContext.Clients.Group("AnchorUpdates").SendAsync("AnchorDefinitionCreated", anchorDefinition);
+    }
+
+    public async Task NotifyAnchorDefinitionUpdated(AnchorDefinition anchorDefinition)
+    {
+        _logger.LogInformation("Broadcasting anchor definition updated: {name}", anchorDefinition.Name);
+        await _hubContext.Clients.Group("AnchorUpdates").SendAsync("AnchorDefinitionUpdated", anchorDefinition);
+    }
+
+    public async Task NotifyAnchorDefinitionDeactivated(int anchorDefinitionId)
+    {
+        _logger.LogInformation("Broadcasting anchor definition deactivated: {id}", anchorDefinitionId);
+        await _hubContext.Clients.Group("AnchorUpdates").SendAsync("AnchorDefinitionDeactivated", anchorDefinitionId);
+    }
+
+    public async Task NotifyUserAnchorAssigned(UserAnchor userAnchor)
+    {
+        _logger.LogInformation("Broadcasting user anchor assigned: user {userId}, anchor {anchorId}", userAnchor.UserId, userAnchor.AnchorDefinitionId);
+        await _hubContext.Clients.Group("AnchorUpdates").SendAsync("UserAnchorAssigned", userAnchor);
+    }
+
+    public async Task NotifyUserAnchorRemoved(string userId, int anchorDefinitionId)
+    {
+        _logger.LogInformation("Broadcasting user anchor removed: user {userId}, anchor {anchorId}", userId, anchorDefinitionId);
+        await _hubContext.Clients.Group("AnchorUpdates").SendAsync("UserAnchorRemoved", userId, anchorDefinitionId);
+    }
+
+    public async Task NotifyDailyAnchorCompletionUpdated(int dailyAnchorId, bool isCompleted, DateTime? completedAt)
+    {
+        _logger.LogInformation("Broadcasting daily anchor completion updated: {dailyAnchorId}, completed: {isCompleted}", dailyAnchorId, isCompleted);
+        await _hubContext.Clients.Group("AnchorUpdates").SendAsync("DailyAnchorCompletionUpdated", dailyAnchorId, isCompleted, completedAt);
+    }
+}

HomeSpeaker.Server2/Services/AnchorService.cs

@@ -8,11 +8,13 @@ public class AnchorService
 {
     private readonly MusicContext _dbContext;
     private readonly ILogger<AnchorService> _logger;
+    private readonly IAnchorNotificationService _notificationService;
 
-    public AnchorService(MusicContext dbContext, ILogger<AnchorService> logger)
+    public AnchorService(MusicContext dbContext, ILogger<AnchorService> logger, IAnchorNotificationService notificationService)
     {
         _dbContext = dbContext;
         _logger = logger;
+        _notificationService = notificationService;
     }
 
     // Anchor Definition Management
@@ -41,7 +43,9 @@ public async Task<AnchorDefinition> CreateAnchorDefinitionAsync(CreateAnchorDefi
         await _dbContext.AnchorDefinitions.AddAsync(entity);
         await _dbContext.SaveChangesAsync();
 
-        return new AnchorDefinition(entity.Id, entity.Name, entity.Description, entity.IsActive);
+        var result = new AnchorDefinition(entity.Id, entity.Name, entity.Description, entity.IsActive);
+        await _notificationService.NotifyAnchorDefinitionCreated(result);
+        return result;
     }
 
     public async Task<AnchorDefinition?> UpdateAnchorDefinitionAsync(int id, CreateAnchorDefinitionRequest request)
@@ -58,7 +62,9 @@ public async Task<AnchorDefinition> CreateAnchorDefinitionAsync(CreateAnchorDefi
         await _dbContext.SaveChangesAsync();
 
         _logger.LogInformation("Updated anchor definition {id}: {name}", id, request.Name);
-        return new AnchorDefinition(entity.Id, entity.Name, entity.Description, entity.IsActive);
+        var result = new AnchorDefinition(entity.Id, entity.Name, entity.Description, entity.IsActive);
+        await _notificationService.NotifyAnchorDefinitionUpdated(result);
+        return result;
     }
 
     public async Task<bool> DeactivateAnchorDefinitionAsync(int id)
@@ -75,6 +81,7 @@ public async Task<bool> DeactivateAnchorDefinitionAsync(int id)
         await _dbContext.SaveChangesAsync();
 
         _logger.LogInformation("Deactivated anchor definition {id}: {name}", id, entity.Name);
+        await _notificationService.NotifyAnchorDefinitionDeactivated(id);
         return true;
     }
 
@@ -113,7 +120,9 @@ public async Task<UserAnchor> AssignAnchorToUserAsync(AssignAnchorToUserRequest
         await _dbContext.SaveChangesAsync();
 
         _logger.LogInformation("Assigned anchor {anchorId} to user {userId}", request.AnchorDefinitionId, request.UserId);
-        return new UserAnchor(entity.Id, entity.UserId, entity.AnchorDefinitionId, entity.CreatedAt);
+        var result = new UserAnchor(entity.Id, entity.UserId, entity.AnchorDefinitionId, entity.CreatedAt);
+        await _notificationService.NotifyUserAnchorAssigned(result);
+        return result;
     }
 
     public async Task<bool> RemoveAnchorFromUserAsync(string userId, int anchorDefinitionId)
@@ -131,6 +140,7 @@ public async Task<bool> RemoveAnchorFromUserAsync(string userId, int anchorDefin
         await _dbContext.SaveChangesAsync();
 
         _logger.LogInformation("Removed anchor {anchorId} from user {userId}", anchorDefinitionId, userId);
+        await _notificationService.NotifyUserAnchorRemoved(userId, anchorDefinitionId);
         return true;
     }
 
@@ -216,6 +226,7 @@ public async Task<bool> UpdateAnchorCompletionAsync(UpdateAnchorCompletionReques
         await _dbContext.SaveChangesAsync();
 
         _logger.LogInformation("Updated daily anchor {id} completion to {completed}", request.DailyAnchorId, request.IsCompleted);
+        await _notificationService.NotifyDailyAnchorCompletionUpdated(request.DailyAnchorId, request.IsCompleted, entity.CompletedAt);
         return true;
     }
 

HomeSpeaker.Server2/Services/IAnchorNotificationService.cs

@@ -0,0 +1,13 @@
+using HomeSpeaker.Shared;
+
+namespace HomeSpeaker.Server2.Services;
+
+public interface IAnchorNotificationService
+{
+    Task NotifyAnchorDefinitionCreated(AnchorDefinition anchorDefinition);
+    Task NotifyAnchorDefinitionUpdated(AnchorDefinition anchorDefinition);
+    Task NotifyAnchorDefinitionDeactivated(int anchorDefinitionId);
+    Task NotifyUserAnchorAssigned(UserAnchor userAnchor);
+    Task NotifyUserAnchorRemoved(string userId, int anchorDefinitionId);
+    Task NotifyDailyAnchorCompletionUpdated(int dailyAnchorId, bool isCompleted, DateTime? completedAt);
+}

HomeSpeaker.Shared/Album.cs

@@ -1,16 +1,12 @@
-using System;
-using System.Collections.Generic;
-using System.Linq;
-using System.Text;
+using System.Linq;
 
-namespace HomeSpeaker.Shared
+namespace HomeSpeaker.Shared;
+
+public class Album
 {
-    public class Album
-    {
-        public int AlbumId { get; set; }
-        public string Name { get; set; }
-        public IQueryable<Song> Songs { get; set; }
-        public Artist Artist { get; set; }
-        public int ArtistId { get; set; }
-    }
+    public int AlbumId { get; set; }
+    public string Name { get; set; }
+    public IQueryable<Song> Songs { get; set; }
+    public Artist Artist { get; set; }
+    public int ArtistId { get; set; }
 }

HomeSpeaker.Shared/Anchor.cs HomeSpeaker.Shared/AnchorDefinition.csHomeSpeaker.Shared/Anchor.cs renamed to HomeSpeaker.Shared/AnchorDefinition.cs

@@ -1,15 +1,11 @@
-using System;
-using System.Collections.Generic;
-using System.Linq;
-using System.Text;
+using System.Linq;
 
-namespace HomeSpeaker.Shared
+namespace HomeSpeaker.Shared;
+
+public class Artist
 {
-    public class Artist
-    {
-        public int ArtistId { get; set; }
-        public string Name { get; set; }
-        public IQueryable<Album> Albums { get; set; }
-        public IQueryable<Song> Songs { get; set; }
-    }
+    public int ArtistId { get; set; }
+    public string Name { get; set; }
+    public IQueryable<Album> Albums { get; set; }
+    public IQueryable<Song> Songs { get; set; }
 }

HomeSpeaker.Shared/Artist.cs

@@ -8,12 +8,12 @@ public sealed class BloodSugarReading
 {
     public double Sgv { get; set; }
     //public DateTime Date { get; set; }
-    public DateTime Date => DateString;
+    public DateTime Date => this.DateString;
     public string Direction { get; set; } = string.Empty;
     public string Type { get; set; } = string.Empty;
     public DateTime DateString { get; set; }
 
-    public string DirectionIcon => Direction switch
+    public string DirectionIcon => this.Direction switch
     {
         "Flat" => "→",
         "SingleUp" => "↗",
@@ -25,7 +25,7 @@ public sealed class BloodSugarReading
         _ => "?"
     };
 
-    public string DirectionDescription => Direction switch
+    public string DirectionDescription => this.Direction switch
     {
         "Flat" => "Stable",
         "SingleUp" => "Rising slowly",