Refactor AirPlay receiver command for improved readability and execution flow

Author: snow-jallen

docker-compose.yml

@@ -63,51 +63,7 @@ services:
       - PULSE_SERVER=unix:/run/user/1000/pulse/native
       - PULSE_RUNTIME_PATH=/run/user/1000/pulse
       - AIRPLAY_NAME=${AIRPLAY_NAME:-HomeSpeaker}
-    command: 
-      - /bin/sh
-      - -c
-      - |
-        set -e
-        echo "=== Bypassing s6 init and starting manually ==="
-        echo "Using AirPlay name: $${AIRPLAY_NAME}"
-        echo "Hostname: $(hostname)"
-        
-        # Kill any existing s6 processes to ensure clean start
-        pkill -f s6 || true
-        
-        # Copy template and replace placeholder with actual name
-        cp /tmp/shairport-sync-template.conf /etc/shairport-sync.conf
-        sed -i "s/AIRPLAY_NAME_PLACEHOLDER/$${AIRPLAY_NAME}/g" /etc/shairport-sync.conf
-        
-        echo "=== Config file generated ==="
-        cat /etc/shairport-sync.conf
-        
-        echo ""
-        echo "=== Starting required services manually ==="
-        
-        # Start D-Bus system daemon
-        echo "Starting D-Bus..."
-        mkdir -p /var/run/dbus
-        dbus-daemon --system --fork --print-pid > /var/run/dbus.pid || true
-        sleep 2
-        
-        # Start Avahi daemon for mDNS
-        echo "Starting Avahi daemon..."
-        avahi-daemon --daemonize --no-drop-root || true
-        sleep 3
-        
-        echo ""
-        echo "=== Audio setup debugging ==="
-        echo "PULSE_SERVER: $${PULSE_SERVER}"
-        echo "PULSE_RUNTIME_PATH: $${PULSE_RUNTIME_PATH}"
-        ls -la /run/user/1000/pulse/ || echo "PulseAudio socket not found"
-        
-        # Test PulseAudio connection
-        which pactl && pactl info || echo "PulseAudio not accessible, will fall back to ALSA"
-        
-        echo ""
-        echo "=== Starting shairport-sync ==="
-        exec /usr/local/bin/shairport-sync -c /etc/shairport-sync.conf -v
+    command: ["/bin/sh", "-c", "set -e && echo '=== Bypassing s6 init and starting manually ===' && echo 'Using AirPlay name: $${AIRPLAY_NAME}' && echo 'Hostname: $$(hostname)' && pkill -f s6 || true && cp /tmp/shairport-sync-template.conf /etc/shairport-sync.conf && sed -i 's/AIRPLAY_NAME_PLACEHOLDER/$${AIRPLAY_NAME}/g' /etc/shairport-sync.conf && echo '=== Config file generated ===' && cat /etc/shairport-sync.conf && echo '' && echo '=== Starting required services manually ===' && echo 'Starting D-Bus...' && mkdir -p /var/run/dbus && (dbus-daemon --system --fork --print-pid > /var/run/dbus.pid || true) && sleep 2 && echo 'Starting Avahi daemon...' && (avahi-daemon --daemonize --no-drop-root || true) && sleep 3 && echo '' && echo '=== Audio setup debugging ===' && echo 'PULSE_SERVER: $${PULSE_SERVER}' && echo 'PULSE_RUNTIME_PATH: $${PULSE_RUNTIME_PATH}' && (ls -la /run/user/1000/pulse/ || echo 'PulseAudio socket not found') && (which pactl && pactl info || echo 'PulseAudio not accessible, will fall back to ALSA') && echo '' && echo '=== Starting shairport-sync ===' && exec /usr/local/bin/shairport-sync -c /etc/shairport-sync.conf -v"]
     depends_on:
       - homespeaker.server2