Skip to content

Commit 96da35c

Browse files
Update NumberOverflowAsStringIT.cs
1 parent 7dd5f8f commit 96da35c

1 file changed

Lines changed: 21 additions & 21 deletions

File tree

Snowflake.Data.Tests/IntegrationTests/NumberOverflowAsStringIT.cs

Lines changed: 21 additions & 21 deletions
Original file line numberDiff line numberDiff line change
@@ -47,15 +47,15 @@ public async Task TestGetValueReturnsStringForOverflowWhenFlagIsSet(string inser
4747
var tableNameSuffix = Guid.NewGuid().ToString("N");
4848
var tableName = _fixture.TableNameBaseName + "_" + tableNameSuffix;
4949
using var conn = OpenConnectionWithFlag();
50-
await _fixture.CreateOrReplaceTable(conn, tableName, [$"cola NUMBER({precision},{scale})"]);
50+
await _fixture.CreateOrReplaceTable(conn, tableName, [$"cola NUMBER({precision},{scale})"]).ConfigureAwait(false);
5151
var cmd1 = conn.CreateCommand();
5252
cmd1.CommandText = $"INSERT INTO {tableName} VALUES ('{insert}'::NUMBER({precision},{scale}))";
53-
await cmd1.ExecuteNonQueryAsync();
53+
await cmd1.ExecuteNonQueryAsync().ConfigureAwait(false);
5454

5555
var cmd = conn.CreateCommand();
5656
cmd.CommandText = $"SELECT cola FROM {tableName}";
57-
using var reader = await cmd.ExecuteReaderAsync();
58-
Assert.True(await reader.ReadAsync());
57+
using var reader = await cmd.ExecuteReaderAsync().ConfigureAwait(false);
58+
Assert.True(await reader.ReadAsync().ConfigureAwait(false));
5959
var value = reader.GetValue(0);
6060
Assert.IsType<string>(value);
6161
Assert.Equal(insert, (string)value);
@@ -67,15 +67,15 @@ public async Task TestGetValueThrowsOverflowWhenFlagIsNotSet()
6767
var tableNameSuffix = Guid.NewGuid().ToString("N");
6868
var tableName = _fixture.TableNameBaseName + "_" + tableNameSuffix;
6969
using var conn = OpenConnectionWithoutFlag();
70-
await _fixture.CreateOrReplaceTable(conn, tableName, ["cola NUMBER(38,0)"]);
70+
await _fixture.CreateOrReplaceTable(conn, tableName, ["cola NUMBER(38,0)"]).ConfigureAwait(false);
7171
var cmd1 = conn.CreateCommand();
7272
cmd1.CommandText = $"INSERT INTO {tableName} VALUES ('{BigNumber}'::NUMBER(38,0))";
73-
await cmd1.ExecuteNonQueryAsync();
73+
await cmd1.ExecuteNonQueryAsync().ConfigureAwait(false);
7474

7575
var cmd = conn.CreateCommand();
7676
cmd.CommandText = $"SELECT cola FROM {tableName}";
7777
using var reader = await cmd.ExecuteReaderAsync();
78-
Assert.True(await reader.ReadAsync());
78+
Assert.True(await reader.ReadAsync().ConfigureAwait(false));
7979
Assert.Throws<OverflowException>(() => reader.GetValue(0));
8080
}
8181

@@ -85,15 +85,15 @@ public async Task TestGetStringAlwaysReturnsRawString()
8585
using var conn = OpenConnectionWithoutFlag();
8686
var tableNameSuffix = Guid.NewGuid().ToString("N");
8787
var tableName = _fixture.TableNameBaseName + "_" + tableNameSuffix;
88-
await _fixture.CreateOrReplaceTable(conn, tableName, ["cola NUMBER(38,0)"]);
88+
await _fixture.CreateOrReplaceTable(conn, tableName, ["cola NUMBER(38,0)"]).ConfigureAwait(false);
8989
var cmd1 = conn.CreateCommand();
9090
cmd1.CommandText = $"INSERT INTO {tableName} VALUES ('{BigNumber}'::NUMBER(38,0))";
91-
await cmd1.ExecuteNonQueryAsync();
91+
await cmd1.ExecuteNonQueryAsync().ConfigureAwait(false);
9292

9393
var cmd = conn.CreateCommand();
9494
cmd.CommandText = $"SELECT cola FROM {tableName}";
95-
using var reader = await cmd.ExecuteReaderAsync();
96-
Assert.True(await reader.ReadAsync());
95+
using var reader = await cmd.ExecuteReaderAsync().ConfigureAwait(false);
96+
Assert.True(await reader.ReadAsync().ConfigureAwait(false));
9797
Assert.Equal(BigNumber, reader.GetString(0));
9898
}
9999

@@ -103,10 +103,10 @@ public async Task TestDbDataAdapterFillThrowsOverflowWhenFlagIsNotSet()
103103
using var conn = OpenConnectionWithoutFlag();
104104
var tableNameSuffix = Guid.NewGuid().ToString("N");
105105
var tableName = _fixture.TableNameBaseName + "_" + tableNameSuffix;
106-
await _fixture.CreateOrReplaceTable(conn, tableName, ["cola NUMBER(38,0)"]);
106+
await _fixture.CreateOrReplaceTable(conn, tableName, ["cola NUMBER(38,0)"]).ConfigureAwait(false);
107107
var cmd = conn.CreateCommand();
108108
cmd.CommandText = $"INSERT INTO {tableName} VALUES ('{BigNumber}'::NUMBER(38,0))";
109-
await cmd.ExecuteNonQueryAsync();
109+
await cmd.ExecuteNonQueryAsync().ConfigureAwait(false);
110110

111111
var adapter = new SnowflakeDbDataAdapter($"SELECT cola FROM {tableName}", conn);
112112
var dataTable = new DataTable();
@@ -119,10 +119,10 @@ public async Task TestDbDataAdapterFillWithPreTypedStringColumnStoresOverflowAsS
119119
using var conn = OpenConnectionWithFlag();
120120
var tableNameSuffix = Guid.NewGuid().ToString("N");
121121
var tableName = _fixture.TableNameBaseName + "_" + tableNameSuffix;
122-
await _fixture.CreateOrReplaceTable(conn, tableName, ["cola NUMBER(38,0)"]);
122+
await _fixture.CreateOrReplaceTable(conn, tableName, ["cola NUMBER(38,0)"]).ConfigureAwait(false);
123123
var cmd = conn.CreateCommand();
124124
cmd.CommandText = $"INSERT INTO {tableName} VALUES ('{BigNumber}'::NUMBER(38,0))";
125-
await cmd.ExecuteNonQueryAsync();
125+
await cmd.ExecuteNonQueryAsync().ConfigureAwait(false);
126126

127127
// Pre-declare the column as string so the adapter can store the
128128
// string returned by GetValue() without an Int64 coercion attempt.
@@ -145,15 +145,15 @@ public async Task TestMixedRowsViaReader()
145145
var tableName = _fixture.TableNameBaseName + "_" + tableNameSuffix;
146146

147147
using var conn = OpenConnectionWithFlag();
148-
await _fixture.CreateOrReplaceTable(conn, tableName, ["cola NUMBER(38,0)"]);
148+
await _fixture.CreateOrReplaceTable(conn, tableName, ["cola NUMBER(38,0)"]).ConfigureAwait(false);
149149
var cmd = conn.CreateCommand();
150150
cmd.CommandText =
151151
$"INSERT INTO {tableName} VALUES ('{SmallNumber}'::NUMBER(38,0)), ('{BigNumber}'::NUMBER(38,0))";
152-
await cmd.ExecuteNonQueryAsync();
152+
await cmd.ExecuteNonQueryAsync().ConfigureAwait(false);
153153

154154
cmd.CommandText = $"SELECT cola FROM {tableName} ORDER BY cola";
155-
using var reader = await cmd.ExecuteReaderAsync();
156-
Assert.True(await reader.ReadAsync());
155+
using var reader = await cmd.ExecuteReaderAsync().ConfigureAwait(false);
156+
Assert.True(await reader.ReadAsync().ConfigureAwait(false));
157157
// Small value fits — JSON returns Int64, Arrow returns decimal
158158
// (NUMBER(38,0) columns always use Decimal128 in Arrow).
159159
var smallVal = reader.GetValue(0);
@@ -162,12 +162,12 @@ public async Task TestMixedRowsViaReader()
162162
else
163163
Assert.Equal(42m, smallVal);
164164

165-
Assert.True(await reader.ReadAsync());
165+
Assert.True(await reader.ReadAsync().ConfigureAwait(false));
166166
// Large value overflows — returned as string
167167
Assert.IsType<string>(reader.GetValue(0));
168168
Assert.Equal(BigNumber, (string)reader.GetValue(0));
169169

170-
Assert.False(await reader.ReadAsync());
170+
Assert.False(await reader.ReadAsync().ConfigureAwait(false));
171171
}
172172

173173
private SnowflakeDbConnection OpenConnectionWithFlag()

0 commit comments

Comments
 (0)