SNOW-2924623: Connection should not expect password when using WIF or…#2621
Open
rpiccoli wants to merge 15 commits into
Open
SNOW-2924623: Connection should not expect password when using WIF or…#2621rpiccoli wants to merge 15 commits into
rpiccoli wants to merge 15 commits into
Conversation
|
All contributors have signed the CLA ✍️ ✅ |
Author
|
I have read the CLA Document and I hereby sign the CLA |
sfc-gh-rkowalski
left a comment
Collaborator
There was a problem hiding this comment.
Thank you for your contribution. Change looks good overall, only few comments regarding tests
Author
|
@sfc-gh-rkowalski, I am sorry for the delay, but I addressed your comments. Thank you. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
SNOW-2924623: Connection expects password even when using WIF with OIDC #2456
Pre-review self checklist
masterbranchmvn -P check-style validate)mvn verifyand inspecttarget/japicmp/japicmp.html)SNOW-XXXX:External contributors - please answer these questions before submitting a pull request. Thanks!
What GitHub issue is this PR addressing? Make sure that there is an accompanying issue to your PR.
Issue: SNOW-2924623: Connection expects password even when using WIF with OIDC #2456
Fill out the following pre-review checklist:
@SnowflakeJdbcInternalApi(note that public/protected methods/fields in classes marked with this annotation are already internal)Please describe how your code solves the related issue.
When implementing SNOW-533673 feature request for OAUTH, the code introduced the bug of enforcing passwords for OIDC (WIP) and PAT authentications. The solution is add these types of authenticators to the conditions. I wrote tests before implementing the fix.