Skip to content

SNOW-2924623: Connection should not expect password when using WIF or…#2621

Open
rpiccoli wants to merge 15 commits into
snowflakedb:masterfrom
rpiccoli:SNOW-2924623_no_password_for_WIF_or_PAT
Open

SNOW-2924623: Connection should not expect password when using WIF or…#2621
rpiccoli wants to merge 15 commits into
snowflakedb:masterfrom
rpiccoli:SNOW-2924623_no_password_for_WIF_or_PAT

Conversation

@rpiccoli

@rpiccoli rpiccoli commented May 7, 2026

Copy link
Copy Markdown

Overview

SNOW-2924623: Connection expects password even when using WIF with OIDC #2456

Pre-review self checklist

  • PR branch is updated with all the changes from master branch
  • The code is correctly formatted (run mvn -P check-style validate)
  • New public API is not unnecessary exposed (run mvn verify and inspect target/japicmp/japicmp.html)
  • The pull request name is prefixed with SNOW-XXXX:
  • Code is in compliance with internal logging requirements

External contributors - please answer these questions before submitting a pull request. Thanks!

  1. What GitHub issue is this PR addressing? Make sure that there is an accompanying issue to your PR.

    Issue: SNOW-2924623: Connection expects password even when using WIF with OIDC #2456

  2. Fill out the following pre-review checklist:

    • I am adding a new automated test(s) to verify correctness of my new code
    • I am adding new logging messages
    • I am modifying authorization mechanisms
    • I am adding new credentials
    • I am modifying OCSP code
    • I am adding a new dependency or upgrading an existing one
    • I am adding new public/protected component not marked with @SnowflakeJdbcInternalApi (note that public/protected methods/fields in classes marked with this annotation are already internal)
  3. Please describe how your code solves the related issue.

When implementing SNOW-533673 feature request for OAUTH, the code introduced the bug of enforcing passwords for OIDC (WIP) and PAT authentications. The solution is add these types of authenticators to the conditions. I wrote tests before implementing the fix.

@rpiccoli rpiccoli requested a review from a team as a code owner May 7, 2026 20:34
@github-actions

github-actions Bot commented May 7, 2026

Copy link
Copy Markdown

All contributors have signed the CLA ✍️ ✅
Posted by the CLA Assistant Lite bot.

@rpiccoli

rpiccoli commented May 7, 2026

Copy link
Copy Markdown
Author

I have read the CLA Document and I hereby sign the CLA

@sfc-gh-rkowalski sfc-gh-rkowalski left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your contribution. Change looks good overall, only few comments regarding tests

@rpiccoli

Copy link
Copy Markdown
Author

@sfc-gh-rkowalski, I am sorry for the delay, but I addressed your comments. Thank you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants