Skip to content

Commit 109f0c1

Browse files
authored
Merge pull request #98 from bcarreno/master
Fix spec failures & support Solidus 4
2 parents df625b8 + f1ca8d1 commit 109f0c1

8 files changed

Lines changed: 33 additions & 18 deletions

File tree

.circleci/config.yml

Lines changed: 27 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -9,15 +9,37 @@ orbs:
99

1010
jobs:
1111
run-specs-with-postgres:
12-
executor: solidusio_extensions/postgres
12+
executor:
13+
name: solidusio_extensions/postgres
14+
ruby_version: '3.0'
1315
steps:
14-
- solidusio_extensions/run-tests
16+
- checkout
17+
- solidusio_extensions/dependencies
18+
- run:
19+
name: "Run specs on the legacy frontend with postgres"
20+
command: export FRONTEND=solidus_frontend
21+
- solidusio_extensions/test-branch:
22+
branch: v3.3
23+
rails_version: '~> 7.0'
24+
- solidusio_extensions/store-test-results
1525
run-specs-with-mysql:
16-
executor: solidusio_extensions/mysql
26+
executor:
27+
name: solidusio_extensions/mysql
28+
ruby_version: '3.0'
1729
steps:
18-
- solidusio_extensions/run-tests
30+
- checkout
31+
- solidusio_extensions/dependencies
32+
- run:
33+
name: "Run specs on the legacy frontend with mysql"
34+
command: export FRONTEND=solidus_frontend
35+
- solidusio_extensions/test-branch:
36+
branch: v3.3
37+
rails_version: '~> 7.0'
38+
- solidusio_extensions/store-test-results
1939
lint-code:
20-
executor: solidusio_extensions/sqlite-memory
40+
executor:
41+
name: solidusio_extensions/sqlite-memory
42+
ruby_version: '3.0'
2143
steps:
2244
- solidusio_extensions/lint-code
2345

Gemfile

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -3,8 +3,8 @@
33
source 'https://rubygems.org'
44
git_source(:github) { |repo| "https://github.com/#{repo}.git" }
55

6-
branch = ENV.fetch('SOLIDUS_BRANCH', 'master')
7-
solidus_git, solidus_frontend_git = if (branch == 'master') || (branch >= 'v3.2')
6+
branch = ENV.fetch('SOLIDUS_BRANCH', 'main')
7+
solidus_git, solidus_frontend_git = if (branch == 'main') || (branch >= 'v3.2')
88
%w[solidusio/solidus solidusio/solidus_frontend]
99
else
1010
%w[solidusio/solidus] * 2

app/assets/javascripts/spree/frontend/solidus_importer.js

Lines changed: 0 additions & 2 deletions
This file was deleted.

app/assets/stylesheets/spree/frontend/solidus_importer.css

Lines changed: 0 additions & 4 deletions
This file was deleted.

lib/generators/solidus_importer/install/install_generator.rb

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -11,12 +11,10 @@ def copy_initializer
1111
end
1212

1313
def add_javascripts
14-
append_file 'vendor/assets/javascripts/spree/frontend/all.js', "//= require spree/frontend/solidus_importer\n"
1514
append_file 'vendor/assets/javascripts/spree/backend/all.js', "//= require spree/backend/solidus_importer\n"
1615
end
1716

1817
def add_stylesheets
19-
inject_into_file 'vendor/assets/stylesheets/spree/frontend/all.css', " *= require spree/frontend/solidus_importer\n", before: %r{\*/}, verbose: true # rubocop:disable Layout/LineLength
2018
inject_into_file 'vendor/assets/stylesheets/spree/backend/all.css', " *= require spree/backend/solidus_importer\n", before: %r{\*/}, verbose: true # rubocop:disable Layout/LineLength
2119
end
2220

lib/solidus_importer/processors/taxon.rb

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -42,7 +42,8 @@ def add_taxon(taxon)
4242
def prepare_taxon(name, taxonomy)
4343
Spree::Taxon.find_or_initialize_by(
4444
name: name,
45-
taxonomy_id: taxonomy.id
45+
taxonomy_id: taxonomy.id,
46+
parent: taxonomy.root
4647
)
4748
end
4849

solidus_importer.gemspec

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -29,7 +29,7 @@ Gem::Specification.new do |spec|
2929
spec.executables = files.grep(%r{^exe/}) { |f| File.basename(f) }
3030
spec.require_paths = ["lib"]
3131

32-
spec.add_dependency 'solidus_core', ['>= 2.0.0', '< 4']
32+
spec.add_dependency 'solidus_core', ['>= 2.0.0', '< 5']
3333
spec.add_dependency 'solidus_support', '~> 0.5'
3434

3535
spec.add_development_dependency 'solidus_dev_support', '~> 2.4'

spec/lib/solidus_importer/processors/variant_images_spec.rb

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -32,7 +32,7 @@
3232
let(:context) do
3333
{
3434
data: { 'Variant Image' => 'http://remote-service.net/thinking-cat.jpg' },
35-
variant: build_stubbed(:variant)
35+
variant: create(:variant)
3636
}
3737
end
3838
let(:uri) do

0 commit comments

Comments
 (0)