Deprecate price soft delete #480
Annotations
10 errors and 2 warnings
|
backend/spec/features/admin/products/edit/products_spec.rb#L54
Product Details when default price is deleted does not show the master price
Failure/Error: @search = @product.prices.kept.accessible_by(current_ability, :index).ransack(params[:q])
ActiveSupport::DeprecationException:
DEPRECATION WARNING: `Spree::Price#kept` is deprecated and will be removed in a future version of Solidus. Filter by variant availability via `joins(:variant).merge(Spree::Variant.kept)` instead. (called from Spree::Admin::PricesController#index at /home/runner/work/solidus/solidus/backend/app/controllers/spree/admin/prices_controller.rb:11)
|
|
backend/spec/features/admin/products/pricing_spec.rb#L112
Pricing in the prices tab pagination paginates products and variants independently
Failure/Error: @search = @product.prices.kept.accessible_by(current_ability, :index).ransack(params[:q])
ActiveSupport::DeprecationException:
DEPRECATION WARNING: `Spree::Price#kept` is deprecated and will be removed in a future version of Solidus. Filter by variant availability via `joins(:variant).merge(Spree::Variant.kept)` instead. (called from Spree::Admin::PricesController#index at /home/runner/work/solidus/solidus/backend/app/controllers/spree/admin/prices_controller.rb:11)
|
|
backend/spec/features/admin/products/pricing_spec.rb#L169
Pricing in the prices tab deleting will delete the non-default price
Failure/Error: @search = @product.prices.kept.accessible_by(current_ability, :index).ransack(params[:q])
ActiveSupport::DeprecationException:
DEPRECATION WARNING: `Spree::Price#kept` is deprecated and will be removed in a future version of Solidus. Filter by variant availability via `joins(:variant).merge(Spree::Variant.kept)` instead. (called from Spree::Admin::PricesController#index at /home/runner/work/solidus/solidus/backend/app/controllers/spree/admin/prices_controller.rb:11)
|
|
backend/spec/features/admin/products/pricing_spec.rb#L179
Pricing in the prices tab deleting does not break when default price is deleted
Failure/Error: @search = @product.prices.kept.accessible_by(current_ability, :index).ransack(params[:q])
ActiveSupport::DeprecationException:
DEPRECATION WARNING: `Spree::Price#kept` is deprecated and will be removed in a future version of Solidus. Filter by variant availability via `joins(:variant).merge(Spree::Variant.kept)` instead. (called from Spree::Admin::PricesController#index at /home/runner/work/solidus/solidus/backend/app/controllers/spree/admin/prices_controller.rb:11)
|
|
backend/spec/features/admin/products/pricing_spec.rb#L133
Pricing in the prices tab editing has a working edit page
Failure/Error: @search = @product.prices.kept.accessible_by(current_ability, :index).ransack(params[:q])
ActiveSupport::DeprecationException:
DEPRECATION WARNING: `Spree::Price#kept` is deprecated and will be removed in a future version of Solidus. Filter by variant availability via `joins(:variant).merge(Spree::Variant.kept)` instead. (called from Spree::Admin::PricesController#index at /home/runner/work/solidus/solidus/backend/app/controllers/spree/admin/prices_controller.rb:11)
|
|
backend/spec/features/admin/products/pricing_spec.rb#L151
Pricing in the prices tab editing will not reset the currency to default
Failure/Error: @search = @product.prices.kept.accessible_by(current_ability, :index).ransack(params[:q])
ActiveSupport::DeprecationException:
DEPRECATION WARNING: `Spree::Price#kept` is deprecated and will be removed in a future version of Solidus. Filter by variant availability via `joins(:variant).merge(Spree::Variant.kept)` instead. (called from Spree::Admin::PricesController#index at /home/runner/work/solidus/solidus/backend/app/controllers/spree/admin/prices_controller.rb:11)
|
|
backend/spec/features/admin/products/pricing_spec.rb#L51
Pricing in the prices tab when the user can edit prices shows edit links
Failure/Error: @search = @product.prices.kept.accessible_by(current_ability, :index).ransack(params[:q])
ActiveSupport::DeprecationException:
DEPRECATION WARNING: `Spree::Price#kept` is deprecated and will be removed in a future version of Solidus. Filter by variant availability via `joins(:variant).merge(Spree::Variant.kept)` instead. (called from Spree::Admin::PricesController#index at /home/runner/work/solidus/solidus/backend/app/controllers/spree/admin/prices_controller.rb:11)
|
|
backend/spec/features/admin/products/pricing_spec.rb#L63
Pricing in the prices tab when the user cannot edit prices doesn't show edit links
Failure/Error: @search = @product.prices.kept.accessible_by(current_ability, :index).ransack(params[:q])
ActiveSupport::DeprecationException:
DEPRECATION WARNING: `Spree::Price#kept` is deprecated and will be removed in a future version of Solidus. Filter by variant availability via `joins(:variant).merge(Spree::Variant.kept)` instead. (called from Spree::Admin::PricesController#index at /home/runner/work/solidus/solidus/backend/app/controllers/spree/admin/prices_controller.rb:11)
|
|
backend/spec/features/admin/products/pricing_spec.rb#L78
Pricing in the prices tab searching has a working table filter
Failure/Error: @search = @product.prices.kept.accessible_by(current_ability, :index).ransack(params[:q])
ActiveSupport::DeprecationException:
DEPRECATION WARNING: `Spree::Price#kept` is deprecated and will be removed in a future version of Solidus. Filter by variant availability via `joins(:variant).merge(Spree::Variant.kept)` instead. (called from Spree::Admin::PricesController#index at /home/runner/work/solidus/solidus/backend/app/controllers/spree/admin/prices_controller.rb:11)
|
|
backend/spec/features/admin/products/pricing_spec.rb#L29
Pricing in the prices tab displays a table with the prices
Failure/Error: @search = @product.prices.kept.accessible_by(current_ability, :index).ransack(params[:q])
ActiveSupport::DeprecationException:
DEPRECATION WARNING: `Spree::Price#kept` is deprecated and will be removed in a future version of Solidus. Filter by variant availability via `joins(:variant).merge(Spree::Variant.kept)` instead. (called from Spree::Admin::PricesController#index at /home/runner/work/solidus/solidus/backend/app/controllers/spree/admin/prices_controller.rb:11)
|
|
Node.js 20 actions are deprecated. The following actions are running on Node.js 20 and may not work as expected: actions/cache/restore@v4, actions/checkout@v4. Actions will be forced to run with Node.js 24 by default starting June 2nd, 2026. Please check if updated versions of these actions are available that support Node.js 24. To opt into Node.js 24 now, set the FORCE_JAVASCRIPT_ACTIONS_TO_NODE24=true environment variable on the runner or in your workflow file. Once Node.js 24 becomes the default, you can temporarily opt out by setting ACTIONS_ALLOW_USE_UNSECURE_NODE_VERSION=true. For more information see: https://github.blog/changelog/2025-09-19-deprecation-of-node-20-on-github-actions-runners/
|
|
backend/spec/features/admin/products/edit/taxons_spec.rb#L51
Product Display Order managing display order with an XSS attempt displays the escaped HTML without executing it
Skipped: No reason given
|
The logs for this run have expired and are no longer available.
Loading