Skip to content

Commit 29cbd70

Browse files
Add ignore_expected_loganalyzer_exceptions fixture to test_lldp_entry_table_after_lldp_restart (#25259)
<!-- Please make sure you've read and understood our contributing guidelines; https://github.com/sonic-net/SONiC/blob/gh-pages/CONTRIBUTING.md Please provide following information to help code review process a bit easier: --> ### Description of PR Fixes intermittent teardown failures in `lldp.test_lldp_syncd::test_lldp_entry_table_after_lldp_restart` caused by transient `monit 'routeCheck' status failed` ERR lines in syslog after the LLDP container is restarted. ``` 2026 Jun 9 05:41:07.331542 vlab-03 ERR monit[91284]: 'routeCheck' status failed (255) -- Failure results: {{#12 "": {#12 "Unaccounted_ROUTE_ENTRY_TABLE_entries": [#12 "10.0.0.38/31",#12 "100.1.0.21/32",#12 "192.168.32.0/25",#12 "192.168.32.128/25",#12 "192.217.224.0/25",#12 "20c0:a820:0:80::/64",#12 "20c0:a820::/64",#12 "fc00::4c/126"#12 ]#12 }#12}}#012Failed. Look at reported mismatches above#012add: {#12 "": []#12}#012del: {#12 "": []#12} ``` This is a one-line fix: the test was missing the `ignore_expected_loganalyzer_exceptions` fixture in its signature, so the existing ignore-regex (added in PR #15258) was never installed for this test. Its sibling tests (`test_lldp_entry_table_after_cont_flap`, `test_lldp_entry_table_after_all_batched_flap`) already declare the same fixture and pass cleanly. <!-- - Please include a summary of the change and which issue is fixed. - Please also include relevant motivation and context. Where should reviewer start? background context? - List any dependencies that are required for this change. --> Summary: Fixes # (issue) ### Type of change <!-- - Fill x for your type of change. - e.g. - [x] Bug fix --> - [x] Bug fix - [ ] Testbed and Framework(new/improvement) - [ ] New Test case - [ ] Skipped for non-supported platforms - [ ] Test case improvement ### Back port request - [ ] 202311 - [ ] 202405 - [ ] 202411 - [ ] 202505 - [ ] 202511 - [ ] 202512 - [ ] 202605 ### Approach #### What is the motivation for this PR? `test_lldp_entry_table_after_lldp_restart` has been flaking at ~12% on `vlab-03` for weeks. The test body itself passes — the failure happens at teardown when loganalyzer flags an `ERRmonit[...]: 'routeCheck' status failed` line that is emitted momentarily while LLDP is being restarted (`systemctl restart lldp`). Routes briefly fail their consistency check while LLDPrepopulates neighbor info, then recover on the next monit poll. #### How did you do it? #### How did you verify/test it? #### Any platform specific information? N/a #### Supported testbed topology if it's a new test case? N/a ### Documentation N/a Signed-off-by: sakshamkhurana <sakkhurana@microsoft.com>
1 parent 64e9d89 commit 29cbd70

1 file changed

Lines changed: 1 addition & 1 deletion

File tree

tests/lldp/test_lldp_syncd.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -537,7 +537,7 @@ def test_lldp_entry_table_after_all_batched_flap(
537537

538538
# Test case 5: Verify LLDP_ENTRY_TABLE after system reboot
539539
def test_lldp_entry_table_after_lldp_restart(
540-
duthosts, enum_rand_one_per_hwsku_frontend_hostname, db_instance
540+
duthosts, enum_rand_one_per_hwsku_frontend_hostname, db_instance, ignore_expected_loganalyzer_exceptions,
541541
):
542542
duthost = duthosts[enum_rand_one_per_hwsku_frontend_hostname]
543543
lldp_entry_keys, show_lldp_table_int_list, lldpctl_output = get_lldp_data(duthost, db_instance)

0 commit comments

Comments
 (0)