Skip to content

feat: migrate firefox to resource API#49

Merged
damacus merged 4 commits intomainfrom
full-custom-resource-migration-firefox
Apr 25, 2026
Merged

feat: migrate firefox to resource API#49
damacus merged 4 commits intomainfrom
full-custom-resource-migration-firefox

Conversation

@damacus
Copy link
Copy Markdown
Member

@damacus damacus commented Apr 25, 2026

Summary

  • migrate cookbook usage from top-level recipes/attributes to the firefox_install custom resource API
  • add migration, limitations, and resource documentation
  • modernize CI/Kitchen platforms and use the Sous Chefs shared Cinc Workstation installer

Verification

  • berks install
  • cookstyle
  • chef exec rspec --format documentation
  • yamllint .
  • markdownlint-cli2 '**/*.md'
  • KITCHEN_LOCAL_YAML=kitchen.dokken.yml kitchen list
  • KITCHEN_LOCAL_YAML=kitchen.dokken.yml kitchen test --destroy=always, with post-fix reruns for affected suites

@damacus damacus requested a review from a team as a code owner April 25, 2026 08:10
@github-actions
Copy link
Copy Markdown

github-actions Bot commented Apr 25, 2026

Slowest examples

Top 10 slowest examples (0.41 seconds, 83.42% of total time)
Example Description Time in seconds
spec/default_spec.rb:30 firefox_install with version specified on Ubuntu is expected to install package "firefox" 0.12676
spec/default_spec.rb:43 firefox_install with upgrade action specified on Ubuntu is expected to upgrade package "firefox" 0.04425
spec/default_spec.rb:15 firefox_install with default settings on Ubuntu is expected to add apt_repository "mozilla" 0.04374
spec/default_spec.rb:18 firefox_install with default settings on Ubuntu is expected to install package "firefox" 0.03704
spec/default_spec.rb:77 firefox_install with default settings on openSUSE is expected not to add zypper_repository "mozilla" 0.02978
spec/default_spec.rb:78 firefox_install with default settings on openSUSE is expected to install package "firefox" 0.02847
spec/default_spec.rb:101 firefox_install with version specified on Windows is expected to install windows_package "Mozilla Firefox 140.0.2 (x86_64 fr)" 0.02714
spec/default_spec.rb:17 firefox_install with default settings on Ubuntu is expected to nothing apt_update "mozilla" 0.02695
spec/default_spec.rb:16 firefox_install with default settings on Ubuntu is expected to create file "/etc/apt/preferences.d/mozilla" 0.02629
spec/default_spec.rb:66 firefox_install with default settings on RHEL is expected not to create yum_repository "mozilla" 0.02523

@damacus damacus merged commit f8849e2 into main Apr 25, 2026
25 checks passed
@damacus damacus deleted the full-custom-resource-migration-firefox branch April 25, 2026 21:20
@kitchen-porter kitchen-porter mentioned this pull request Apr 25, 2026
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@damacus