Skip to content

Changeling voice mimicry#43675

Open
ketufaispikinut wants to merge 34 commits intospace-wizards:masterfrom
ketufaispikinut:ling_voice
Open

Changeling voice mimicry#43675
ketufaispikinut wants to merge 34 commits intospace-wizards:masterfrom
ketufaispikinut:ling_voice

Conversation

@ketufaispikinut
Copy link
Copy Markdown
Contributor

@ketufaispikinut ketufaispikinut commented Apr 21, 2026 •
edited by ScarKy0
Loading

About the PR

Gives a buyable voice mask ability to the changeling. When bought it starts disabled (as to not immediately run first-time changeling's runs). Unlike the normal voice mask, it only overrides your voice (shift+clicking reveals you and currently makes you unambiguously a changeling if you don't have anything that could mask your identity).

I made the texture.
Capture d’écran, le 2026-04-21 à 08 32 03

Why / Balance

Working towards #39439

Technical details

Gave an IsInnate field to the VoiceMaskComponent and made it not work as an implant but as an innate ability when this field is set to true. Besides that it's just yaml changes. The VoiceMaskComponent also gets a new TitleText that allows it to set the name of its UI window.

Media

Capture d’écran, le 2026-04-21 à 08 16 42 Capture d’écran, le 2026-04-21 à 08 16 24 (Note that the UI's title is now set to a more fitting "Voice Mimicry". This does not affect the normal UI, tough.)

Requirements

Breaking changes

ImplantRelayEvent.Event has been renamed to ImplantRelayEvent.Args

Changelog

🆑

  • tweak: The voice mask and identity implant now start disabled.

@PJBot PJBot added S: Untriaged Status: Indicates an item has not been triaged and doesn't have appropriate labels. Changes: Sprites Changes: Might require knowledge of spriting or visual design. S: Needs Review Status: Requires additional reviews before being fully accepted. Not to be replaced by S: Approved. Changes: UI Changes: Might require knowledge of UI design or code. size/M Denotes a PR that changes 100-999 lines. labels Apr 21, 2026
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Apr 21, 2026 •
edited
Loading

RSI Diff Bot; head commit 294f252 merging into 63b6923
This PR makes changes to 1 or more RSIs. Here is a summary of all changes:

Resources/Textures/Interface/Actions/changeling2.rsi

State Old New Status
mimicry Added

Edit: diff updated after 294f252

ScarKy0
ScarKy0 requested changes Apr 21, 2026
View reviewed changes
Copy link
Copy Markdown
Contributor

@ScarKy0 ScarKy0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Woe a fuckton of newlines upon ye

Comment thread Content.Server/VoiceMask/VoiceMaskSystem.cs
Comment thread Content.Server/VoiceMask/VoiceMaskSystem.cs Outdated
Comment thread Content.Server/VoiceMask/VoiceMaskSystem.cs Outdated
Comment thread Content.Server/VoiceMask/VoiceMaskSystem.cs Outdated
Comment thread Content.Server/VoiceMask/VoiceMaskSystem.cs Outdated
Comment thread Content.Shared/VoiceMask/VoiceMaskComponent.cs Outdated
Comment thread Resources/Locale/en-US/store/changeling-catalog.ftl Outdated
Comment thread Resources/Prototypes/Actions/changeling.yml Outdated
Comment thread Resources/Prototypes/Entities/Mobs/Player/changeling.yml
Comment thread Resources/Textures/Interface/Actions/changeling2.rsi/meta.json Outdated
@PJBot PJBot added S: Awaiting Changes Status: Changes are required before another review can happen and removed S: Needs Review Status: Requires additional reviews before being fully accepted. Not to be replaced by S: Approved. labels Apr 21, 2026
ketufaispikinut and others added 9 commits April 21, 2026 09:01
@ketufaispikinut @ScarKy0
Update Resources/Textures/Interface/Actions/changeling2.rsi/meta.json
12e8a50 
Co-authored-by: ScarKy0 <106310278+ScarKy0@users.noreply.github.com>
@ketufaispikinut @ScarKy0
Update Content.Server/VoiceMask/VoiceMaskSystem.cs
22d5839 
Co-authored-by: ScarKy0 <106310278+ScarKy0@users.noreply.github.com>
@ketufaispikinut @ScarKy0
Update Content.Server/VoiceMask/VoiceMaskSystem.cs
62d7c57 
Co-authored-by: ScarKy0 <106310278+ScarKy0@users.noreply.github.com>
@ketufaispikinut @ScarKy0
Update Content.Server/VoiceMask/VoiceMaskSystem.cs
a5f82b9 
Co-authored-by: ScarKy0 <106310278+ScarKy0@users.noreply.github.com>
@ketufaispikinut @ScarKy0
Update Content.Server/VoiceMask/VoiceMaskSystem.cs
c18458e 
Co-authored-by: ScarKy0 <106310278+ScarKy0@users.noreply.github.com>
@ketufaispikinut @ScarKy0
Apply suggestions from code review
8b9f2cb 
oh god you can just do batches oh my god

Co-authored-by: ScarKy0 <106310278+ScarKy0@users.noreply.github.com>
@ketufaispikinut
Update changeling-catalog.ftl
0c8cc18 
new line at EOF
@ketufaispikinut
Update changeling.yml
ed9192a 
same
@ketufaispikinut
Update changeling.yml
d32d48c 
line
ThanosDeGraf
ThanosDeGraf approved these changes Apr 21, 2026
View reviewed changes
Copy link
Copy Markdown
Contributor

@ThanosDeGraf ThanosDeGraf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm so lonely... please help me...

Sickass feature! Nice work also in expanding the voice changer Ui so the title changes to Voice Mimicry, remaining in-theme.

Tested this out in-game, all the toggles work as expected and do start out as Off when buying the ability. Just some small nitpicks but otherwise LGTM

Comment thread Content.Server/Store/Systems/StoreSystem.Ui.cs
Comment thread Content.Server/Store/Systems/StoreSystem.Ui.cs
@ThanosDeGraf
Copy link
Copy Markdown
Contributor

ThanosDeGraf commented Apr 21, 2026

oh hi there @ScarKy0 <3 o/

ScarKy0
ScarKy0 requested changes Apr 21, 2026
View reviewed changes
Comment thread Content.Client/VoiceMask/VoiceMaskNameChangeWindow.xaml.cs
Comment thread Content.Server/VoiceMask/VoiceMaskSystem.cs
Comment thread Content.Shared/VoiceMask/VoiceMaskComponent.cs
Comment thread Resources/Prototypes/Catalog/changeling_catalog.yml Outdated
Comment thread Resources/Prototypes/Entities/Mobs/Player/changeling.yml Outdated
@PJBot PJBot added S: Needs Review Status: Requires additional reviews before being fully accepted. Not to be replaced by S: Approved. and removed S: Awaiting Changes Status: Changes are required before another review can happen labels Apr 22, 2026
beck-thompson
beck-thompson requested changes Apr 23, 2026
View reviewed changes
Copy link
Copy Markdown
Member

@beck-thompson beck-thompson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Style issues

Comment thread Content.Server/VoiceMask/VoiceMaskSystem.cs Outdated
Comment thread Content.Server/VoiceMask/VoiceMaskSystem.cs
Comment thread Content.Server/VoiceMask/VoiceMaskSystem.cs Outdated
Comment thread Content.Server/VoiceMask/VoiceMaskSystem.cs
Comment thread Content.Server/VoiceMask/VoiceMaskSystem.cs
Comment thread Content.Shared/VoiceMask/VoiceMaskComponent.cs
Comment thread Resources/Locale/en-US/changeling/changeling.ftl Outdated
Comment thread Content.Server/VoiceMask/VoiceMaskSystem.cs
Comment thread Content.Server/VoiceMask/VoiceMaskSystem.cs Outdated
Comment thread Content.Server/VoiceMask/VoiceMaskSystem.cs Outdated
@PJBot PJBot added S: Awaiting Changes Status: Changes are required before another review can happen and removed S: Needs Review Status: Requires additional reviews before being fully accepted. Not to be replaced by S: Approved. labels Apr 23, 2026
@Pok27 Pok27 added P3: Standard Priority: Default priority for repository items. T: New Feature Type: New feature or content, or extending existing content D3: Low Difficulty: Some codebase knowledge required. A: Roundflow/Antag Area: Roundflow - "What happens in the game", including antagonist roles and their capabilities P2: Raised Priority: Item has a raised priority, indicating it might get increased maintainer attention. and removed S: Untriaged Status: Indicates an item has not been triaged and doesn't have appropriate labels. P3: Standard Priority: Default priority for repository items. labels Apr 23, 2026
@ketufaispikinut
Copy link
Copy Markdown
Contributor Author

ketufaispikinut commented Apr 23, 2026

There we go, reverted the text changes to only the title, added newlines, removed comments, changed comments, indented things. Fixed lies!

beck-thompson
beck-thompson approved these changes Apr 23, 2026
View reviewed changes
Copy link
Copy Markdown
Member

@beck-thompson beck-thompson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fun!!

@beck-thompson beck-thompson removed the S: Awaiting Changes Status: Changes are required before another review can happen label Apr 23, 2026
ScarKy0
ScarKy0 approved these changes Apr 23, 2026
View reviewed changes
Copy link
Copy Markdown
Contributor

@ScarKy0 ScarKy0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i HATE changleings i HATE antagonists i HATE our players because they LOVE changelins and i HATE changelings

@Emisse Emisse added the S: Art Approval Status: The art (e.g. Spritework) has been approved by an art lead. label Apr 23, 2026
nomdéraisonnablementlong added 3 commits April 25, 2026 09:54
@ketufaispikinut
Copy link
Copy Markdown
Contributor Author

ketufaispikinut commented Apr 25, 2026

I renamed a field from .event to .args.

I hope this isn't a problem ,_,.

@ketufaispikinut
Copy link
Copy Markdown
Contributor Author

ketufaispikinut commented Apr 25, 2026

My change to ImplantRelayEvent may warrant a breaking change notice.
I don't know, really.

@ScarKy0 ScarKy0 enabled auto-merge April 26, 2026 09:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ScarKy0 ScarKy0 ScarKy0 approved these changes

@beck-thompson beck-thompson beck-thompson approved these changes

@DrSmugleaf DrSmugleaf Awaiting requested review from DrSmugleaf DrSmugleaf is a code owner

+1 more reviewer

@ThanosDeGraf ThanosDeGraf ThanosDeGraf approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

A: Roundflow/Antag Area: Roundflow - "What happens in the game", including antagonist roles and their capabilities Changes: Sprites Changes: Might require knowledge of spriting or visual design. Changes: UI Changes: Might require knowledge of UI design or code. D3: Low Difficulty: Some codebase knowledge required. P2: Raised Priority: Item has a raised priority, indicating it might get increased maintainer attention. S: Approved Status: Reviewed and approved by at least one maintainer; a PR may require another approval. S: Art Approval Status: The art (e.g. Spritework) has been approved by an art lead. size/M Denotes a PR that changes 100-999 lines. T: New Feature Type: New feature or content, or extending existing content

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

8 participants

@ketufaispikinut @ThanosDeGraf @Huaqas @ScarKy0 @beck-thompson @PJBot @Emisse @Pok27