Skip to content

Commit ea370f8

Browse files
CLeanup
1 parent 8f83161 commit ea370f8

1 file changed

Lines changed: 0 additions & 19 deletions

File tree

src/Flare.php

Lines changed: 0 additions & 19 deletions
Original file line numberDiff line numberDiff line change
@@ -34,25 +34,6 @@
3434

3535
class Flare
3636
{
37-
// TODO: quick tests on Vapor
38-
// TODO: check the tester for handling errors + try to move some parts of the laravel command to the main repo
39-
// TODO: solidify trace pausing
40-
// https://app.bugsnag.com/spatie/flareapp-dot-io/errors/69ddf4881ff884595fecd67e?filters[error.status]=open&filters[event.since]=1d
41-
42-
// TODO next week:
43-
// - Finalize Laravel package changes: check all recorders and attribute providers + middleware, especially request then TESTINg TESTIN TESTING
44-
// In de middleware doen we rare dingen, idealiter doen we ook de gehele resolve van attributes op het einde van't request zodat onze dynamic sampling snel kan draaien
45-
46-
// TODO: test this on vapor:
47-
// 1) Create a job with error
48-
// 2) We do all tracing correctly and store some breadcrumbs
49-
// 3) The subtask ends, so the error is sent
50-
// 4) We're now in limbo
51-
// 5) Error handling happens and a report is stored within the API
52-
// 6) The shutdown function probably won't run, lifecycle won't flush the latest data
53-
// 7) Our error is lost
54-
// Also test tracing and exceptions on regular requests and jobs
55-
5637
public function __construct(
5738
public readonly Lifecycle $lifecycle,
5839
public readonly Tracer $tracer,

0 commit comments

Comments
 (0)