Replies: 2 comments
-
|
PR to show how this could look like: #1957 |
Beta Was this translation helpful? Give feedback.
0 replies
-
|
Thank you for contributing this work! I think we can close this discussion now as CI now includes this. |
Beta Was this translation helpful? Give feedback.
0 replies
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Uh oh!
There was an error while loading. Please reload this page.
-
Consistent formatting is important to avoid unnecessary conflicts and keep a consistent style in a shared codebase. Contribution guidelines thus kindly ask to run
yapfbefore/when submitting a PR. However, consistent formatting isn't enforced in GHA workflows.Given that two small PRs 1 2 showed formatting changes in code parts that I didn't touch, I would like to start a discussion on automatically enforcing consistent formatting as part of the GitHub Actions workflow.
I am happy to provide a PR for such a workflow early next year assuming we come to an agreement in this discussion.
Footnotes
https://github.com/spcl/dace/pull/1731 ↩
https://github.com/spcl/dace/pull/1803 ↩
Beta Was this translation helpful? Give feedback.
All reactions