The recent refactoring of dace.data generated some inconsistencies.
- While
find_new_name() was moved into dace.utils almost all parts of the code still refers to the dace.data.find_new_name() alias, which is provided for backwards compatibility.
- The
Data class provides the strides_from_layout method which allows to compute strides based on a shape, which is kind of okay since it does not mutate any values and only reads the shape, despite the fact that Data does not have a concept of strides (it does not have a strides property only the Array has something like that). However, it also has the set_strides_from_layout function which creates a strides attribute on the object. However, with the exception of the Array this property is not serialized. Therefore, this method does not belong to Data and should be moved to Array the only logical place.
The recent refactoring of
dace.datagenerated some inconsistencies.find_new_name()was moved intodace.utilsalmost all parts of the code still refers to thedace.data.find_new_name()alias, which is provided for backwards compatibility.Dataclass provides thestrides_from_layoutmethod which allows to compute strides based on a shape, which is kind of okay since it does not mutate any values and only reads the shape, despite the fact thatDatadoes not have a concept of strides (it does not have astridesproperty only theArrayhas something like that). However, it also has theset_strides_from_layoutfunction which creates astridesattribute on the object. However, with the exception of theArraythis property is not serialized. Therefore, this method does not belong toDataand should be moved toArraythe only logical place.