Lint

Author: krinart

go/database_test.go

@@ -24,12 +24,12 @@ import (
 
 func TestParseURIForStaging(t *testing.T) {
 	tests := []struct {
-		name         string
-		uri          string
-		wantHost     string
-		wantPort     int
-		wantToken    string
-		wantErr      bool
+		name      string
+		uri       string
+		wantHost  string
+		wantPort  int
+		wantToken string
+		wantErr   bool
 	}{
 		{
 			name:      "standard URI with token",
@@ -89,7 +89,7 @@ func TestStagingOptionsWithURI(t *testing.T) {
 
 	// Staging options should be allowed alongside URI
 	err := d.SetOptions(map[string]string{
-		adbc.OptionKeyURI: "databricks://token:mytoken@host.com:443/path",
+		adbc.OptionKeyURI:       "databricks://token:mytoken@host.com:443/path",
 		OptionStagingVolumePath: "cat.sch.vol",
 		OptionStagingPrefix:     "my_prefix",
 	})

go/staging_client.go

@@ -92,7 +92,7 @@ func (c *stagingClient) uploadToURL(ctx context.Context, url string, data io.Rea
 	if err != nil {
 		return fmt.Errorf("upload request failed: %w", err)
 	}
-	defer resp.Body.Close()
+	defer func() { _ = resp.Body.Close() }()
 
 	if resp.StatusCode < 200 || resp.StatusCode >= 300 {
 		body, _ := io.ReadAll(resp.Body)
@@ -119,7 +119,7 @@ func (c *stagingClient) deleteFromURL(ctx context.Context, url string) error {
 	if err != nil {
 		return fmt.Errorf("delete request failed: %w", err)
 	}
-	defer resp.Body.Close()
+	defer func() { _ = resp.Body.Close() }()
 
 	if resp.StatusCode < 200 || resp.StatusCode >= 300 {
 		body, _ := io.ReadAll(resp.Body)

go/staging_client_test.go

@@ -179,7 +179,7 @@ func TestUpload(t *testing.T) {
 
 		resp, err := c.httpClient.Do(req)
 		require.NoError(t, err)
-		defer resp.Body.Close()
+		defer func() { _ = resp.Body.Close() }()
 
 		assert.Equal(t, http.StatusOK, resp.StatusCode)
 		assert.Equal(t, http.MethodPut, receivedMethod)
@@ -192,7 +192,7 @@ func TestUpload(t *testing.T) {
 	t.Run("upload failure", func(t *testing.T) {
 		server := httptest.NewTLSServer(http.HandlerFunc(func(w http.ResponseWriter, r *http.Request) {
 			w.WriteHeader(http.StatusForbidden)
-			w.Write([]byte(`{"error": "access denied"}`))
+			_, _ = w.Write([]byte(`{"error": "access denied"}`))
 		}))
 		defer server.Close()
 
@@ -236,7 +236,7 @@ func TestDelete(t *testing.T) {
 	t.Run("delete failure", func(t *testing.T) {
 		server := httptest.NewTLSServer(http.HandlerFunc(func(w http.ResponseWriter, r *http.Request) {
 			w.WriteHeader(http.StatusNotFound)
-			w.Write([]byte(`{"error": "not found"}`))
+			_, _ = w.Write([]byte(`{"error": "not found"}`))
 		}))
 		defer server.Close()
 

go/statement.go

@@ -196,15 +196,15 @@ func (s *statementImpl) executeBulkIngest(ctx context.Context) (int64, error) {
 		options:       &s.bulkIngestOptions,
 	}
 
-	alloc := s.conn.ConnectionImplBase.Alloc
+	alloc := s.conn.Alloc
 	if alloc == nil {
 		alloc = memory.DefaultAllocator
 	}
 
 	mgr := &driverbase.BulkIngestManager{
 		Impl:        impl,
 		ErrorHelper: &s.ErrorHelper,
-		Logger:      s.conn.ConnectionImplBase.Logger,
+		Logger:      s.conn.Logger,
 		Alloc:       alloc,
 		Ctx:         ctx,
 		Options:     s.bulkIngestOptions,