Skip to content

Commit 5406346

Browse files
committed
fix(stdlib): let a theme's own context-menu colour win
1 parent cb3578a commit 5406346

2 files changed

Lines changed: 9 additions & 3 deletions

File tree

modules/stdlib/index.scss

Lines changed: 8 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -64,10 +64,16 @@
6464
menuItemButton` colour, so the navigating half of a menu is painted by
6565
whatever that fallback resolves to and the acting half by the item colour.
6666
Give both the theme's text colour, at the fallback's specificity so the
67-
client's own hover, disabled and checked-item colours still win. */
67+
client's own hover, disabled and checked-item colours still win.
68+
69+
The chain resolves a theme's own menu colour first: this rule outranks the
70+
plain `.main-contextMenu-menuItemButton` a theme would set, so reading its
71+
variable is what keeps that choice from being overwritten. Falling all the
72+
way through to --text-base covers having no theme at all, where no
73+
--spice-* is defined. */
6874
a.main-contextMenu-menuItemButton,
6975
button.main-contextMenu-menuItemButton {
70-
color: var(--spice-text, var(--text-base));
76+
color: var(--spice-context-menu-text, var(--spice-text, var(--text-base)));
7177
}
7278

7379
/* stdlib search bar (lib/components useSearchBar): sensible everywhere,

modules/stdlib/metadata.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,7 @@
33
"tags": ["lib"],
44
"hidden": true,
55
"preview": "./assets/PREVIEW.png",
6-
"version": "1.4.2",
6+
"version": "1.4.3",
77
"compat": ["0.3.0"],
88
"authors": ["spicetify", "Delusoire"],
99
"description": "The standard library",

0 commit comments

Comments
 (0)