fix: Adapt to changes in Spring Data Commons 4.1

At the beginning of the investigation I thought the annotation of `SomeOtherClass` was the root case of the failure. While it caused the test failure—as it doesn't have an id property in fact—, it should not have been loaded at all: It is use as part of a transiently marked `List<>` property and Spring Data Commons 4.1 change a bit in that area and does add transient associations now (which I think it should not…). I fixed that with overriding the corresponding method and also removed the (superfluous) `@Node` annotation).

Author: michael-simons

src/main/java/org/springframework/data/neo4j/core/mapping/DefaultNeo4jPersistentEntity.java

@@ -136,7 +136,7 @@ private List<Class<?>> computeAggregateBoundaries() {
 	/**
 	 * The primary label will get computed and returned by following rules:<br>
 	 * 1. If there is no {@link Node} annotation, use the class name.<br>
-	 * 2. If there is an annotation but it has no properties set, use the class name.<br>
+	 * 2. If there is an annotation, but it has no properties set, use the class name.<br>
 	 * 3. If only {@link Node#labels()} property is set, use the first one as the primary
 	 * label 4. If the {@link Node#primaryLabel()} property is set, use this as the
 	 * primary label
@@ -157,6 +157,14 @@ else if (StringUtils.hasText(nodeAnnotation.primaryLabel())) {
 		}
 	}
 
+	@Override
+	public void addAssociation(Association<Neo4jPersistentProperty> association) {
+		if (association.getInverse().isTransient()) {
+			return;
+		}
+		super.addAssociation(association);
+	}
+
 	/**
 	 * Checks if an entity is explicitly annotated.
 	 * @param entity the entity to check for annotation

src/main/java/org/springframework/data/neo4j/core/mapping/DefaultNeo4jPersistentProperty.java

@@ -141,7 +141,7 @@ static String deriveRelationshipType(String name) {
 				}
 				codePoint = Character.toUpperCase(codePoint);
 			}
-			else if (sb.length() > 0) {
+			else if (!sb.isEmpty()) {
 				sb.append("_");
 			}
 			sb.append(Character.toChars(codePoint));

src/test/java/org/springframework/data/neo4j/core/mapping/Neo4jMappingContextTests.java

@@ -259,14 +259,15 @@ void complexPropertyWithoutConverterShouldBeConsideredAsAssociation() {
 	void shouldHonourTransientAnnotation() {
 
 		Neo4jMappingContext schema = new Neo4jMappingContext();
-		Neo4jPersistentEntity<?> userNodeEntity = schema.getPersistentEntity(UserNode.class);
+		Neo4jPersistentEntity<?> userNodeEntity = schema.getRequiredPersistentEntity(UserNode.class);
 
+		assertThat(userNodeEntity.getTransientProperty("someOtherTransientThings")).isNotNull();
+		assertThat(userNodeEntity.getTransientProperty("anAnnotatedTransientProperty")).isNotNull();
 		assertThat(userNodeEntity.getPersistentProperty("anAnnotatedTransientProperty")).isNull();
 
 		List<String> associations = new ArrayList<>();
-		userNodeEntity.doWithAssociations((Association<Neo4jPersistentProperty> a) -> {
-			associations.add(a.getInverse().getFieldName());
-		});
+		userNodeEntity.doWithAssociations(
+				(Association<Neo4jPersistentProperty> a) -> associations.add(a.getInverse().getFieldName()));
 
 		assertThat(associations).containsOnly("bikes", "theSuperBike");
 	}
@@ -806,7 +807,6 @@ static class UserNode {
 
 	}
 
-	@Node
 	static class SomeOtherClass {
 
 	}