Skip to content

Commit 2eb6906

Browse files
committed
fix: finish full bounded GLM review
1 parent 4e2ae8e commit 2eb6906

4 files changed

Lines changed: 6 additions & 6 deletions

File tree

.github/workflows/pi-runtime-review.lock.yml

Lines changed: 3 additions & 3 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

.github/workflows/pi-runtime-review.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -25,7 +25,7 @@ engine:
2525
env:
2626
OPENAI_BASE_URL: https://api.z.ai/api/coding/paas/v4
2727
strict: true
28-
max-turns: 32
28+
max-turns: 40
2929
max-ai-credits: 100
3030
timeout-minutes: 30
3131
network:

docs/superpowers/specs/2026-07-22-pi-081-lockstep-rewrite-design.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -224,7 +224,7 @@ Any `extensions/**` change starts a separate read-only gh-aw review using:
224224
- repository secret `OPENAI_API_KEY` containing the personal Z.AI Coding Plan key, as required by gh-aw's universal OpenCode provider contract;
225225
- network access limited to required GitHub/AWF and `api.z.ai` endpoints.
226226

227-
OpenCode is used because Z.AI lists it as a supported Coding Plan tool. The Coding Plan key is not routed through Copilot CLI. Pinned gh-aw `0.82.14` incorrectly emits its Copilot proxy as OpenCode's default provider even when `openai/glm-5.2` is selected; the deterministic post-compile patch rewrites both generated OpenCode configs to `awf-proxy/glm-5.2` on the OpenAI proxy, and an invariant test rejects any Copilot fallback. Remove this workaround only after a pinned gh-aw upgrade proves the generated provider correct. The review allows at most 32 LLM invocations because OpenCode spends one invocation generating a title and the full lockstep review empirically required more than 16 bounded follow-up invocations after read-only tool calls; the independent `$1` AI-credit cap remains the harder cost bound. The generated OpenCode provider configuration must demonstrably forward `reasoning_effort: xhigh`; silent fallback to a default effort fails preflight. A strict compilation and live tool/structured-output smoke test must pass before auto-merge is enabled.
227+
OpenCode is used because Z.AI lists it as a supported Coding Plan tool. The Coding Plan key is not routed through Copilot CLI. Pinned gh-aw `0.82.14` incorrectly emits its Copilot proxy as OpenCode's default provider even when `openai/glm-5.2` is selected; the deterministic post-compile patch rewrites both generated OpenCode configs to `awf-proxy/glm-5.2` on the OpenAI proxy, and an invariant test rejects any Copilot fallback. Remove this workaround only after a pinned gh-aw upgrade proves the generated provider correct. The review allows at most 40 LLM invocations because OpenCode spends one invocation generating a title and the full lockstep review empirically exhausted 32 bounded follow-up invocations while inspecting the large rewrite; the independent `$1` AI-credit cap remains the harder cost bound. The generated OpenCode provider configuration must demonstrably forward `reasoning_effort: xhigh`; silent fallback to a default effort fails preflight. A strict compilation and live tool/structured-output smoke test must pass before auto-merge is enabled.
228228

229229
The reviewer sees the contract, diff, test changes, and CI evidence. It cannot edit, push, approve with a GitHub identity, or access the App key. It emits a strict verdict and findings. Rejection, malformed output, quota exhaustion, or unavailability blocks auto-merge and escalates.
230230

tests/workflows/invariants.test.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -49,7 +49,7 @@ describe("Pi lockstep agentic workflows", () => {
4949
expect(source).toContain('version: "1.2.14"');
5050
expect(source).toContain('input: "1.1268e-06"');
5151
expect(source).toContain('output: "3.9438e-06"');
52-
expect(source).toContain("max-turns: 32");
52+
expect(source).toContain("max-turns: 40");
5353
expect(source).toContain("max-ai-credits: 100");
5454
expect(source).toContain("https://api.z.ai/api/coding/paas/v4");
5555
expect(source).toContain("OPENAI_BASE_URL");

0 commit comments

Comments
 (0)