Scrub process references from deploy-lifecycle code comments

Removes internal spec-section references (§5.4, 8.x, 9.x, 12.x), PR/round/finding
markers (PR #269, Post-F4/F6, F1/F2), plan-phase labels (Stage 5/6), and
test-doc severity prefixes from comments and user-facing strings in the files
this branch touches. The explanatory content is preserved verbatim — only the
process reference is dropped and the surrounding sentence re-flowed. Comments now
describe what the code does, not which spec section or review round produced it.

Two deliberate survivors: the raw-push error string points at the real design
doc's §3.2.1 (a user-facing pointer, and asserted by tests), so it and its test
assertions are left intact.

Author: aram356

crates/edgezero-adapter-axum/src/cli.rs

@@ -137,7 +137,7 @@ impl Adapter for AxumCliAdapter {
         match action {
             // The axum adapter is the in-process native dev server —
             // there is no remote auth provider to sign in/out of.
-            // Per spec this is an explicit no-op.
+            // This is an explicit no-op.
             AdapterAction::AuthLogin | AdapterAction::AuthLogout | AdapterAction::AuthStatus => {
                 log::info!(
                     "[edgezero] axum has no remote auth surface; `auth` is a no-op for this adapter"
@@ -147,12 +147,12 @@ impl Adapter for AxumCliAdapter {
             AdapterAction::Build => build(args),
             AdapterAction::Deploy => deploy(args),
             AdapterAction::Serve => serve(args),
-            // The Fastly staging lifecycle (spec §5.4) is Fastly-only.
+            // The Fastly staging lifecycle is Fastly-only.
             AdapterAction::DeployStaged
             | AdapterAction::EmitVersion
             | AdapterAction::Healthcheck
             | AdapterAction::Rollback => Err(format!(
-                "axum adapter does not support the Fastly staging lifecycle action {action:?} (spec §5.4)"
+                "axum adapter does not support the Fastly staging lifecycle action {action:?}"
             )),
             other => Err(format!("axum adapter does not support {other:?}")),
         }
@@ -191,7 +191,7 @@ impl Adapter for AxumCliAdapter {
             // Axum reads `.edgezero/local-config-<logical>.json`.
             // The platform name is informational here -- the env
             // overlay isn't used for local file paths because the
-            // path encoding is the spec's canonical form.
+            // path encoding is the canonical form.
             let logical = store.logical.as_str();
             out.push(format!(
                 "axum config store `{logical}` reads `.edgezero/local-config-{logical}.json`; nothing to provision"
@@ -223,7 +223,7 @@ impl Adapter for AxumCliAdapter {
         // `string -> string` JSON object `AxumConfigStore` reads
         // back from `.edgezero/local-config-<id>.json`. The path
         // is keyed on the LOGICAL id, not the env-resolved
-        // platform name -- the local file flow is the spec's
+        // platform name -- the local file flow is the
         // canonical form and isn't subject to the per-store env
         // overlay (which targets platform store names, not local
         // file paths).
@@ -241,8 +241,8 @@ impl Adapter for AxumCliAdapter {
             .map_err(|err| format!("failed to create {}: {err}", local_dir.display()))?;
         // Upsert into any existing map so a `config push --key
         // app_config_staging` doesn't wipe a previously-pushed
-        // `app_config` blob (spec 12.7 requires default + staging
-        // to coexist for the `EDGEZERO__STORES__CONFIG__APP_CONFIG__KEY`
+        // `app_config` blob (default + staging must coexist
+        // for the `EDGEZERO__STORES__CONFIG__APP_CONFIG__KEY`
         // override to switch between them). The map is owned (rather
         // than borrowed) so we can merge old + new without lifetime
         // surgery on the slice.
@@ -598,7 +598,7 @@ fn find_axum_manifest(start: &Path) -> Result<PathBuf, String> {
 }
 
 fn read_axum_project(manifest: &Path) -> Result<AxumProject, String> {
-    // Per the spec hard-cutoff: only the canonical
+    // Per the hard-cutoff: only the canonical
     // `EDGEZERO__ADAPTER__HOST` / `EDGEZERO__ADAPTER__PORT` env
     // vars are honoured. The pre-rewrite `EDGEZERO_HOST` /
     // `EDGEZERO_PORT` shim is gone -- the core runtime stopped
@@ -1415,7 +1415,7 @@ mod tests {
         }
     }
 
-    /// Spec 12.7: pushing two blobs under different keys (e.g.
+    /// Pushing two blobs under different keys (e.g.
     /// `app_config` + `app_config_staging`) must leave both keys
     /// readable so the runtime
     /// `EDGEZERO__STORES__CONFIG__APP_CONFIG__KEY` override can

crates/edgezero-adapter-cloudflare/src/cli.rs

@@ -156,12 +156,12 @@ impl Adapter for CloudflareCliAdapter {
             }),
             AdapterAction::Deploy => deploy(args),
             AdapterAction::Serve => serve(args),
-            // The Fastly staging lifecycle (spec §5.4) is Fastly-only.
+            // The Fastly staging lifecycle is Fastly-only.
             AdapterAction::DeployStaged
             | AdapterAction::EmitVersion
             | AdapterAction::Healthcheck
             | AdapterAction::Rollback => Err(format!(
-                "cloudflare adapter does not support the Fastly staging lifecycle action {action:?} (spec §5.4)"
+                "cloudflare adapter does not support the Fastly staging lifecycle action {action:?}"
             )),
             other => Err(format!("cloudflare adapter does not support {other:?}")),
         }

crates/edgezero-adapter-fastly/src/cli.rs

@@ -137,10 +137,10 @@ const RUNTIME_ENV_STAGING_STORE: &str = "edgezero_runtime_env_staging";
 
 /// Env var carrying the Fastly API token (read by the Fastly CLI and
 /// forwarded to the Fastly API via the `Fastly-Key` header). Part of
-/// the Fastly staging lifecycle (deploy-github-action spec §5.4).
+/// the Fastly staging lifecycle.
 const FASTLY_API_TOKEN_ENV: &str = "FASTLY_API_TOKEN";
 /// Env var carrying the default Fastly service id, used when
-/// `--service-id` is not passed explicitly (spec §5.4).
+/// `--service-id` is not passed explicitly.
 const FASTLY_SERVICE_ID_ENV: &str = "FASTLY_SERVICE_ID";
 
 /// Flags `fastly compute update` accepts that take a VALUE (either
@@ -264,7 +264,7 @@ impl Adapter for FastlyCliAdapter {
             }
             AdapterAction::Deploy => deploy(args),
             AdapterAction::Serve => serve(args),
-            // Fastly staging lifecycle (deploy-github-action spec §5.4).
+            // Fastly staging lifecycle.
             AdapterAction::DeployStaged => deploy_staged(args),
             AdapterAction::EmitVersion => emit_active_version(args),
             AdapterAction::Healthcheck => healthcheck(args),
@@ -1049,8 +1049,8 @@ fn write_fastly_local_config_store(
 
     // Upsert into the existing per-store contents table so a
     // `config push --key app_config_staging` does NOT wipe the
-    // previously-pushed `app_config` blob. Spec 12.7 requires
-    // default + staging keys to coexist so the runtime
+    // previously-pushed `app_config` blob. The
+    // default + staging keys must coexist so the runtime
     // EDGEZERO__STORES__CONFIG__APP_CONFIG__KEY env var can
     // switch between them. (Earlier wholesale-replace was a
     // misread of the "stale entries don't linger" property:
@@ -1705,7 +1705,7 @@ pub fn serve(extra_args: &[String]) -> Result<(), String> {
 }
 
 // ===================================================================
-// Fastly staging lifecycle (deploy-github-action spec §5.4)
+// Fastly staging lifecycle
 // ===================================================================
 //
 // These entry points back the `deploy --stage`, `healthcheck`, and
@@ -1721,7 +1721,7 @@ pub fn serve(extra_args: &[String]) -> Result<(), String> {
 //   * rollback        → activate `<v>-1` (production) or deactivate
 //     `<v>` (staging) via the Fastly API.
 //
-// **Version-output contract (spec §5.4.2):** deploy/stage print a
+// **Version-output contract:** deploy/stage print a
 // single `version=<N>` line to stdout (via `log::info!`, which the CLI
 // logger emits verbatim). The `deploy-fastly` action greps that line
 // to surface `fastly-version`. Rollback prints `rolled-back-to=<N>`.
@@ -1865,7 +1865,7 @@ fn last_version_after(lower: &str, marker: &str, terminator: char) -> Option<u64
 /// Parse a Fastly service version out of Fastly CLI output, accepting
 /// ONLY the shapes the CLI actually emits, in precedence order:
 ///
-///   1. Our canonical `version=<N>` contract line (spec §5.4.2).
+///   1. Our canonical `version=<N>` contract line.
 ///   2. The CLI's success line, whose Go format string is
 ///      `"Updated package (service %s, version %v)"` (and
 ///      `"Deployed package (...)"` for `compute deploy`) — matched as
@@ -2252,7 +2252,7 @@ fn resolve_manifest_dir(args: &[String]) -> Result<PathBuf, String> {
         .ok_or_else(|| "fastly manifest has no parent directory".to_owned())
 }
 
-/// `deploy --adapter fastly --service-id <id> --stage` (spec §5.4):
+/// `deploy --adapter fastly --service-id <id> --stage`:
 /// build, upload to a new draft version (no activation), stage it, and
 /// emit `version=<N>`.
 fn deploy_staged(args: &[String]) -> Result<(), String> {
@@ -2490,7 +2490,7 @@ fn relink_runtime_env_for_staging(
     Ok(())
 }
 
-/// Production companion to `deploy` (spec §5.4.2): resolve the active
+/// Production companion to `deploy`: resolve the active
 /// service version via the Fastly API and emit `version=<N>`.
 fn emit_active_version(args: &[String]) -> Result<(), String> {
     let service_id = resolve_service_id(args)?;
@@ -2504,7 +2504,7 @@ fn emit_active_version(args: &[String]) -> Result<(), String> {
     Ok(())
 }
 
-/// `healthcheck --adapter fastly ...` (spec §5.4): probe the domain
+/// `healthcheck --adapter fastly ...`: probe the domain
 /// (production) or the version's staging IP (`--staging`), retrying up
 /// to `--retry` times. Emits `status-code` / `healthy` and returns
 /// `Err` (non-zero exit) when unhealthy after retries.
@@ -2596,7 +2596,7 @@ fn curl_status(args: &[String]) -> Result<u16, String> {
     })
 }
 
-/// `rollback --adapter fastly ...` (spec §5.4): production activates
+/// `rollback --adapter fastly ...`: production activates
 /// `<version> - 1`; staging deactivates `<version>`.
 fn rollback(args: &[String]) -> Result<(), String> {
     let service_id = resolve_service_id(args)?;
@@ -2664,7 +2664,7 @@ mod tests {
     // `edgezero_core::test_env`; the merge with edition-2024 main replaced our
     // local copy with it (its `set_var` calls are wrapped for 2024's unsafe-env).
 
-    // ── Fastly staging lifecycle helpers (spec §5.4) ──────────────────
+    // ── Fastly staging lifecycle helpers ──────────────────────────────
 
     #[test]
     fn arg_value_reads_flag_value() {
@@ -2825,7 +2825,7 @@ mod tests {
         }
     }
 
-    // ── healthcheck / rollback input validation (spec §5.4) ───────────
+    // ── healthcheck / rollback input validation ───────────────────────
     //
     // GitHub Actions' `required: true` does NOT fail when an input is
     // omitted or empty, so the CLI is the real guard. An absent / empty /
@@ -3025,7 +3025,7 @@ mod tests {
             parse_fastly_version("\nSUCCESS: Updated package (service SU1Z0, version 42)\n"),
             Some(42)
         );
-        // Our canonical contract line (spec §5.4.2).
+        // Our canonical contract line.
         assert_eq!(parse_fastly_version("version=12"), Some(12));
         // The --autoclone notice, when no success line is present.
         assert_eq!(
@@ -3488,7 +3488,7 @@ mod tests {
 
     #[test]
     fn setup_block_present_true_when_only_setup_exists() {
-        // Post-F6 (PR #269 round 2): `setup_block_present` only
+        // `setup_block_present` only
         // checks `[setup.<kind>_stores.<id>]`. The pre-fix check
         // ALSO required `[local_server.<kind>_stores.<id>]`, but
         // writing an empty `[local_server.*]` table didn't match
@@ -3530,7 +3530,7 @@ mod tests {
             after.contains("[setup.kv_stores.sessions]"),
             "setup table added: {after}"
         );
-        // Post-F6: no `[local_server.*]` write — that empty stanza
+        // No `[local_server.*]` write — that empty stanza
         // didn't satisfy fastly's local-server schema and made
         // `fastly compute serve` error or skip the store. Local-
         // server seeding is now `config push --adapter fastly
@@ -4664,7 +4664,7 @@ build = \"cargo build --release\"
         );
     }
 
-    /// Spec 12.7: pushing two blobs under different root keys
+    /// Pushing two blobs under different root keys
     /// (e.g. `app_config` + `app_config_staging`) must leave both
     /// keys readable from the local fastly.toml so the runtime
     /// `EDGEZERO__STORES__CONFIG__APP_CONFIG__KEY` override can
@@ -5082,14 +5082,14 @@ build = \"cargo build --release\"
         );
     }
 
-    /// Spec 12.3 + 9.3: a second oversized push must converge the
+    /// A second oversized push must converge the
     /// runtime on the NEW envelope — chunk keys are content-addressed
     /// by the full-envelope SHA, so push B writes a new chunk-set and
     /// installs a new root pointer.
     ///
     /// The local fastly.toml writer upserts per-key (so a sibling
-    /// `--key app_config_staging` push leaves `app_config` intact per
-    /// spec 12.7). Within the SAME root key, old chunks for envelope
+    /// `--key app_config_staging` push leaves `app_config` intact).
+    /// Within the SAME root key, old chunks for envelope
     /// A remain in the contents table after envelope B's push — they're
     /// unreferenced (the root pointer at `app_config` now names B's
     /// chunks), matching the remote Fastly behaviour where the
@@ -5111,7 +5111,7 @@ build = \"cargo build --release\"
 
         // First push: envelope A. Records the chunk-key set so we can
         // confirm they survive the second push (no garbage collection
-        // in v1 — spec 9.3 + Q6).
+        // in v1).
         let envelope_a = make_test_envelope(FASTLY_CONFIG_ENTRY_LIMIT.saturating_add(1));
         FastlyCliAdapter
             .push_config_entries_local(