Skip to content

Commit 3cbcc59

Browse files
committed
Clean up NEWS.md
1 parent 7614efd commit 3cbcc59

1 file changed

Lines changed: 4 additions & 12 deletions

File tree

NEWS.md

Lines changed: 4 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -48,24 +48,16 @@ different header was ignored if the executable was otherwise up to date. (#1235)
4848
`cpp_options` to the one actually used, so `$cpp_options()` no longer reports
4949
the ignored spelling after a successful compilation. (#1235)
5050
* A `$compile()` call that finds the executable up to date no longer erases
51-
`$cpp_options()`. Previously the recorded options were replaced with whatever
52-
the call supplied, so a bare `$compile()` on a model built with
53-
`cpp_options = list(stan_threads = TRUE)` dropped `stan_threads` and the
54-
executable then ran single-threaded. (#1235)
51+
`$cpp_options()`. (#1235)
5552
* `$expose_functions()` now works after a `$compile()` call that found the
56-
executable up to date. It previously failed with "not possible with a
57-
pre-compiled Stan model" on a model that had compiled itself. (#1235)
53+
executable up to date. (#1235)
5854
* A failed compilation no longer moves `$exe_file()` or replaces the generated
5955
C++ used by `$hpp_file()` and `fit$init_model_methods()`. Previously a failure
6056
at the C++ stage left the old executable paired with model methods generated
61-
from the new program. A `dry_run = TRUE` compilation likewise no longer records
62-
`$cpp_options()` or moves `$hpp_file()`, which previously pointed at a temporary
63-
file it never wrote. (#1235)
57+
from the new program. (#1235)
6458
* `$compile()` now warns when `cpp_options` are supplied but the existing
6559
executable is up to date and was not built with them, so nothing is rebuilt and
66-
the options have no effect. Previously they were recorded and reported as if
67-
they applied, so a model could print "2 thread(s) per chain" while running
68-
single-threaded. Use `force_recompile = TRUE` to rebuild. (#1235)
60+
the options have no effect. Use `force_recompile = TRUE` to rebuild. (#1235)
6961
* `$compile()` now errors if the newly compiled executable cannot be installed,
7062
restoring the previous executable. Previously the replacement was unchecked, so
7163
a failure could silently leave the model with no executable at all. (#1235)

0 commit comments

Comments
 (0)