Skip to content

Consider changing logger implementation #166

@makaimann

Description

@makaimann

A few reasons to change the logger implementation:

  • it seems like the logger evaluates all the arguments regardless of the verbosity (e.g. even if it doesn't print it). This means the to_string for large terms could be called all the time even at low verbosity.
  • I believe it is the only part of the codebase that uses C++17

Could consider looking into a stream based one -- maybe that would help. A macro could also work, but we do want to be able to change the verbosity dynamically so it would have to take an argument.

Metadata

Metadata

Assignees

Labels

enhancementNew feature or request

Type

No type

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions