minor fixes

Author: stefanak-michal

src/helpers/Client.php

@@ -19,7 +19,7 @@
 class Client
 {
     private function __construct() {}
-    
+
     private static $logHandler = null;
     private static $errorHandler = null;
     private static array $statistics = [];
@@ -36,7 +36,7 @@ private function __construct() {}
 
     /**
      * Assigned handler is called every time query is executed
-     * @var callable|null (string $query, array $params, array $statistics)
+     * @param callable|null $handler (string $query, array $params, array $statistics)
      */
     public static function setLogHandler(?callable $handler = null): void
     {
@@ -45,7 +45,7 @@ public static function setLogHandler(?callable $handler = null): void
 
     /**
      * Provided handler is invoked on Exception instead of trigger_error
-     * @var callable|null (Exception $e)
+     * @param callable|null $handler (Exception $e)
      */
     public static function setErrorHandler(?callable $handler = null): void
     {
@@ -54,9 +54,9 @@ public static function setErrorHandler(?callable $handler = null): void
 
     /**
      * Format failure response into exception message and throw it
-      *
-      * @param Response $response
-      * @throws Exception
+     *
+     * @param Response $response
+     * @throws Exception
      */
     private static function failureAsException(Response $response): void
     {
@@ -248,11 +248,11 @@ public static function queryFirstColumn(string $query, array $params = [], array
      */
     public static function begin(array $extra = []): bool
     {
-        if (version_compare(self::getProtocol()->getVersion(), '3', '<')) {
-            return false;
-        }
-
         try {
+            if (version_compare(self::getProtocol()->getVersion(), '3', '<')) {
+                return false;
+            }
+
             /** @var Response $response */
             $response = self::getProtocol()->begin($extra)->getResponse();
             if ($response->signature != Signature::SUCCESS) {
@@ -276,11 +276,11 @@ public static function begin(array $extra = []): bool
      */
     public static function commit(): bool
     {
-        if (version_compare(self::getProtocol()->getVersion(), '3', '<')) {
-            return false;
-        }
-
         try {
+            if (version_compare(self::getProtocol()->getVersion(), '3', '<')) {
+                return false;
+            }
+
             /** @var Response $response */
             $response = self::getProtocol()->commit()->getResponse();
             if ($response->signature != Signature::SUCCESS) {
@@ -304,11 +304,11 @@ public static function commit(): bool
      */
     public static function rollback(): bool
     {
-        if (version_compare(self::getProtocol()->getVersion(), '3', '<')) {
-            return false;
-        }
-        
         try {
+            if (version_compare(self::getProtocol()->getVersion(), '3', '<')) {
+                return false;
+            }
+
             /** @var Response $response */
             $response = self::getProtocol()->rollback()->getResponse();
             if ($response->signature != Signature::SUCCESS) {

tests/helpers/ClientTest.php

@@ -64,7 +64,7 @@ public function testQuery(): void
 
     public function testErrorHandler(): void
     {
-        $testsuite = self::getTestSuite();
+        $testsuite = $this->getTestSuite();
         if ($testsuite !== 'Neo4j') {
             $this->markTestSkipped('This test is only executed with Neo4j, skipping.');
         }