Address review: remove redundant phase check, document ALT estimation variables

Agent-Logs-Url: https://github.com/steffenaxer/matsim-libs/sessions/b1cbd2a4-34d0-4967-9e33-d5d221f864be

Co-authored-by: steffenaxer <26229392+steffenaxer@users.noreply.github.com>

Author: Copilot

matsim/src/main/java/org/matsim/core/router/speedy/CHQueryExporter.java

@@ -592,15 +592,23 @@ private static SpeedyALTQueryResult runInstrumentedSpeedyALT(SpeedyGraph graph,
     }
 
     /**
-     * ALT lower-bound estimation: max over all landmarks of (SL-TL) and (LT-LS).
+     * ALT lower-bound estimation: max over all landmarks L of (SL−TL) and (LT−LS),
+     * where S=source, T=target.
+     * <ul>
+     *   <li>sl = cost(source → landmark L)</li>
+     *   <li>ls = cost(landmark L → source)</li>
+     *   <li>tl = cost(target → landmark L)</li>
+     *   <li>lt = cost(landmark L → target)</li>
+     * </ul>
+     * By the triangle inequality: ST ≥ SL−TL and ST ≥ LT−LS.
      */
     private static double estimateMinCost(SpeedyALTData altData, int nodeIdx, int destinationIdx) {
         double best = 0;
         for (int i = 0, nL = altData.getLandmarksCount(); i < nL; i++) {
-            double sl = altData.getTravelCostToLandmark(nodeIdx, i);
-            double ls = altData.getTravelCostFromLandmark(nodeIdx, i);
-            double tl = altData.getTravelCostToLandmark(destinationIdx, i);
-            double lt = altData.getTravelCostFromLandmark(destinationIdx, i);
+            double sl = altData.getTravelCostToLandmark(nodeIdx, i);       // source → L
+            double ls = altData.getTravelCostFromLandmark(nodeIdx, i);     // L → source
+            double tl = altData.getTravelCostToLandmark(destinationIdx, i); // target → L
+            double lt = altData.getTravelCostFromLandmark(destinationIdx, i); // L → target
             double estimate = Math.max(sl - tl, lt - ls);
             if (estimate > best) best = estimate;
         }

matsim/tools/ch-viz/ch-visualization.html

@@ -1040,7 +1040,7 @@ <h2>Search Space Comparison</h2>
   }
 
   // After 2 seconds of showing the path, display final overlay
-  if (phase === 1 && pathRevealStart > 0 && Date.now() - pathRevealStart > 2000 && phase < 2) {
+  if (phase === 1 && pathRevealStart > 0 && Date.now() - pathRevealStart > 2000) {
     phase = 2;
     showFinalOverlay();
     // Keep recording for 3 more seconds to capture the final overlay