Commit 6b4b5b0
Rename allowance expiration argument to live_until_ledger (#1932)
### What
Renames the `approve` allowance-expiration argument from
`expiration_ledger` to `live_until_ledger` in both the `TokenInterface`
and `StellarAssetInterface` traits, aligning the SDK with the SEP-41
spec. The `Approve` event's data field doc is left as
`expiration_ledger` to preserve on-chain event compatibility.
### Why
The argument name is part of the generated contract spec XDR.
`TokenInterface` had been updated to `live_until_ledger` (matching
SEP-41), but `StellarAssetInterface` still used `expiration_ledger`, so
the two `approve` spec entries no longer matched and
`test_stellar_asset_spec_includes_token_spec` failed. Aligning both
traits to the SEP-41 name fixes the mismatch. All ten SEP-41 functions
and their argument names were checked; `approve` was the only
discrepancy.
### Known limitations
N/A
---------
Co-authored-by: Leigh <351529+leighmcculloch@users.noreply.github.com>1 parent e5cb4b5 commit 6b4b5b0
1 file changed
Lines changed: 6 additions & 6 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
114 | 114 | | |
115 | 115 | | |
116 | 116 | | |
117 | | - | |
| 117 | + | |
118 | 118 | | |
119 | | - | |
| 119 | + | |
120 | 120 | | |
121 | 121 | | |
122 | 122 | | |
123 | 123 | | |
124 | 124 | | |
125 | 125 | | |
126 | | - | |
| 126 | + | |
127 | 127 | | |
128 | 128 | | |
129 | 129 | | |
| |||
276 | 276 | | |
277 | 277 | | |
278 | 278 | | |
279 | | - | |
| 279 | + | |
280 | 280 | | |
281 | | - | |
| 281 | + | |
282 | 282 | | |
283 | 283 | | |
284 | 284 | | |
285 | 285 | | |
286 | 286 | | |
287 | 287 | | |
288 | | - | |
| 288 | + | |
289 | 289 | | |
290 | 290 | | |
291 | 291 | | |
| |||
0 commit comments