rename: as_contract_with_func -> as_contract_fn

The existing as_contract already takes a closure (func), so _with_func
did not distinguish the new API. Rename to as_contract_fn /
try_as_contract_fn to make clear the extra Symbol argument is the
contract function name used for the auth frame (mock_auths / auths).

Addresses review feedback from @leighmcculloch on #1920.

Author: shinzoxD

soroban-sdk/src/env.rs

@@ -1738,7 +1738,7 @@ impl Env {
     /// current contract function for authorization. This lets
     /// [`mock_auths`][Self::mock_auths] and [`auths`][Self::auths] observe the
     /// same function name that [`Address::require_auth`] uses.
-    pub fn as_contract_with_func<T>(
+    pub fn as_contract_fn<T>(
         &self,
         id: &Address,
         func: &crate::Symbol,
@@ -1846,7 +1846,7 @@ impl Env {
     /// the current contract function for authorization. This lets
     /// [`mock_auths`][Self::mock_auths] and [`auths`][Self::auths] observe the
     /// same function name that [`Address::require_auth`] uses.
-    pub fn try_as_contract_with_func<T, E>(
+    pub fn try_as_contract_fn<T, E>(
         &self,
         id: &Address,
         func: &crate::Symbol,

soroban-sdk/src/tests/env.rs

@@ -358,7 +358,7 @@ fn test_register_restores_auth_before_panics() {
 }
 
 #[test]
-fn test_as_contract_with_func() {
+fn test_as_contract_fn() {
     use crate::testutils::{MockAuth, MockAuthInvoke};
     use crate::IntoVal;
 
@@ -379,13 +379,13 @@ fn test_as_contract_with_func() {
         },
     }]);
 
-    env.as_contract_with_func(&test_contract_id, &func_name, || {
+    env.as_contract_fn(&test_contract_id, &func_name, || {
         user.require_auth();
     });
 }
 
 #[test]
-fn test_try_as_contract_with_func() {
+fn test_try_as_contract_fn() {
     use crate::testutils::{MockAuth, MockAuthInvoke};
     use crate::IntoVal;
 
@@ -407,7 +407,7 @@ fn test_try_as_contract_with_func() {
         },
     }]);
 
-    let result = env.try_as_contract_with_func::<Symbol, Error>(&addr, &func_name, || {
+    let result = env.try_as_contract_fn::<Symbol, Error>(&addr, &func_name, || {
         user.require_auth();
         Symbol::new(&env, "hello")
     });